From corky1951@comcast.net  Wed Jul  1 03:28:10 2009
Return-Path: <corky1951@comcast.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 655A41065670
	for <freebsd-gnats-submit@freebsd.org>; Wed,  1 Jul 2009 03:28:10 +0000 (UTC)
	(envelope-from corky1951@comcast.net)
Received: from QMTA07.emeryville.ca.mail.comcast.net (qmta07.emeryville.ca.mail.comcast.net [76.96.30.64])
	by mx1.freebsd.org (Postfix) with ESMTP id 4FB3D8FC0A
	for <freebsd-gnats-submit@freebsd.org>; Wed,  1 Jul 2009 03:28:10 +0000 (UTC)
	(envelope-from corky1951@comcast.net)
Received: from OMTA16.emeryville.ca.mail.comcast.net ([76.96.30.72])
	by QMTA07.emeryville.ca.mail.comcast.net with comcast
	id AT0U1c0071ZMdJ4A7TUBmA; Wed, 01 Jul 2009 03:28:11 +0000
Received: from comcast.net ([98.203.142.76])
	by OMTA16.emeryville.ca.mail.comcast.net with comcast
	id ATVU1c0011f6R9u8cTVUYV; Wed, 01 Jul 2009 03:29:28 +0000
Received: by comcast.net (sSMTP sendmail emulation); Tue, 30 Jun 2009 20:28:08 -0700
Message-Id: <20090701032810.4FB3D8FC0A@mx1.freebsd.org>
Date: Tue, 30 Jun 2009 20:28:08 -0700
From: Charlie Kester <corky1951@comcast.net>
Reply-To: Charlie Kester <corky1951@comcast.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER PATCH] sysutils/rdup - fix build problem on 8.0-CURRENT
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         136208
>Category:       ports
>Synopsis:       [MAINTAINER PATCH] sysutils/rdup - fix build problem on 8.0-CURRENT
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 01 03:30:02 UTC 2009
>Closed-Date:    Sat Jul 04 19:31:01 UTC 2009
>Last-Modified:  Sat Jul  4 19:40:00 UTC 2009
>Originator:     Charlie Kester
>Release:        FreeBSD 7.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD atom.local 7.2-RELEASE FreeBSD 7.2-RELEASE #1: Mon May 4 15:50:49 PDT 2009 root@atom.local:/usr/obj/usr/src/sys/ATOM i386

>Description:

See build error log at:  
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/a.8.20090621131742/rdup-1.0.0.log

Packaging failed because component rdup-tr was not found.  Configure failed to
detect libnettle and libarchive, so rdup-tr was not built.

Problem was reported on 8.0-CURRENT, but I have seen a similar failure to detect
libnettle on 7.2-RELEASE.

To fix this problem, the attached patch sets LDFLAGS in CONFIGURE_ENV.

It also replaces the original configure script patch with a cleaner patch of 
configure.ac

>How-To-Repeat:

This failure will occur whenever environment variable LDFLAGS is undefined or
does not point to location of libnettle and libarchive.

>Fix:

--- rdup-1.0.0.diff begins here ---
diff -ruN /usr/ports/sysutils/rdup/Makefile ./rdup/Makefile
--- /usr/ports/sysutils/rdup/Makefile	2009-06-30 10:44:44.000000000 -0700
+++ ./rdup/Makefile	2009-06-30 19:54:16.000000000 -0700
@@ -6,23 +6,25 @@
 # $FreeBSD: ports/sysutils/rdup/Makefile,v 1.1 2009/06/19 05:29:46 miwi Exp $
 #
 
-PORTNAME=		rdup
+PORTNAME=	rdup
 PORTVERSION=	1.0.0
-CATEGORIES=		sysutils
+CATEGORIES=	sysutils
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE} \
-				http://miek.nl/projects/rdup/
+		http://miek.nl/projects/rdup/
 
 MAINTAINER=	corky1951@comcast.net
 COMMENT=	A tool to generate an (incremental) backup file list
 
 LIB_DEPENDS=	glib-2.0:${PORTSDIR}/devel/glib20 \
-				pcre:${PORTSDIR}/devel/pcre \
-				archive:${PORTSDIR}/archivers/libarchive \
-				nettle:${PORTSDIR}/security/nettle
+		pcre:${PORTSDIR}/devel/pcre \
+		archive:${PORTSDIR}/archivers/libarchive \
+		nettle:${PORTSDIR}/security/nettle
 
-USE_BZIP2=		yes
+USE_BZIP2=	yes
 
+USE_AUTOTOOLS=	autoconf:262
 GNU_CONFIGURE=	yes
+CONFIGURE_ENV+=	LDFLAGS="-L${LOCALBASE}/lib ${LDFLAGS}"
 
 USE_GMAKE=	yes
 MAKEFILE=	GNUmakefile
diff -ruN /usr/ports/sysutils/rdup/files/patch-configure ./rdup/files/patch-configure
--- /usr/ports/sysutils/rdup/files/patch-configure	2009-06-18 22:29:46.000000000 -0700
+++ ./rdup/files/patch-configure	1969-12-31 16:00:00.000000000 -0800
@@ -1,20 +0,0 @@
---- configure.orig	2009-05-31 00:38:33.000000000 -0700
-+++ configure	2009-06-12 16:34:06.000000000 -0700
-@@ -5003,7 +5003,7 @@
-   $as_echo_n "(cached) " >&6
- else
-   ac_check_lib_save_LIBS=$LIBS
--LIBS="-lnettle  $LIBS"
-+LIBS="-lgmp -lnettle  $LIBS"
- cat >conftest.$ac_ext <<_ACEOF
- /* confdefs.h.  */
- _ACEOF
-@@ -5067,7 +5067,7 @@
- #define HAVE_LIBNETTLE 1
- _ACEOF
- 
--  LIBS="-lnettle $LIBS"
-+  LIBS="-lgmp -lnettle $LIBS"
- 
- else
-   NETTLE_L="no"
diff -ruN /usr/ports/sysutils/rdup/files/patch-configure.ac ./rdup/files/patch-configure.ac
--- /usr/ports/sysutils/rdup/files/patch-configure.ac	1969-12-31 16:00:00.000000000 -0800
+++ ./rdup/files/patch-configure.ac	2009-06-30 17:50:00.000000000 -0700
@@ -0,0 +1,11 @@
+--- configure.ac.orig	2009-05-28 10:39:19.000000000 -0700
++++ configure.ac	2009-06-30 17:49:08.000000000 -0700
+@@ -28,6 +28,8 @@
+ #AM_GNU_GETTEXT([external])
+ #AM_GNU_GETTEXT_VERSION
+ 
++LIBS="-lgmp $LIBS"
++
+ AC_MSG_CHECKING([whether to enable nettle])
+ AC_ARG_WITH(nettle,
+     [  --with-nettle           enable nettle support],
--- rdup-1.0.0.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Wed Jul 1 08:53:30 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136208 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Sat Jul 4 19:31:00 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136208 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/136208: commit references a PR
Date: Sat,  4 Jul 2009 19:31:06 +0000 (UTC)

 miwi        2009-07-04 19:30:52 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/rdup        Makefile 
   Log:
   - Fix build with HEAD
   - Makefile cleanup
   
   PR:             136208
   Submitted by:   Charlie Kester <corky1951@comcast.net> (maintainer)
   
   Revision  Changes    Path
   1.2       +9 -7      ports/sysutils/rdup/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
