From mwisnicki@gmail.com  Mon Jun  1 14:34:09 2009
Return-Path: <mwisnicki@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A9E071065670
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  1 Jun 2009 14:34:09 +0000 (UTC)
	(envelope-from mwisnicki@gmail.com)
Received: from mail-fx0-f163.google.com (mail-fx0-f163.google.com [209.85.220.163])
	by mx1.freebsd.org (Postfix) with ESMTP id 0CA968FC1E
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  1 Jun 2009 14:34:08 +0000 (UTC)
	(envelope-from mwisnicki@gmail.com)
Received: by fxm7 with SMTP id 7so1141238fxm.43
        for <multiple recipients>; Mon, 01 Jun 2009 07:34:08 -0700 (PDT)
Received: by 10.103.131.13 with SMTP id i13mr507075mun.13.1243866847995;
        Mon, 01 Jun 2009 07:34:07 -0700 (PDT)
Received: from ghost.pnet.one.pl (static-78-8-147-77.ssp.dialog.net.pl [78.8.147.77])
        by mx.google.com with ESMTPS id 14sm14329274muo.3.2009.06.01.07.34.05
        (version=TLSv1/SSLv3 cipher=RC4-MD5);
        Mon, 01 Jun 2009 07:34:06 -0700 (PDT)
Received: by ghost.pnet.one.pl (sSMTP sendmail emulation); Mon,  1 Jun 2009 16:34:04 +0200
Message-Id: <4a23e6de.0e0f660a.507c.3ec4@mx.google.com>
Date: Mon,  1 Jun 2009 16:34:04 +0200
From: Marcin Wisnicki <mwisnicki+freebsd@gmail.com>
Sender: =?UTF-8?Q?Marcin_Wi=C5=9Bnicki?= <mwisnicki@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: dinoex@FreeBSD.org
Subject: [PATCH] print/cups: broken metaport does not install
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         135157
>Category:       ports
>Synopsis:       [PATCH] print/cups: broken metaport does not install
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 01 14:40:02 UTC 2009
>Closed-Date:    Wed Jul 22 06:31:22 CEST 2009
>Last-Modified:  Wed Jul 22 13:00:11 UTC 2009
>Originator:     Marcin Wisnicki
>Release:        FreeBSD 7.2-STABLE i386
>Organization:
>Environment:
System: FreeBSD ghost.pnet.one.pl 7.2-STABLE FreeBSD 7.2-STABLE #0: Wed May  6 20:43:28 CEST
>Description:
As discussed[1] earlier, metaports should not use NO_INSTALL or BUILD_DEPENDS.

[1] http://lists.freebsd.org/pipermail/freebsd-ports/2009-May/054519.html

Port maintainer (dinoex@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- cups-1.3.10_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/print/cups.orig/Makefile /usr/ports/print/cups/Makefile
--- /usr/ports/print/cups.orig/Makefile	2009-05-08 01:22:54.000000000 +0200
+++ /usr/ports/print/cups/Makefile	2009-06-01 16:19:12.000000000 +0200
@@ -9,6 +9,7 @@
 
 PORTNAME=	cups
 PORTVERSION=	1.3.10
+PORTREVISION=	1
 CATEGORIES=	print
 MASTER_SITES=	# empty
 DISTFILES=	# empty
@@ -16,11 +17,12 @@
 MAINTAINER=	dinoex@FreeBSD.org
 COMMENT=	Common UNIX Printing System: Metaport to install complete system
 
-BUILD_DEPENDS=	espgs:${PORTSDIR}/${PKGCATEGORY}/cups-pstoraster \
+RUN_DEPENDS=	espgs:${PORTSDIR}/${PKGCATEGORY}/cups-pstoraster \
 		cupsd:${PORTSDIR}/${PKGCATEGORY}/cups-base
-RUN_DEPENDS=	${BUILD_DEPENDS}
 
 NO_BUILD=	yes
-NO_INSTALL=	yes
+
+do-install:
+		@${DO_NADA}
 
 .include <bsd.port.mk>
--- cups-1.3.10_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jun 1 14:40:19 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=135157 
State-Changed-From-To: open->feedback 
State-Changed-By: dinoex 
State-Changed-When: Mon Jun 1 17:26:52 CEST 2009 
State-Changed-Why:  

Acording to bsd.port.mk: 
# Set these variables if your port doesn't need some of the steps. 
# Note that there are no NO_PATCH or NO_CONFIGURE variables because 
# those steps are empty by default.  NO_EXTRACT is not allowed anymore 
# since we need to at least create ${WRKDIR}.  Also, NO_CHECKSUM is a user 
# variable and is not to be set in a port's Makefile.  See above for NO_PACKAGE. 
# 
# NO_BUILD      - Use a dummy (do-nothing) build target. 
# NO_INSTALL    - Use a dummy (do-nothing) install target. 

It was around in 2006 when the meta-ports all had NO_INSTALL. 

Around that time, ports with NO_INSTALL did no longer create a package. 
Which was the intentend behavior/behaviour, 

kind regards Dirk 


http://www.freebsd.org/cgi/query-pr.cgi?pr=135157 
State-Changed-From-To: feedback->closed 
State-Changed-By: dinoex 
State-Changed-When: Sat Jul 18 13:04:38 CEST 2009 
State-Changed-Why:  
no feedback here or in thread on ports@ 

http://www.freebsd.org/cgi/query-pr.cgi?pr=135157 

From: Marcin Wisnicki <mwisnicki+freebsd@gmail.com>
To: dinoex@freebsd.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/135157: [PATCH] print/cups: broken metaport does not 
	install
Date: Sun, 19 Jul 2009 19:17:38 +0200

 On Sat, Jul 18, 2009 at 13:05, <dinoex@freebsd.org> wrote:
 > Synopsis: [PATCH] print/cups: broken metaport does not install
 >
 > State-Changed-From-To: feedback->closed
 > State-Changed-By: dinoex
 > State-Changed-When: Sat Jul 18 13:04:38 CEST 2009
 > State-Changed-Why:
 > no feedback here or in thread on ports@
 
 Well, I did respond to your previous mail.
 Unfortunately mails generated by GNATS lack bug-followup@ in CC and
 I forgot to add it myself, sorry about that :(
 
 Anyway, I'm going to reproduce my response here:
 
 <quote>
 Well, if this flag was supposed to be used by metaports then it is
 broken by design.
 
 Justification why such behaviour is not acceptable was given in linked thread.
 Several people agreed and there are many high profile meta-ports like gnome that
 do it the right way.
 
 If you have any technical objections why this change is wrong then
 please voice them.
 </quote>
 
 Since you did not address my concerns and the thread ended with conclusion [1]
 by one of committers that such behaviour of print/cups was indeed erratic and I
 should file a PR, I don't see how this bug could be considered closed.
 Please reopen it.
 
 Thanks.
 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=135157
State-Changed-From-To: closed->analyzed 
State-Changed-By: dinoex 
State-Changed-When: Wed Jul 22 06:27:45 CEST 2009 
State-Changed-Why:  
- reopen after feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=135157 
State-Changed-From-To: analyzed->closed 
State-Changed-By: dinoex 
State-Changed-When: Wed Jul 22 06:28:21 CEST 2009 
State-Changed-Why:  

Please check. 

you wrote: 
This will prevent such port from registering its installation in /var/db/ 
pkg, which is different behaviour from installing it from prebuilt  
package (where it registers just fine). 

The use of use NO_INSTALL does no longer have this effect. 

# ls -tlr /usr/ports/packages7/All/cups-1.3.10.tbz  
-rw-r--r--  1 root  wheel  2774 Jul 22 06:15 /usr/ports/packages7/All/cups-1.3.10.tbz 

# ls -d /var/db/pkg/cups-* 
/var/db/pkg/cups-1.3.10                 /var/db/pkg/cups-client-1.3.10_3        /var/db/pkg/cups-pstoraster-8.15.4_3 
/var/db/pkg/cups-base-1.3.10_3          /var/db/pkg/cups-image-1.3.10_3 


http://www.freebsd.org/cgi/query-pr.cgi?pr=135157 

From: Marcin Wisnicki <mwisnicki+freebsd@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/135157: [PATCH] print/cups: broken metaport does not 
	install
Date: Wed, 22 Jul 2009 14:50:02 +0200

 On Wed, Jul 22, 2009 at 06:31, <dinoex@freebsd.org> wrote:
 > Synopsis: [PATCH] print/cups: broken metaport does not install
 >
 > State-Changed-From-To: analyzed->closed
 > State-Changed-By: dinoex
 > State-Changed-When: Wed Jul 22 06:28:21 CEST 2009
 > State-Changed-Why:
 >
 > Please check.
 >
 > you wrote:
 > This will prevent such port from registering its installation in /var/db/
 > pkg, which is different behaviour from installing it from prebuilt
 > package (where it registers just fine).
 >
 > The use of use NO_INSTALL does no longer have this effect.
 >
 > # ls -tlr /usr/ports/packages7/All/cups-1.3.10.tbz
 > -rw-r--r--  1 root  wheel  2774 Jul 22 06:15 /usr/ports/packages7/All/cups-1.3.10.tbz
 >
 > # ls -d /var/db/pkg/cups-*
 > /var/db/pkg/cups-1.3.10                 /var/db/pkg/cups-client-1.3.10_3        /var/db/pkg/cups-pstoraster-8.15.4_3
 > /var/db/pkg/cups-base-1.3.10_3          /var/db/pkg/cups-image-1.3.10_3
 >
 
 Hmmm... not for me. I've just removed print/cups and reinstalled it
 from fresh ports:
 
 # portinstall cups
 --->  Installing 'cups-1.3.10' from a port (print/cups)
 --->  Building '/usr/ports/print/cups'
 ===>  Cleaning for cups-1.3.10
 ===>  Extracting for cups-1.3.10
 ===>  Patching for cups-1.3.10
 ===>   cups-1.3.10 depends on executable: espgs - found
 ===>   cups-1.3.10 depends on executable: cupsd - found
 ===>  Configuring for cups-1.3.10
 --->  Installing the new version via the port
 ===>  Building package for cups-1.3.10
 ===>   Generating temporary packing list
 Creating package /home/pub/freebsd/packages/ghost-7-stable/All/cups-1.3.10.tbz
 Registering depends: cups-base-1.3.10_2 cups-pstoraster-8.15.4_3
 ghostscript8-nox11-8.64_5 cups-image-1.3.10_2 cups-client-1.3.10_2
 gnutls-2.6.5 libgcrypt-1.4.4 libgpg-error-1.7 gettext-0.17_1
 libiconv-1.13 fontconfig-2.6.0,1 freetype2-2.3.9_1 libtasn1-2.1
 pkg-config-0.23_1 tiff-3.8.2_3 jpeg-6b_7 png-1.2.35 gsfonts-8.11_5
 expat-2.0.1.
 Creating bzip'd tar ball in
 '/home/pub/freebsd/packages/ghost-7-stable/All/cups-1.3.10.tbz'
 ===>  Cleaning for cups-1.3.10
 
 Notice lack of step "===>   Registering installation for ${PKGNAME}"
 
 Same thing if I do it directly:
 
 # cd /usr/ports/print/cups && make clean && make install
 ===>  Extracting for cups-1.3.10
 ===>  Patching for cups-1.3.10
 ===>   cups-1.3.10 depends on executable: espgs - found
 ===>   cups-1.3.10 depends on executable: cupsd - found
 ===>  Configuring for cups-1.3.10
 
 # ls -d /var/db/pkg/cups-*
 /var/db/pkg/cups-base-1.3.10_2       /var/db/pkg/cups-image-1.3.10_2
   /var/db/pkg/cups-samba-6.0_2
 /var/db/pkg/cups-client-1.3.10_2     /var/db/pkg/cups-pstoraster-8.15.4_3
 
 # pkg_deinstall cups-1.3.10
 ** No matching package found.
 
 Looking at /usr/ports/Mk/bsd.ports.mk [1] there is no way this could work.
 
 1. Package registration is handled by target fake-pkg at line 5828
 2. fake-pkg is included in _INSTALL_SUSEQ list at line 4202
 3. ${_INSTALL_SUSEQ} is defined as dependency of ${INSTALL_COOKIE} at line 4259
 4. ${INSTALL_COOKIE} is defined as dependency of target install at line 4232
 5. step 4 is performed only when target install is undefined, see line 4231
 However:
 6. when NO_INSTALL is defined then target install is defined earlier
 at line 3316
 
 Easy way to verify:
 a) with current version:
 
 # make -p install | egrep ^install.\ +:
 install         : build
 
 b) with my patch:
 
 # make -p install | egrep ^install.\ +:
 install         : /usr/ports/print/cups/work/.install_done.cups._usr_local
 
 So please reopen or preferably commit my patch ;-)
 
 [1] http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk?annotate=1.624
 
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=135157
 >
>Unformatted:
