From nobody@FreeBSD.org  Sun May 31 16:09:10 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C6709106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 31 May 2009 16:09:10 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id B4CA28FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 31 May 2009 16:09:10 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n4VG98Qt025374
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 31 May 2009 16:09:08 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n4VG97dC025372;
	Sun, 31 May 2009 16:09:08 GMT
	(envelope-from nobody)
Message-Id: <200905311609.n4VG97dC025372@www.freebsd.org>
Date: Sun, 31 May 2009 16:09:08 GMT
From: Vladimir Chukharev <chukharev@mail.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] ports-mgmt/portlint should check for a.out filename
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         135095
>Category:       ports
>Synopsis:       [patch] ports-mgmt/portlint should check for a.out filename
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    marcus
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 31 16:10:01 UTC 2009
>Closed-Date:    Thu Jul 09 01:41:45 UTC 2009
>Last-Modified:  Thu Jul 09 01:41:45 UTC 2009
>Originator:     Vladimir Chukharev
>Release:        7.2-STABLE
>Organization:
>Environment:
FreeBSD chu.me.tut.fi 7.2-STABLE FreeBSD 7.2-STABLE #0: Sat May  9 00:01:08 EEST 2009     root@chu.me.tut.fi:/usr/obj/usr/src/sys/CHU  i386

>Description:
This PR is a follow-up to ports/131790 and related to conf/129697.

As reported in ports/131790, some files are deleted if periodic.conf has
daily_clean_disks_enable="YES". The full list of pattens for removing is
defined in /etc/defaults/periodic.conf as
daily_clean_disks_files="[#,]* .#* a.out *.core *.CKP .emacs_[0-9]*"

ports/131790 was closed after a check for *.core was added. The attached patch
add a check for files named "a.out". The lang/sbcl port installs two files with 
this name.

I am not proficient in pattern matching and perl, so I do not even try to fix 
portlint for all the list of patterns.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- ports-mgmt/portlint/src/portlint.pl.orig	2009-05-31 18:20:09.000000000 +0300
+++ ports-mgmt/portlint/src/portlint.pl	2009-05-31 18:20:09.000000000 +0300
@@ -831,6 +831,13 @@
 				"If possible, install this file with a different name.");
 		}
 
+		if ($_ =~ m|/a.out$| && $_ !~ /^\@/) {
+			&perror("WARN", $file, $., "this port installs a file named ".
+				"\"a.out\".  This file may be deleted if ".
+				"daily_clean_disks_enable=\"YES\" in /etc/periodic.conf.  ".
+				"If possible, install this file with a different name.");
+		}
+
 		if ($autoinfo && $_ =~ /\.info$/) {
 			&perror("WARN", $file, $., "enumerating info files in the plist is deprecated in favor of adding info files into the Makefile using the INFO macro.");
 		}


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->marcus 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun May 31 16:10:13 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=135095 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/135095: commit references a PR
Date: Thu,  9 Jul 2009 01:03:52 +0000 (UTC)

 marcus      2009-07-09 01:03:38 UTC
 
   FreeBSD ports repository
 
   Modified files:
     ports-mgmt/portlint  Makefile pkg-plist 
     ports-mgmt/portlint/src portlint.pl 
   Log:
   Update to 2.12.0.
   
   * Add support for bsd.port.options.mk. [1]
   * Add a check for ports that install a.out. [2]
   * Tweak the check for arguments passed to configure when using
     GNU_CONFIGURE, and add a check for HAS_CONFIGURE and GNU_CONFIGURE. [3]
   * Fix some false positives that occur when using certain combinations of
     %%XXXDIR%%. [4]
   
   PR:             135095 [2]
                   135858 [3]
                   136465 [4]
   Requested by:   pav [1]
   Submitted by:   Vladimir Chukharev <chukharev@mail.ru> [2]
                   Sahil Tandon <sahil@tandon.net> [3]
                   Eygene Ryabinkin <rea-fbsd@codelabs.ru> [4]
   
   Revision  Changes    Path
   1.133     +4 -1      ports/ports-mgmt/portlint/Makefile
   1.6       +1 -1      ports/ports-mgmt/portlint/pkg-plist
   1.110     +44 -10    ports/ports-mgmt/portlint/src/portlint.pl
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Thu Jul 9 01:41:30 UTC 2009 
State-Changed-Why:  
Committed to 2.12.0.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=135095 
>Unformatted:
