From marck@woozle.rinet.ru  Tue May 26 11:07:51 2009
Return-Path: <marck@woozle.rinet.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B04F110656C3
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 26 May 2009 11:07:51 +0000 (UTC)
	(envelope-from marck@woozle.rinet.ru)
Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68])
	by mx1.freebsd.org (Postfix) with ESMTP id 15BF18FC32
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 26 May 2009 11:07:50 +0000 (UTC)
	(envelope-from marck@woozle.rinet.ru)
Received: from woozle.rinet.ru (localhost [127.0.0.1])
	by woozle.rinet.ru (8.14.3/8.14.3) with ESMTP id n4QArIvF087477
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 26 May 2009 14:53:18 +0400 (MSD)
	(envelope-from marck@woozle.rinet.ru)
Received: (from marck@localhost)
	by woozle.rinet.ru (8.14.3/8.14.3/Submit) id n4QArIJe087476;
	Tue, 26 May 2009 14:53:18 +0400 (MSD)
	(envelope-from marck)
Message-Id: <200905261053.n4QArIJe087476@woozle.rinet.ru>
Date: Tue, 26 May 2009 14:53:18 +0400 (MSD)
From: Dmitry Morozovsky <marck@freebsd.org>
Reply-To: Dmitry Morozovsky <marck@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: sysutils/smartmontools fix for daily script
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         134954
>Category:       ports
>Synopsis:       sysutils/smartmontools fix for daily script
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 26 11:10:02 UTC 2009
>Closed-Date:    Fri May 29 12:13:35 UTC 2009
>Last-Modified:  Fri May 29 12:20:01 UTC 2009
>Originator:     Dmitry Morozovsky
>Release:        FreeBSD 7-STABLE i386
>Organization:
Cronyx Plus LLC (RiNet ISP)
>Environment:
System: FreeBSD 7-STABLE 


>Description:

Fix typo in smart periodic script.  
Add simple autodetect mode (works only for regular disks).

>How-To-Repeat:

>Fix:


Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/sysutils/smartmontools/Makefile,v
retrieving revision 1.38
diff -u -r1.38 Makefile
--- Makefile	25 May 2009 12:28:25 -0000	1.38
+++ Makefile	26 May 2009 10:51:29 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	smartmontools
 PORTVERSION=	5.38
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	sysutils
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	${PORTNAME}
Index: files/smart.in
===================================================================
RCS file: /home/ncvs/ports/sysutils/smartmontools/files/smart.in,v
retrieving revision 1.3
diff -u -r1.3 smart.in
--- files/smart.in	31 Dec 2008 16:58:11 -0000	1.3
+++ files/smart.in	26 May 2009 10:51:29 -0000
@@ -12,12 +12,21 @@
 smartctl=%%PREFIX%%/sbin/smartctl
 : ${daily_status_smartctl_flags="-H"}
 : ${daily_status_smartctl_extra_status_flags="-a"}
-# no default for ${daily_status_smart_devices}
+
+case "${daily_status_smart_devices}" in
+	# XXX AUTO mode selects only regular ad/da disks 
+	[Aa][Uu][Tt][Oo])
+		daily_status_smart_devices=`ls /dev/da*[0-9] /dev/ad*[0-9] 2>/dev/null`
+		;;
+	*)	;;
+esac
+
 if [ -z "${daily_status_smart_devices}" ]; then
-	: ${daily_status_smart_enabled="NO"}
+	: ${daily_status_smart_enable="NO"}
 else
-	: ${daily_status_smart_enabled="YES"}
+	: ${daily_status_smart_enable="YES"}
 fi
+
 trim_junk="tail -n +4"
 
 tmpfile="$(mktemp /var/run/daily.XXXXXXXX)"
@@ -25,9 +34,7 @@
 
 rc=0
 case "${daily_status_smart_enable}" in
-	[Nn][Oo])
-		;;
-	*)
+	[Yy][Ee][Ss])
 		for device in ${daily_status_smart_devices}; do
 			if [ -e ${device} ]; then
 				echo 
>Release-Note:
>Audit-Trail:
Class-Changed-From-To: sw-bug->maintainer-update 
Class-Changed-By: edwin 
Class-Changed-When: Tue May 26 11:10:14 UTC 2009 
Class-Changed-Why:  
Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134954 
Responsible-Changed-From-To: freebsd-ports-bugs->marck 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue May 26 11:10:18 UTC 2009 
Responsible-Changed-Why:  
Submitter is maintainer and has GNATS access (via the GNATS Auto Assign 
Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134954 
Responsible-Changed-From-To: marck->freebsd-ports-bug 
Responsible-Changed-By: marck 
Responsible-Changed-When: Wed May 27 14:04:41 UTC 2009 
Responsible-Changed-Why:  


This is my own PR, please commit. 

Recommended by:	edwin 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134954 
Responsible-Changed-From-To: freebsd-ports-bug->freebsd-ports-bugs 
Responsible-Changed-By: marck 
Responsible-Changed-When: Wed May 27 14:12:50 UTC 2009 
Responsible-Changed-Why:  
Fix a typo in responsible. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=134954 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Fri May 29 12:13:34 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134954 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134954: commit references a PR
Date: Fri, 29 May 2009 12:13:38 +0000 (UTC)

 miwi        2009-05-29 12:13:26 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/smartmontools Makefile 
     sysutils/smartmontools/files smart.in 
   Log:
   - Fix typo in smart periodic script.
   - Add simple autodetect mode (works only for regular disks).
   
   PR:             134954
   Submitted by:   maintainer
   
   Revision  Changes    Path
   1.39      +1 -1      ports/sysutils/smartmontools/Makefile
   1.4       +14 -7     ports/sysutils/smartmontools/files/smart.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
