From gslin@colo-p.gslin.org  Fri May 22 08:05:46 2009
Return-Path: <gslin@colo-p.gslin.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 99723106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 May 2009 08:05:46 +0000 (UTC)
	(envelope-from gslin@colo-p.gslin.org)
Received: from colo-p.gslin.org (60-199-248-145.static.tfn.net.tw [60.199.248.145])
	by mx1.freebsd.org (Postfix) with ESMTP id 6CBCD8FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 May 2009 08:05:45 +0000 (UTC)
	(envelope-from gslin@colo-p.gslin.org)
Received: by colo-p.gslin.org (Postfix, from userid 1000)
	id 382F97E81B; Fri, 22 May 2009 16:05:44 +0800 (CST)
Message-Id: <20090522080544.382F97E81B@colo-p.gslin.org>
Date: Fri, 22 May 2009 16:05:44 +0800 (CST)
From: Gea-Suan Lin <gslin@gslin.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: yuri@tsoft.com, gslin@gslin.org
Subject: [PATCH] devel/google-perftools: Fix portlint warning
X-Send-Pr-Version: 3.113
X-GNATS-Notify: yuri@tsoft.com

>Number:         134847
>Category:       ports
>Synopsis:       [PATCH] devel/google-perftools: Fix portlint warning
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    amdmi3
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 22 08:10:01 UTC 2009
>Closed-Date:    Sat May 30 14:50:57 UTC 2009
>Last-Modified:  Sat May 30 15:00:04 UTC 2009
>Originator:     Gea-Suan Lin
>Release:        FreeBSD 7.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD colo-p.gslin.org 7.1-STABLE FreeBSD 7.1-STABLE #0: Sat Jan 31 21:46:23 UTC 2009
>Description:
- Use MAN1 instead of pkg-plist.
- Use standard DOCSDIR instead of version-suffix directory.
- Use USE_LDCONFIG to ask ports system to reload.

Port maintainer (yuri@tsoft.com) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- google-perftools-1.0_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/devel/google-perftools/Makefile /home/staff/gslin/work/ports/google-perftools/Makefile
--- /usr/ports/devel/google-perftools/Makefile	2009-01-13 08:03:20.000000000 +0800
+++ /home/staff/gslin/work/ports/google-perftools/Makefile	2009-05-22 16:03:20.000000000 +0800
@@ -7,6 +7,7 @@
 
 PORTNAME=	google-perftools
 PORTVERSION=	1.0
+PORTREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	${MASTER_SITE_GOOGLE_CODE} \
 		${MASTER_SITE_LOCAL}
@@ -16,8 +17,9 @@
 COMMENT=	Fast, multi-threaded malloc() and nifty performance analysis tools
 
 GNU_CONFIGURE=	yes
+USE_LDCONFIG=	yes
 
-DOCSDIR=	${PREFIX}/share/doc/${PORTNAME}-${PORTVERSION}
+MAN1=		pprof.1
 
 post-patch:
 .if defined(NOPORTDOCS)
diff -ruN --exclude=CVS /usr/ports/devel/google-perftools/pkg-plist /home/staff/gslin/work/ports/google-perftools/pkg-plist
--- /usr/ports/devel/google-perftools/pkg-plist	2009-01-13 08:03:20.000000000 +0800
+++ /home/staff/gslin/work/ports/google-perftools/pkg-plist	2009-05-22 16:01:54.000000000 +0800
@@ -1,3 +1,4 @@
+@comment $FreeBSD$
 bin/pprof
 include/google/heap-checker.h
 include/google/heap-profiler.h
@@ -18,7 +19,6 @@
 lib/libtcmalloc_minimal.la
 lib/libtcmalloc_minimal.so
 lib/libtcmalloc_minimal.so.0
-man/man1/pprof.1
 %%PORTDOCS%%%%DOCSDIR%%/AUTHORS
 %%PORTDOCS%%%%DOCSDIR%%/COPYING
 %%PORTDOCS%%%%DOCSDIR%%/ChangeLog
--- google-perftools-1.0_1.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri May 22 08:10:11 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134847 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: yuri@tsoft.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/134847: [PATCH] devel/google-perftools: Fix portlint warning
Date: Fri, 22 May 2009 08:10:10 UT

 Maintainer of devel/google-perftools,
 
 Please note that PR ports/134847 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134847
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->amdmi3 
Responsible-Changed-By: amdmi3 
Responsible-Changed-When: Fri May 22 11:56:07 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134847 
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Tue May 26 11:16:14 UTC 2009 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134847 

From: Mark Linimon <linimon@lonesome.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134847: [PATCH] devel/google-perftools: Fix portlint
	warning
Date: Tue, 26 May 2009 06:17:22 -0500

 ----- Forwarded message from Yuri <yuri@rawbw.com> -----
 
 From: Yuri <yuri@rawbw.com>
 To: amdmi3@FreeBSD.org
 Cc: freebsd-ports-bugs@FreeBSD.org, yuri@tsoft.com
 Subject: Re: ports/134847: [PATCH] devel/google-perftools: Fix portlint
 	warning
 
 Sure, go ahead and check in the change.
 
 Yuri
 
 ----- End forwarded message -----
State-Changed-From-To: open->feedback 
State-Changed-By: amdmi3 
State-Changed-When: Tue May 26 14:36:17 UTC 2009 
State-Changed-Why:  
You can't just remove DOCSDIR, as it still installs docs into that 
place. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134847 
State-Changed-From-To: feedback->open 
State-Changed-By: amdmi3 
State-Changed-When: Thu May 28 02:02:57 UTC 2009 
State-Changed-Why:  
Updated patch received 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134847 
State-Changed-From-To: open->closed 
State-Changed-By: amdmi3 
State-Changed-When: Sat May 30 14:50:54 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134847 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134847: commit references a PR
Date: Sat, 30 May 2009 14:50:57 +0000 (UTC)

 amdmi3      2009-05-30 14:50:48 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/google-perftools Makefile pkg-plist 
   Added files:
     devel/google-perftools/files patch-Makefile.in 
   Log:
   - Use MAN1 instead of pkg-plist.
   - Use standard DOCSDIR instead of version-suffix directory.
   - Use USE_LDCONFIG to ask ports system to reload.
   
   PR:             134847
   Submitted by:   Gea-Suan Lin <gslin@gslin.org>
   Approved by:    Yuri <yuri@rawbw.com> (maintainer)
   
   Revision  Changes    Path
   1.9       +3 -2      ports/devel/google-perftools/Makefile
   1.1       +11 -0     ports/devel/google-perftools/files/patch-Makefile.in (new)
   1.4       +0 -1      ports/devel/google-perftools/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
