From abrown@freemail.gr  Fri May 22 04:22:01 2009
Return-Path: <abrown@freemail.gr>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7D5D5106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 May 2009 04:22:01 +0000 (UTC)
	(envelope-from abrown@freemail.gr)
Received: from rosebud.otenet.gr (rosebud.otenet.gr [83.235.67.32])
	by mx1.freebsd.org (Postfix) with ESMTP id 95F198FC20
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 May 2009 04:21:55 +0000 (UTC)
	(envelope-from abrown@freemail.gr)
Received: from bifteki.lan (ppp-94-66-35-194.home.otenet.gr [94.66.35.194])
	by rosebud.otenet.gr (8.13.8/8.13.8/Debian-3) with ESMTP id n4M41PcB019263
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 May 2009 07:01:25 +0300
Received: from bifteki.lan (localhost [127.0.0.1])
	by bifteki.lan (8.14.3/8.14.3) with ESMTP id n4M46s5F004900
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 22 May 2009 07:06:54 +0300 (EEST)
	(envelope-from abrown@bifteki.lan)
Received: (from abrown@localhost)
	by bifteki.lan (8.14.3/8.14.3/Submit) id n4M46sPF004899;
	Fri, 22 May 2009 07:06:54 +0300 (EEST)
	(envelope-from abrown)
Message-Id: <200905220406.n4M46sPF004899@bifteki.lan>
Date: Fri, 22 May 2009 07:06:54 +0300 (EEST)
From: Andrew Brown <abrown@freemail.gr>
Reply-To: Andrew Brown <abrown@freemail.gr>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: devel/cvs-devel changes base-system's cvs/cvsbug binaries without user verification/confirmation
X-Send-Pr-Version: 3.113
X-GNATS-Notify: bdheeman@gmail.com

>Number:         134799
>Category:       ports
>Synopsis:       devel/cvs-devel changes base-system's cvs/cvsbug binaries without user verification/confirmation
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 22 04:30:04 UTC 2009
>Closed-Date:    Tue Jun 02 00:00:27 UTC 2009
>Last-Modified:  Tue Jun 02 00:00:27 UTC 2009
>Originator:     Andrew Brown <abrown@freemail.gr>
>Release:        FreeBSD 7.1-STABLE i386
>Organization:
>Environment:
	System: FreeBSD bifteki.lan 7.1-STABLE FreeBSD 7.1-STABLE #0: Thu Jan 29 19:11:01 EET 2009 abrown@bifteki.lan:/usr/obj/usr/src/sys/GENERIC i386

	
>Description:
	When installing the port devel/cvs-devel, it changes the base-system /usr/bin/cvs and /usr/bin/cvsbug binaries with the ones installed under /usr/local/bin
>How-To-Repeat:
	cd /usr/ports/devel/cvs-devel
	make install
>Fix:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/cvs-devel/Makefile,v
retrieving revision 1.24
diff -U 2 -r1.24 Makefile
--- Makefile	 26 May 2008 04:58:42 -0000	1.24
+++ Makefile	 22 May 2009 03:51:14 -0000
@@ -38,10 +38,4 @@
   @${CP} ${FILESDIR}/missing ${WRKSRC}
 
-post-install:
-.for f in cvs cvsbug
-     -${MV} ${PREFIX:S/\/local//}/bin/${f} ${PREFIX:S/\/local//}/bin/${f}.orig
-     -${CP} -p ${PREFIX}/bin/${f} ${PREFIX:S/\/local//}/bin
-.endfor
-
 generate-patch:
	cvs -R -d ${CVS_SITE} rdiff -u -r ${CVS_VER} -r HEAD \



>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri May 22 04:30:19 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134799 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: bdheeman@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/134799: devel/cvs-devel changes base-system's cvs/cvsbug binaries without user verification/confirmation
Date: Fri, 22 May 2009 04:30:17 UT

 Maintainer of devel/cvs-devel,
 
 Please note that PR ports/134799 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134799
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Balwinder S Dheeman <bdheeman@gmail.com>
To: bug-followup@FreeBSD.org, abrown@freemail.gr
Cc:  
Subject: Re: ports/134799: devel/cvs-devel changes base-system's cvs/cvsbug 
	binaries without user verification/confirmation
Date: Sat, 23 May 2009 08:13:59 +0530

 The patch seems good, hence approved.
 
 It however, would have been better we now present the users of this
 port a reasonable post-install 'messgae' telling that the binaries
 related to this port have been installed at ${PREFIX}/bin and users
 manually need to override the similar version also available in the
 base.
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: wxs 
Responsible-Changed-When: Mon Jun 1 19:22:49 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134799 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134799: commit references a PR
Date: Mon,  1 Jun 2009 23:54:54 +0000 (UTC)

 wxs         2009-06-01 23:54:40 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/cvs-devel      Makefile pkg-plist 
   Log:
   - Don't overwrite binaries in /bin.
   
   PR:             ports/134799
   Submitted by:   Andrew Brown <abrown@freemail.gr>
   Approved by:    Balwinder S Dheeman <bdheeman@gmail.com> (maintainer)
   
   Revision  Changes    Path
   1.25      +1 -7      ports/devel/cvs-devel/Makefile
   1.6       +1 -5      ports/devel/cvs-devel/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: wxs 
State-Changed-When: Tue Jun 2 00:00:25 UTC 2009 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134799 
>Unformatted:
