From nobody@FreeBSD.org  Thu May 21 03:36:19 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 54AD8106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 21 May 2009 03:36:19 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 430978FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 21 May 2009 03:36:19 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n4L3aIjd016349
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 21 May 2009 03:36:18 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n4L3aIkp016348;
	Thu, 21 May 2009 03:36:18 GMT
	(envelope-from nobody)
Message-Id: <200905210336.n4L3aIkp016348@www.freebsd.org>
Date: Thu, 21 May 2009 03:36:18 GMT
From: Yun Huang Yong <gumby@mooh.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: lang/spidermonkey misses installation of some header files
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: citric@cubicone.tmetic.com

>Number:         134770
>Category:       ports
>Synopsis:       lang/spidermonkey misses installation of some header files
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 21 03:40:01 UTC 2009
>Closed-Date:    Tue Jun 23 19:47:28 UTC 2009
>Last-Modified:  Tue Jun 23 19:50:01 UTC 2009
>Originator:     Yun Huang Yong
>Release:        7.2
>Organization:
>Environment:
FreeBSD nom.mooh.org 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Fri May  1 07:18:07 UTC 2009     root@driscoll.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
The port Makefile defines $(JSH), a list of header files to be installed.  In building a 3rd party app I discovered my installed port is missing "jsdate.h".  Upon further investigation it seems that the port may be missing several other header files.
>How-To-Repeat:

>Fix:
Sorry, I am not familiar enough with SpiderMonkey to know the right solution here.

Adding jsdate.h to Makefile's $(JSH) solves my issue however Makefile.ref within the SpiderMonkey source defines almost 30 header files, and I wonder if they should all be installed.

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu May 21 03:40:13 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134770 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: citric@cubicone.tmetic.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/134770: lang/spidermonkey misses installation of some header files
Date: Thu, 21 May 2009 03:40:09 UT

 Maintainer of lang/spidermonkey,
 
 Please note that PR ports/134770 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134770
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Dan Rench <citric@cubicone.tmetic.com>
To: bug-followup@FreeBSD.org, gumby@mooh.org
Cc:  
Subject: Re: ports/134770: lang/spidermonkey misses installation of some header files
Date: Tue, 26 May 2009 14:34:35 -0500

 Thanks for catching this.
 
 The patch below adds jsdate.h along with the other missing .h files
 from Makefile.ref:
 
 diff --git a/Makefile b/Makefile
 index 93febaf..d063b3b 100644
 --- a/Makefile
 +++ b/Makefile
 @@ -32,9 +32,16 @@ ALL_TARGET=	${OPSYS}`${UNAME} -r`_DBG.OBJ/js
  MAKE_ENV+=	CCC="${CXX}"
  USE_LDCONFIG=	yes
  SRC_DIR=	js/src
 -JSH=		jsapi.h jsautocfg.h jsconfig.h jscompat.h jslong.h jsosdep.h \
 -		jsotypes.h jspubtd.h jstypes.h jsstr.h jshash.h jsprvtd.h \
 +
 +JSH=		jsapi.h jsarena.h jsarray.h jsatom.h jsautocfg.h jsbool.h \
 +		jsclist.h jscntxt.h jscompat.h jsconfig.h jsdate.h jsdhash.h \
 +		jsdtoa.h jsemit.h jsexn.h jsfun.h jsgc.h jshash.h jsinterp.h \
 +		jsiter.h jslibmath.h jslock.h jslong.h jsmath.h jsnum.h jsobj.h \
 +		jsopcode.h jsosdep.h jsotypes.h jsparse.h jsprvtd.h jspubtd.h \
 +		jsregexp.h jsscan.h jsscope.h jsscript.h jsstr.h jstypes.h \
 +		jsxdrapi.h jsxml.h \
  		jsproto.tbl
 +
  PLIST_FILES=	bin/js lib/libjs.so lib/libjs.so.1 ${JSH:S,^,include/,}
  WRKSRC=		${WRKDIR}/${SRC_DIR}
  EXTRACT_AFTER_ARGS=| ${TAR} -xf - \

From: Yun Huang Yong <gumby@mooh.org>
To: Dan Rench <citric@cubicone.tmetic.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/134770: lang/spidermonkey misses installation of
  some header files
Date: Sun, 31 May 2009 01:49:02 +1000

 --=====================_221680821==.ALT
 Content-Type: text/plain; charset="us-ascii"; format=flowed
 
 Sorry I missed your reply as it got caught in my spam filters.
 
 This works great.  Thanks for the speedy response. :)
 
 At 05:34 AM 27/05/2009, Dan Rench wrote:
 >Thanks for catching this.
 >
 >The patch below adds jsdate.h along with the other missing .h files
 >from Makefile.ref:
 >[snip]
 
 
 -- 
                                      (__)    Share what you know.
 Yun Huang Yong              `\------(oo)    Learn what you don't.
 gumby@mooh.org                ||    (__) --'
 goosmurf@yahoo.com      \|/   ||w--||        \|/
 --
 
 --=====================_221680821==.ALT
 Content-Type: text/html; charset="us-ascii"
 
 <html>
 <body>
 <font size=3>Sorry I missed your reply as it got caught in my spam
 filters.<br><br>
 This works great.&nbsp; Thanks for the speedy response. :)<br><br>
 At 05:34 AM 27/05/2009, Dan Rench wrote:<br>
 <blockquote type=cite class=cite cite="">Thanks for catching
 this.<br><br>
 The patch below adds jsdate.h along with the other missing .h files<br>
 from Makefile.ref:<br>
 [snip]</blockquote>
 <x-sigsep><p></x-sigsep>
 <br>
 -- <br>
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 (__)&nbsp;&nbsp;&nbsp; Share what you know.<br>
 Yun Huang
 Yong&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 `\------(oo)&nbsp;&nbsp;&nbsp; Learn what you don't.<br>
 gumby@mooh.org&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 ||&nbsp;&nbsp;&nbsp; (__) --'<br>
 goosmurf@yahoo.com&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \|/&nbsp;&nbsp;
 ||w--||&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; \|/<br>
 --<br>
 </font></body>
 </html>
 
 --=====================_221680821==.ALT--
 
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Tue Jun 23 18:41:49 UTC 2009 
Responsible-Changed-Why:  
approved 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134770 
State-Changed-From-To: feedback->open 
State-Changed-By: pgollucci 
State-Changed-When: Tue Jun 23 19:25:38 UTC 2009 
State-Changed-Why:  
Maintainer has approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134770 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Tue Jun 23 19:47:27 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134770 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134770: commit references a PR
Date: Tue, 23 Jun 2009 19:47:27 +0000 (UTC)

 pgollucci    2009-06-23 19:47:12 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/spidermonkey    Makefile 
   Log:
   - Fix pkg-plist (install all header files)
   
   PR:             ports/134770
   Submitted by:   Dan Rench <citric@cubicone.tmetic.com>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.25      +11 -7     ports/lang/spidermonkey/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
