From vangyzen@marvin.vangyzen.net  Fri May 15 02:17:31 2009
Return-Path: <vangyzen@marvin.vangyzen.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 027B2106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 May 2009 02:17:31 +0000 (UTC)
	(envelope-from vangyzen@marvin.vangyzen.net)
Received: from marvin.vangyzen.net (marvin.vangyzen.net [208.86.227.192])
	by mx1.freebsd.org (Postfix) with ESMTP id D11A88FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 May 2009 02:17:30 +0000 (UTC)
	(envelope-from vangyzen@marvin.vangyzen.net)
Received: from marvin.vangyzen.net (localhost [127.0.0.1])
	by marvin.vangyzen.net (Postfix) with ESMTP id A0BECB262F
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 14 May 2009 21:01:47 -0500 (CDT)
Received: (from vangyzen@localhost)
	by marvin.vangyzen.net (8.14.3/8.14.3/Submit) id n4F21lts081577;
	Thu, 14 May 2009 21:01:47 -0500 (CDT)
	(envelope-from vangyzen)
Message-Id: <200905150201.n4F21lts081577@marvin.vangyzen.net>
Date: Thu, 14 May 2009 21:01:47 -0500 (CDT)
From: Eric van Gyzen <eric@vangyzen.net>
Reply-To: Eric van Gyzen <eric@vangyzen.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] SpamAssassin loses mail when killed by a signal
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         134552
>Category:       ports
>Synopsis:       [patch] mail/p5-Mail-SpamAssassin loses mail when killed by a signal
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    gabor
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri May 15 02:20:02 UTC 2009
>Closed-Date:    Sat May 30 23:28:59 UTC 2009
>Last-Modified:  Sat May 30 23:30:09 UTC 2009
>Originator:     Eric van Gyzen
>Release:        FreeBSD 7.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD marvin.vangyzen.net 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan 1 14:37:25 UTC 2009 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386

>Description:

When SpamAssassin 3.2.5 is killed by a signal, it exits with a zero
exit status.  When used with procmail, this causes mail to be lost,
because procmail thinks spamassassin completed successfully, but
spamassassin did not write the filtered mail to stdout to be
reclaimed by procmail for further processing and delivery.

For details, see:

    https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6033

SpamAssassin 3.2.5 was built with 7.1-RELEASE and 7.2-RELEASE,
so this will potentially affect a large number of FreeBSD users.

I am running /usr/local/bin/spamassassin from procmailrc;
perhaps the issue would not happen if spamd/spamc were used.

>How-To-Repeat:

N/A

>Fix:

Put this patch in ports/mail/p5-Mail-SpamAssassin/files.
It is r759764 from the SpamAssassin SVN repository,
linked from Comment #8 in the bug referenced above.
Apparently, it will be included in 3.2.6.

--- patch-spamassassin.raw begins here ---
--- spamassassin.raw.orig	2009-05-14 20:48:01.000000000 -0500
+++ spamassassin.raw	2009-05-14 20:48:19.000000000 -0500
@@ -530,7 +530,7 @@
     $mail->finish();      # bug 5626: remove temp files etc.
     $mail = undef;
   }
-  exit 0;
+  exit 15;
 }
 
 # ---------------------------------------------------------------------------
--- patch-spamassassin.raw ends here ---


>Release-Note:
>Audit-Trail:

From: Michael Scheidell <scheidell@secnap.net>
To: bug-followup@FreeBSD.org, eric@vangyzen.net
Cc:  
Subject: Re: ports/134552: [patch] mail/p5-Mail-SpamAssassin loses mail when
 killed by a signal
Date: Tue, 26 May 2009 11:55:07 -0400

 This is a multi-part message in MIME format.
 --------------030007010704070705070906
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Looks reasonable.  I have a minor patch to SA later and will include 
 this patch.
 
 thanks.
 
 
 -- 
 Michael Scheidell, CTO
 Phone: 561-999-5000, x 1259
  > *| *SECNAP Network Security Corporation
 
     * Certified SNORT Integrator
     * 2008-9 Hot Company Award Winner, World Executive Alliance
     * Five-Star Partner Program 2009, VARBusiness
     * Best Anti-Spam Product 2008, Network Products Guide
     * King of Spam Filters, SC Magazine 2008
 
 
 _________________________________________________________________________
 This email has been scanned and certified safe by SpammerTrap(r). 
 For Information please see http://www.secnap.com/products/spammertrap/
 _________________________________________________________________________
 
 --------------030007010704070705070906--

From: Michael Scheidell <scheidell@secnap.net>
To: bug-followup@FreeBSD.org, eric@vangyzen.net
Cc:  
Subject: Re: ports/134552: [patch] mail/p5-Mail-SpamAssassin loses mail when
 killed by a signal
Date: Wed, 27 May 2009 13:42:21 -0400

 committers:
 please close PR 134552.
 
 it will be incorporated in pr 135001
 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=135001
 
 
 -- 
 Michael Scheidell, CTO
 Phone: 561-999-5000, x 1259
  > *| *SECNAP Network Security Corporation
 
     * Certified SNORT Integrator
     * 2008-9 Hot Company Award Winner, World Executive Alliance
     * Five-Star Partner Program 2009, VARBusiness
     * Best Anti-Spam Product 2008, Network Products Guide
     * King of Spam Filters, SC Magazine 2008
 
 _________________________________________________________________________
 This email has been scanned and certified safe by SpammerTrap(r). 
 For Information please see http://www.secnap.com/products/spammertrap/
 _________________________________________________________________________
State-Changed-From-To: open->closed 
State-Changed-By: gabor 
State-Changed-When: Sat May 30 23:28:31 UTC 2009 
State-Changed-Why:  
Superseded by ports/135001. 


Responsible-Changed-From-To: freebsd-ports-bugs->gabor 
Responsible-Changed-By: gabor 
Responsible-Changed-When: Sat May 30 23:28:31 UTC 2009 
Responsible-Changed-Why:  
Superseded by ports/135001. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134552 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134552: commit references a PR
Date: Sat, 30 May 2009 23:27:33 +0000 (UTC)

 gabor       2009-05-30 23:27:23 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/p5-Mail-SpamAssassin Makefile 
   Added files:
     mail/p5-Mail-SpamAssassin/files patch-spamassassin.raw 
   Log:
   - Fixing 3 issues:
   
           #1 There were problems with p5-Mail-DKIM 0.33, requiring >=0.34 [1]
   
           #2, running spamassassin via procmail could close without generating
               a error code [1] [2]
   
           #3, compiling spamc/spamd with NON base, ie PORTS openssl would fail.
               patch to makefile to include CFLAGS [1] [3]
   
   - Bump PORTREVISION
   
   PR:             ports/135001 [1], ports/134552 [2]
   Submitted by:   Michael Scheidell <scheidell@secnap.net> (maintainer) [1],
                   Eric van Gyzen <eric@vangyzen.net> [2],
                   olivier [3]
   
   Revision  Changes    Path
   1.125     +5 -3      ports/mail/p5-Mail-SpamAssassin/Makefile
   1.5       +12 -0     ports/mail/p5-Mail-SpamAssassin/files/patch-spamassassin.raw (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
