From Mark_Andrews@isc.org  Thu May 14 08:16:28 2009
Return-Path: <Mark_Andrews@isc.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 51BC11065679
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 14 May 2009 08:16:28 +0000 (UTC)
	(envelope-from Mark_Andrews@isc.org)
Received: from farside.isc.org (farside.isc.org [IPv6:2001:4f8:3:bb::5])
	by mx1.freebsd.org (Postfix) with ESMTP id 24FDA8FC21
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 14 May 2009 08:16:28 +0000 (UTC)
	(envelope-from Mark_Andrews@isc.org)
Received: from drugs.dv.isc.org (drugs.dv.isc.org [IPv6:2001:470:1f00:820:214:22ff:fed9:fbdc])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "drugs.dv.isc.org", Issuer "ISC CA" (not verified))
	by farside.isc.org (Postfix) with ESMTP id 771CDE6068
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 14 May 2009 08:16:27 +0000 (UTC)
	(envelope-from marka@isc.org)
Received: from drugs.dv.isc.org (localhost [127.0.0.1])
	by drugs.dv.isc.org (8.14.3/8.14.3) with ESMTP id n4E8GPVC044312
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 14 May 2009 18:16:25 +1000 (EST)
	(envelope-from marka@drugs.dv.isc.org)
Received: (from marka@localhost)
	by drugs.dv.isc.org (8.14.3/8.14.3/Submit) id n4E8GPLE044311;
	Thu, 14 May 2009 18:16:25 +1000 (EST)
	(envelope-from marka)
Message-Id: <200905140816.n4E8GPLE044311@drugs.dv.isc.org>
Date: Thu, 14 May 2009 18:16:25 +1000 (EST)
From: Mark Andrews <Mark_Andrews@isc.org>
Reply-To: Mark Andrews <Mark_Andrews@isc.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: misc/e2fsprogs-libuuid-1.41.5 infinite loop [patch]
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         134526
>Category:       ports
>Synopsis:       misc/e2fsprogs-libuuid-1.41.5 infinite loop [patch]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 14 08:20:02 UTC 2009
>Closed-Date:    Mon May 18 22:00:35 UTC 2009
>Last-Modified:  Mon May 18 22:00:35 UTC 2009
>Originator:     Mark Andrews
>Release:        FreeBSD 6.4-STABLE i386
>Organization:
ISC
>Environment:
System: FreeBSD drugs.dv.isc.org 6.4-STABLE FreeBSD 6.4-STABLE #31: Thu Apr 30 07:41:29 EST 2009 marka@drugs.dv.isc.org:/usr/obj/usr/src/sys/DRUGS i386

/usr/local/sbin/uuidd was installed by package e2fsprogs-libuuid-1.41.4_1

>Description:

	misc/e2fsprogs-libuuid-1.41.5 enters a infinite loop in
	"make check".  What is happening is that close_all_fds()
	does just that which results in uuidd from
	e2fsprogs-libuuid-1.41.4_1 exiting unexpectedly.  read_all()
	then fails to handle the resulting eof.

>How-To-Repeat:

	Attempt to build misc/e2fsprogs-libuuid-1.41.5.

>Fix:

--- gen_uuid.c.orig	2009-05-14 17:57:54.000000000 +1000
+++ gen_uuid.c	2009-05-14 17:54:06.000000000 +1000
@@ -423,6 +423,8 @@
 	memset(buf, 0, count);
 	while (count > 0) {
 		ret = read(fd, buf, count);
+		if (ret == 0)
+			return c;
 		if (ret < 0) {
 			perror("read");
 			if ((errno == EAGAIN) || (errno == EINTR))
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Thu May 14 09:36:54 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134526 

From: Mark Andrews <Mark_Andrews@isc.org>
To: FreeBSD-gnats-submit@freebsd.org, freebsd-ports-bugs@freebsd.org
Cc:  
Subject: Re: ports/134526: misc/e2fsprogs-libuuid-1.41.5 infinite loop [patch] 
Date: Thu, 14 May 2009 20:02:38 +1000

 	I just realised left a perror() call in that patch.  
 	Corrected patch.
 
 	Mark
 
 --- lib/uuid/gen_uuid.c.orig	2009-04-16 03:12:25.000000000 +1000
 +++ lib/uuid/gen_uuid.c	2009-05-14 19:55:07.000000000 +1000
 @@ -423,6 +423,8 @@
  	memset(buf, 0, count);
  	while (count > 0) {
  		ret = read(fd, buf, count);
 +		if (ret == 0)
 +			return c;
  		if (ret < 0) {
  			if ((errno == EAGAIN) || (errno == EINTR))
  				continue;
 -- 
 Mark Andrews, ISC
 1 Seymour St., Dundas Valley, NSW 2117, Australia
 PHONE: +61 2 9871 4742                 INTERNET: Mark_Andrews@isc.org

From: "Matthias Andree" <matthias.andree@gmx.de>
To: bug-followup@freebsd.org, Mark_Andrews@isc.org
Cc:  
Subject: Re: ports/134526: misc/e2fsprogs-libuuid-1.41.5 infinite loop [patch]
Date: Mon, 18 May 2009 19:58:59 +0200

 Please close this PR.
 
 An superset of this change was part of ports/134156 which has recently  
 been committed.
 
 -- 
 Matthias Andree
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Mon May 18 22:00:34 UTC 2009 
State-Changed-Why:  
close by maintainer request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134526 
>Unformatted:
