From nobody@FreeBSD.org  Mon May 11 21:08:44 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B0E77106571D
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 May 2009 21:08:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 9F6628FC1F
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 May 2009 21:08:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n4BL8i1c038423
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 11 May 2009 21:08:44 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n4BL8i78038416;
	Mon, 11 May 2009 21:08:44 GMT
	(envelope-from nobody)
Message-Id: <200905112108.n4BL8i78038416@www.freebsd.org>
Date: Mon, 11 May 2009 21:08:44 GMT
From: Pavel Gorshkov <gorshkov.pavel@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: deskutils/wmpinboard segfaults on startup
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: t.kempka@web.de

>Number:         134474
>Category:       ports
>Synopsis:       deskutils/wmpinboard segfaults on startup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 11 21:10:03 UTC 2009
>Closed-Date:    Fri Jul 24 17:03:14 UTC 2009
>Last-Modified:  Fri Jul 24 17:10:04 UTC 2009
>Originator:     Pavel Gorshkov
>Release:        7.2/amd64
>Organization:
>Environment:
FreeBSD lifebook 7.2-STABLE FreeBSD 7.2-STABLE #2: Tue May  5 20:20:45 MSD 2009     root@lifebook:/usr/obj/usr/src/sys/LIFEBOOK  amd64
>Description:
deskutils/wmpinboard segfaults on startup regardless of what the locale settings are.
The actual segfault occurs in libX11-1.2.1/src/xlibi18n/ICWrap.c, at line 117:

This GDB was configured as "amd64-marcel-freebsd"...
(gdb) run
Starting program: /tmp/wmpinboard-1.0.fromports/src/wmpinboard

Program received signal SIGSEGV, Segmentation fault.
0x0000000800694e2a in _XIMCountVaList (var=0x7fffffffe060,
    total_count=0x7fffffffe08c) at ICWrap.c:117
117             if (!strcmp(attr, XNVaNestedList)) {
(gdb) bt
#0  0x0000000800694e2a in _XIMCountVaList (var=0x7fffffffe060,
    total_count=0x7fffffffe08c) at ICWrap.c:117
#1  0x0000000800695307 in XCreateIC (im=0x80114e020) at ICWrap.c:243
#2  0x000000000040f4de in init_xlocale () at xmisc.c:260
#3  0x000000000040e4bb in main (argc=1, argv=0x7fffffffe920)
    at wmpinboard.c:2118
(gdb) display attr
1: attr = 0x800000000 <Error reading address 0x800000000: Bad address>

>How-To-Repeat:
Just build and run it.
>Fix:


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon May 11 21:10:17 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134474 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: t.kempka@web.de
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/134474: deskutils/wmpinboard segfaults on startup
Date: Mon, 11 May 2009 21:10:16 UT

 Maintainer of deskutils/wmpinboard,
 
 Please note that PR ports/134474 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134474
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Thomas Kempka <t.kempka@web.de>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134474: deskutils/wmpinboard segfaults on startup
Date: Sat, 16 May 2009 10:17:02 +0200

 Edwin Groothuis schrieb:
 > Maintainer of deskutils/wmpinboard,
 > 
 > Please note that PR ports/134474 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134474
 > 
 
 Approved!
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Sun May 17 00:31:21 UTC 2009 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134474 

From: Pavel Gorshkov <gorshkov.pavel@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134474: deskutils/wmpinboard segfaults on startup
Date: Wed, 27 May 2009 17:12:04 +0400

 --NzB8fVQJ5HfG6fxh
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Fixed.  XCreateIC() was getting 4 zero bytes + 4 extra bytes of
 garbage instead of the NULL pointer needed to terminate the va_list.
 
 --NzB8fVQJ5HfG6fxh
 Content-Type: text/x-diff; charset=us-ascii
 Content-Disposition: attachment; filename="wmpinboard-missing-sentinel.diff"
 
 --- src/xmisc.c.orig	2009-05-27 17:03:25.000000000 +0400
 +++ src/xmisc.c	2009-05-27 16:42:40.000000000 +0400
 @@ -204,7 +204,7 @@
      return;
    }
  
 -  if (XGetIMValues(xim, XNQueryInputStyle, &xim_styles, 0) || !xim_styles) {
 +  if (XGetIMValues(xim, XNQueryInputStyle, &xim_styles, NULL) || !xim_styles) {
      XCloseIM(xim);
  #ifdef DEBUG_IC
      fprintf(stderr, "Input method doesn't support any style.\n");
 @@ -258,7 +258,7 @@
    }
  
    InputContext = XCreateIC(xim, XNInputStyle, input_style,
 -    XNClientWindow, win, XNFocusWindow, win, 0);
 +    XNClientWindow, win, XNFocusWindow, win, NULL);
  
    if (!InputContext) {
      XCloseIM(xim);
 
 --NzB8fVQJ5HfG6fxh--
State-Changed-From-To: open->closed 
State-Changed-By: arved 
State-Changed-When: Fri Jul 24 17:03:09 UTC 2009 
State-Changed-Why:  
committed, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134474 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134474: commit references a PR
Date: Fri, 24 Jul 2009 17:03:12 +0000 (UTC)

 arved       2009-07-24 17:02:57 UTC
 
   FreeBSD ports repository
 
   Modified files:
     deskutils/wmpinboard Makefile 
   Added files:
     deskutils/wmpinboard/files patch-xmisc.c 
   Log:
   Fix execution on 64bit platforms
   
   PR:             134474
   Submitted by:   Pavel Gorshkov
   
   Revision  Changes    Path
   1.24      +1 -1      ports/deskutils/wmpinboard/Makefile
   1.1       +22 -0     ports/deskutils/wmpinboard/files/patch-xmisc.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
