From pgollucci@FreeBSD.org  Mon May 11 06:56:36 2009
Return-Path: <pgollucci@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 10B451065670;
	Mon, 11 May 2009 06:56:36 +0000 (UTC)
	(envelope-from pgollucci@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id F3DEB8FC0A;
	Mon, 11 May 2009 06:56:35 +0000 (UTC)
	(envelope-from pgollucci@FreeBSD.org)
Received: from freefall.freebsd.org (pgollucci@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n4B6uZRQ010348;
	Mon, 11 May 2009 06:56:35 GMT
	(envelope-from pgollucci@freefall.freebsd.org)
Received: (from pgollucci@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n4B6uZLH010347;
	Mon, 11 May 2009 06:56:35 GMT
	(envelope-from pgollucci)
Message-Id: <200905110656.n4B6uZLH010347@freefall.freebsd.org>
Date: Mon, 11 May 2009 06:56:35 GMT
From: "Philip M. Gollucci" <pgollucci@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: DougB@freebsd.org
Subject: [PATCH] textproc/htdig: apache@ cleanups
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         134446
>Category:       ports
>Synopsis:       [PATCH] textproc/htdig: apache@ cleanups
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 11 07:00:11 UTC 2009
>Closed-Date:    Fri May 29 04:07:21 UTC 2009
>Last-Modified:  Fri May 29 04:10:08 UTC 2009
>Originator:     Philip M. Gollucci
>Release:        FreeBSD 7.1-PRERELEASE i386
>Organization:
Riderway Inc.
>Environment:
System: FreeBSD freefall.freebsd.org 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #36: Mon Dec 29 15:15:30 UTC 2008
>Description:
- Use SF macro 
- USE_APACHE=yes is deprecated
- Remove apache from RUN_DEPENDS
- Style nit

Port maintainer (DougB@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- htdig-3.2.0.b6_2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/textproc/htdig/Makefile,v
retrieving revision 1.38
diff -u -u -r1.38 Makefile
--- Makefile	24 Mar 2009 19:51:27 -0000	1.38
+++ Makefile	11 May 2009 06:55:47 -0000
@@ -9,11 +9,7 @@
 PORTVERSION=	3.2.0.b6
 PORTREVISION=	2
 CATEGORIES=	textproc www
-MASTER_SITES=	http://htdig.sourceforge.net/files/ \
-		http://www.htdig.org/files/ \
-		ftp://netmirror.org/ftp.htdig.org/ \
-		ftp://gnu.kookel.org/pub/htdig/ftp.htdig.org/files/ \
-		ftp://ftp.ntua.gr/pub/www/htdig/ \
+MASTER_SITES=	SF \
 		http://dougbarton.us/Downloads/
 DISTNAME=	htdig-3.2.0b6
 
@@ -43,9 +39,8 @@
 .include <bsd.port.pre.mk>
 
 .if !defined(WITHOUT_APACHE)
-USE_APACHE=	yes
+USE_APACHE=	1.3+
 CONFIGURE_ARGS+=	--with-apache=${LOCALBASE}/sbin
-RUN_DEPENDS=	${LOCALBASE}/sbin/httpd:${PORTSDIR}/${APACHE_PORT}
 .endif
 
 post-patch:
@@ -64,7 +59,7 @@
 .if !defined(NOPORTDOCS)
 	@${MKDIR} ${DOCSDIR}/html
 .for f in ChangeLog ChangeLog.0 README STATUS
-	@${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}
+	@${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}/
 .endfor
 .for f in *.html *.gif
 	@${INSTALL_DATA} ${WRKSRC}/htdoc/${f} ${DOCSDIR}/html
--- htdig-3.2.0.b6_2.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dougb 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon May 11 07:00:25 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134446 
State-Changed-From-To: open->feedback 
State-Changed-By: dougb 
State-Changed-When: Mon May 25 23:41:20 UTC 2009 
State-Changed-Why:  

You haven't given any explanation regarding the benefits of 
your proposed changes. Please elaborate. 


Thanks, 

Doug 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134446 
State-Changed-From-To: feedback->open 
State-Changed-By: pgollucci 
State-Changed-When: Mon May 25 23:47:48 UTC 2009 
State-Changed-Why:  
feed back received, or will be modulo grey listing 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134446 
Responsible-Changed-From-To: dougb->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Thu May 28 21:09:54 UTC 2009 
Responsible-Changed-Why:  
Philip M. Gollucci wrote:
> > - Use SF macro
> > You get the full list of mirrors for Source Forge, its also checked
> > for
> > in portlint.
> > 
> > - USE_APACHE=yes is deprecated
> > - Remove apache from RUN_DEPENDS
> > 
> > That seems like justification to me.  See recent CHANGES, UPDATING,
> > and
> > portlint additions.  This will be droppped in bsd.apache.mk in the
> > next
> > run (< 2 months).
> > 
> > In prep of APACHE_PORT=www/apache22 by default,
> > USE_WEBSER=something,
> > and USE_MP=X (mod_perl).  portmgr, and clement@ are in agreement.
> > 
> > - Style nit
> > ${DOCSDIR} vs ${DOCSDIR}/ is actually in the style guide.

Ok, sounds good. You can replace all the master sites (including mine)
with the SF macro.


Thanks for taking an interest,

Doug
http://www.freebsd.org/cgi/query-pr.cgi?pr=134446 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Fri May 29 04:07:20 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134446 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134446: commit references a PR
Date: Fri, 29 May 2009 04:07:13 +0000 (UTC)

 pgollucci    2009-05-29 04:07:02 UTC
 
   FreeBSD ports repository
 
   Modified files:
     textproc/htdig       Makefile 
   Log:
   - Use SF macro
   - USE_APACHE=yes is deprecated
   - Remove apache from RUN_DEPENDS
   - Style nit
   
   PR:             ports/134446
   Approved by:    maintainer
   Submitted by:   me
   
   Revision  Changes    Path
   1.39      +3 -9      ports/textproc/htdig/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
