From root@undeliverable.renatasystems.org  Tue Apr 28 11:35:58 2009
Return-Path: <root@undeliverable.renatasystems.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9E46D106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 28 Apr 2009 11:35:58 +0000 (UTC)
	(envelope-from root@undeliverable.renatasystems.org)
Received: from hs-9.renatasystems.org (hs-9.renatasystems.org [83.222.5.149])
	by mx1.freebsd.org (Postfix) with SMTP id CB1BF8FC25
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 28 Apr 2009 11:35:57 +0000 (UTC)
	(envelope-from root@undeliverable.renatasystems.org)
Received: (qmail 74682 invoked by uid 0); 28 Apr 2009 15:35:55 +0400
Message-Id: <20090428113555.74681.qmail@hs-9.renatasystems.org>
Date: 28 Apr 2009 15:35:55 +0400
From: Alexey V.Degtyarev <alexey@renatasystems.org>
Reply-To: Alexey V.Degtyarev <alexey@renatasystems.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] security/expiretable incorrect pkg-plist macroses / stop daemon on deinstall
X-Send-Pr-Version: 3.113
X-GNATS-Notify: cris@gufi.org

>Number:         134062
>Category:       ports
>Synopsis:       [PATCH] security/expiretable incorrect pkg-plist macroses / stop daemon on deinstall
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 28 11:40:03 UTC 2009
>Closed-Date:    Tue May 12 13:39:55 UTC 2009
>Last-Modified:  Tue May 12 13:40:01 UTC 2009
>Originator:     Alexey V. Degtyarev
>Release:        FreeBSD 7.1-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD renatasystems.org 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan 1 08:58:24 UTC 2009 root@driscoll.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64


	
>Description:
	1. pkg-plist has an invalid @unexec command to stop the expiretable
	daemon: macroses RC_DIR, RC_SUFX are not defined in Makefile, so this
	causes errors at the deinstall routine:
	%RC_DIR%/etc/rc.d/expiretable%RC_SUFX%: not found

	2. A @stopdaemon feature has a more simple syntax.
>How-To-Repeat:
	Just install and deinstall port/package.
>Fix:

	

--- expiretable.patch begins here ---
diff -u -r expiretable.orig/pkg-plist expiretable/pkg-plist
--- expiretable.orig/pkg-plist	2006-12-28 01:46:05.000000000 +0300
+++ expiretable/pkg-plist	2009-04-28 14:31:22.000000000 +0400
@@ -1,2 +1,2 @@
+@stopdaemon expiretable
 sbin/expiretable
-@unexec %%RC_DIR%%/etc/rc.d/expiretable%%RC_SUFX%% stop 2>&1 >/dev/null || true
--- expiretable.patch ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Apr 28 11:40:13 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134062 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: cris@gufi.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/134062: [PATCH] security/expiretable incorrect pkg-plist macroses / stop daemon on deinstall
Date: Tue, 28 Apr 2009 11:40:11 UT

 Maintainer of security/expiretable,
 
 Please note that PR ports/134062 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134062
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Cristiano Deana <cris@gufi.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134062: [PATCH] security/expiretable incorrect pkg-plist
 macroses / stop daemon on deinstall
Date: Tue, 28 Apr 2009 14:43:57 +0200

 On 4/28/09 1:40 PM, Edwin Groothuis wrote:
 > Maintainer of security/expiretable,
 >
 > Please note that PR ports/134062 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134062
 >
 
 
 -- 
 Cristiano Deana - FreeCRIS
 "Ho iniziato a usare FreeBSD perche' m$ usava me. ed e' spiacevole"

From: "Alexey V. Degtyarev" <alexey@renatasystems.org>
To: cris@gufi.org
Cc: bug-followup@FreeBSD.org, alexey@renatasystems.org
Subject: Re: ports/134062: [PATCH] security/expiretable incorrect pkg-plist
	macroses / stop daemon on deinstall
Date: Tue, 12 May 2009 15:10:03 +0400

 > Synopsis: [PATCH] security/expiretable incorrect pkg-plist macroses / stop daemon on deinstall
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: edwin
 > State-Changed-When: Tue Apr 28 11:40:13 UTC 2009
 > State-Changed-Why: 
 > Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=134062
 
 Hi Cristiano,
 
 can you please be more specific in your reply? Commiters are confused
 either you agreed with problem report or not.
 
 Thank you,
 -- 
 Alexey V. Degtyarev

From: Cristiano Deana <cris@gufi.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134062: [PATCH] security/expiretable incorrect pkg-plist
 macroses / stop daemon on deinstall
Date: Tue, 12 May 2009 14:21:37 +0200

 On 4/28/09 1:40 PM, Edwin Groothuis wrote:
 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134062
 
 I agree
 
 -- 
 Cristiano Deana - FreeCRIS
 "Ho iniziato a usare FreeBSD perche' m$ usava me. ed e' spiacevole"
State-Changed-From-To: feedback->closed 
State-Changed-By: skv 
State-Changed-When: Tue May 12 13:39:44 UTC 2009 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=134062 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/134062: commit references a PR
Date: Tue, 12 May 2009 13:39:47 +0000 (UTC)

 skv         2009-05-12 13:39:32 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security/expiretable pkg-plist 
   Log:
   Use "@stopdaemon" in pkg-plist.
   
   PR:             ports/134062
   Submitted by:   Alexey V.Degtyarev <alexey xx renatasystems.org>
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.3       +1 -1      ports/security/expiretable/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
