From nobody@FreeBSD.org  Thu Apr 23 13:40:08 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9FC511065674
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 23 Apr 2009 13:40:08 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 8D7EB8FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 23 Apr 2009 13:40:08 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n3NDe8xU084845
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 23 Apr 2009 13:40:08 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n3NDe7Tr084843;
	Thu, 23 Apr 2009 13:40:07 GMT
	(envelope-from nobody)
Message-Id: <200904231340.n3NDe7Tr084843@www.freebsd.org>
Date: Thu, 23 Apr 2009 13:40:07 GMT
From: Justin Hibbits <jrh29@alumni.cwru.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: vim options don't work as expected.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         133949
>Category:       ports
>Synopsis:       editors/vim options don't work as expected.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    obrien
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 23 13:50:01 UTC 2009
>Closed-Date:    Mon May 04 06:19:07 UTC 2009
>Last-Modified:  Wed May  6 06:10:01 UTC 2009
>Originator:     Justin Hibbits
>Release:        8-CURRENT
>Organization:
>Environment:
FreeBSD narn.knownspace 8.0-CURRENT FreeBSD 8.0-CURRENT #16 r191380M: Wed Apr 22 16:53:04 EDT 2009     root@narn.knownspace:/usr/obj/usr/src/sys/NARN  powerpc

>Description:
Two parts:

The Vim port breaks ports convention with OPTIONS by requiring WITH_OPTIONS and/or WITH_VIM_OPTIONS, which breaks users' expectations of ports.

Also, even when WITH_OPTIONS/WITH_VIM_OPTIONS are enabled configured options don't work at all.
>How-To-Repeat:
attempt to build the vim port without setting WITH_OPTIONS/WITH_VIM_OPTIONS, and again with.
>Fix:
Apply attached patch.

Patch attached with submission follows:

--- Makefile.orig	2009-02-03 14:44:08.000000000 -0500
+++ Makefile	2009-02-03 15:16:49.000000000 -0500
@@ -32,9 +32,7 @@
 
 SLAVEDIRS=	editors/vim-lite
 
-.if defined(WITH_OPTIONS) || defined(WITH_VIM_OPTIONS)
 .include "${.CURDIR}/../vim/options"
-.endif
 
 CONFLICTS=	vim6* vim*-lite
 USE_BZIP2=	yes
@@ -57,6 +55,10 @@
 .endif
 MANLANG=	"" ru.KOI8-R ru.UTF-8 pl.ISO8859-2 pl.UTF-8 pl fr.ISO8859-1 \
 		fr.UTF-8 fr it.ISO8859-1 it.UTF-8 it
+WANT_PERL=	yes
+WANT_GNOME=	yes
+
+.include <bsd.port.pre.mk>
 
 .if defined(PACKAGE_BUILDING) && !defined(LITE)
 WITH_TCL=	yes
@@ -82,16 +84,6 @@
 USE_TCL_NO_THREADS=	yes
 .endif
 
-.if defined(WITH_PERL)
-WANT_PERL=	yes
-.endif
-
-.if !defined(WITHOUT_X11)
-WANT_GNOME=	yes
-.endif
-
-.include <bsd.port.pre.mk>
-
 .if !defined(LITE)
 MAKE_ARGS+=	CONF_OPT_FEAT="--with-features=big"
 I18N=		CONF_OPT_MULTIBYTE="--enable-multibyte --enable-fontset --enable-xim"
@@ -122,7 +114,7 @@
 #	for now default the GUI to the GTK+ one
 #	will be reviewed when the GTK+ 1.{3,4} behemoth is released
 .if !defined(WITH_ATHENA) && !defined(WITH_MOTIF) && !defined(WITH_GNOME) && !defined(WITH_GTK2)
-WITH_GNOME=	gtk12
+USE_GNOME=	gtk12
 .endif
 
 .if defined(WITH_ATHENA)


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->obrien 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Apr 23 16:03:03 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133949 
State-Changed-From-To: open->feedback 
State-Changed-By: obrien 
State-Changed-When: Thu Apr 23 22:29:19 UTC 2009 
State-Changed-Why:  
I will NOT be removing the 
".if defined(WITH_OPTIONS) || defined(WITH_VIM_OPTIONS)" 
I will remove the whole OPTIONS processing first.  I have been very clear 
about this over the past years.  So please don't include that in any patch. 

Also it looks like you are breaking "LITE" with moving WANT_PERL and 
WANT_GNOME out from under it and always setting them to "yes".  Do you 
agree this is the case? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133949 

From: Justin Hibbits <justin.hibbits@alumni.cwru.edu>
To: bug-followup@FreeBSD.org, jrh29@alumni.cwru.edu
Cc:  
Subject: Re: ports/133949: editors/vim options don't work as expected.
Date: Thu, 23 Apr 2009 19:17:07 -0400

 1)  Your WITH_OPTIONS/WITH_VIM_OPTIONS breaks POLA for ports -- users
 expect that if a port has OPTIONS, it should follow the full
 convention for OPTIONS. There is already a way to ignore
 the OPTIONS framework, the BATCH variable.  Also, after extensive
 Google searches I have yet to come up with any clear explanation for
 this, other than "I hate OPTIONS".
 
 2)  Although I did not test the vim-lite port sing WANT_PERL and
 WANT_GNOME should not break it, because they're conditional
 inclusions. Perl and GNOME need setup with bsd.port.pre.mk, whether or
 not they will actually be used.  Defining WITH_PERL and WITH_GNOME
 later on will make them actually be used.
State-Changed-From-To: feedback->closed 
State-Changed-By: obrien 
State-Changed-When: Mon May 4 06:17:43 UTC 2009 
State-Changed-Why:  
Port not tested for vim-lite port and patch contains items unsuitable for 
committing. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133949 

From: Justin Hibbits <chmeeedalf@gmail.com>
To: bug-followup@FreeBSD.org, jrh29@alumni.cwru.edu
Cc:  
Subject: Re: ports/133949: editors/vim options don't work as expected.
Date: Mon, 4 May 2009 12:51:36 -0400

 On 5/4/09, obrien@freebsd.org <obrien@freebsd.org> wrote:
 > Synopsis: editors/vim options don't work as expected.
 >
 > State-Changed-From-To: feedback->closed
 > State-Changed-By: obrien
 > State-Changed-When: Mon May 4 06:17:43 UTC 2009
 > State-Changed-Why:
 > Port not tested for vim-lite port and patch contains items unsuitable for
 > committing.
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=133949
 >
 
 I was waiting for a friend to test and comment, to have third-party
 approval that my patch works with vim-lite.  I just tested myself, and
 it works as expected.
 
 There are absolutely _no_ items in the patch unsuitable for committing
 from a technical nature.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/133949: commit references a PR
Date: Wed,  6 May 2009 06:01:29 +0000 (UTC)

 obrien      2009-05-06 06:01:19 UTC
 
   FreeBSD ports repository
 
   Modified files:
     editors/vim          Makefile 
   Log:
   I had a WITH_GNOME where I should have had a USE_GNOME.
   
   PR:             133949
   Submitted by:   Justin Hibbits <jrh29@alumni.cwru.edu>
   
   Revision  Changes    Path
   1.342     +2 -2      ports/editors/vim/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
