From nobody@FreeBSD.org  Thu Apr 16 20:12:48 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C2FD310657C6
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 16 Apr 2009 20:12:48 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id B16B38FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 16 Apr 2009 20:12:48 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n3GKClP1039876
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 16 Apr 2009 20:12:47 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n3GKCl51039875;
	Thu, 16 Apr 2009 20:12:47 GMT
	(envelope-from nobody)
Message-Id: <200904162012.n3GKCl51039875@www.freebsd.org>
Date: Thu, 16 Apr 2009 20:12:47 GMT
From: John Baldwin <jhb@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] mail/postfix fails to install as non-root
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: vivek@khera.org

>Number:         133790
>Category:       ports
>Synopsis:       [PATCH] mail/postfix fails to install as non-root
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jhb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 16 20:20:01 UTC 2009
>Closed-Date:    Tue May 12 11:41:27 UTC 2009
>Last-Modified:  Tue May 12 11:50:01 UTC 2009
>Originator:     John Baldwin
>Release:        
>Organization:
>Environment:
>Description:
During a 'make install' as non-root, certain make targets are performed after using su to switch to root.  Currently, the postfix port attempts to add users before the 'su' occurs which fails.
>How-To-Repeat:
Run 'make install' as a non-root user (who is in wheel).
>Fix:
Use 'pre-su-install' instead of 'pre-install'.

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /usr/cvs/ports/mail/postfix/Makefile,v
retrieving revision 1.142
diff -u -r1.142 Makefile
--- Makefile	26 Jan 2009 19:52:05 -0000	1.142
+++ Makefile	21 Mar 2009 16:59:27 -0000
@@ -253,7 +253,7 @@
 	CCARGS="${POSTFIX_CCARGS}" AUXLIBS="${POSTFIX_AUXLIBS}" && \
 	${ECHO} "all: default" >> Makefile)
 
-pre-install:
+pre-su-install:
 	@${SETENV} ${SCRIPTS_ENV} PKG_PREFIX="${PREFIX}" ${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
 
 do-install:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jhb 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Apr 16 21:06:40 UTC 2009 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133790 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Apr 16 21:06:44 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133790 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: vivek@khera.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/133790: [PATCH] mail/postfix fails to install as non-root
Date: Thu, 16 Apr 2009 21:06:42 UT

 Maintainer of mail/postfix,
 
 Please note that PR ports/133790 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/133790
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Vick Khera <vivek@khera.org>
To: bug-followup@FreeBSD.org,
 jhb@FreeBSD.org
Cc:  
Subject: Re: ports/133790: [PATCH] mail/postfix fails to install as non-root
Date: Thu, 16 Apr 2009 17:41:53 -0400

 I agree with this patch. Please apply it.
 
 Thanks!
 
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Tue May 12 11:40:44 UTC 2009 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133790 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/133790: commit references a PR
Date: Tue, 12 May 2009 11:41:32 +0000 (UTC)

 pav         2009-05-12 11:41:17 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/postfix         Makefile 
   Log:
   - Fix non-root installation (use pre-su-install target)
   
   PR:             ports/133790
   Submitted by:   jhb
   Approved by:    Vick Khera <vivek@khera.org> (maintainer)
   
   Revision  Changes    Path
   1.143     +1 -1      ports/mail/postfix/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
