From nobody@FreeBSD.org  Thu Apr 16 17:09:32 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4B75D106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 16 Apr 2009 17:09:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 1FBC98FC1A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 16 Apr 2009 17:09:32 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n3GH9Vi0083578
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 16 Apr 2009 17:09:31 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n3GH9VqY083553;
	Thu, 16 Apr 2009 17:09:31 GMT
	(envelope-from nobody)
Message-Id: <200904161709.n3GH9VqY083553@www.freebsd.org>
Date: Thu, 16 Apr 2009 17:09:31 GMT
From: John Baldwin <jhb@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] mail/milter-greylist: add OPTIONS and WITH_POSTFIX
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         133783
>Category:       ports
>Synopsis:       [PATCH] mail/milter-greylist: add OPTIONS and WITH_POSTFIX
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ache
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 16 17:10:01 UTC 2009
>Closed-Date:    Wed Apr 22 10:33:25 UTC 2009
>Last-Modified:  Wed Apr 22 10:40:00 UTC 2009
>Originator:     John Baldwin
>Release:        
>Organization:
>Environment:
>Description:
This patch adds a new WITH option to the mail/milter-greylist port to support the '--enable-postfix' configure option for Postfix support.

It adds an OPTIONS line to convert the port over to using the OPTIONS framework.  This includes making NO_INSTALL_MANPAGES now be handled by an on-by-default WITH_MANPAGES option.
>How-To-Repeat:

>Fix:
Patch is attached and available at http://www.FreeBSD.org/~jhb/patches/greylist.patch.

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /usr/cvs/ports/mail/milter-greylist/Makefile,v
retrieving revision 1.30
diff -u -r1.30 Makefile
--- Makefile	23 Jan 2009 15:42:54 -0000	1.30
+++ Makefile	16 Apr 2009 16:02:44 -0000
@@ -19,6 +19,14 @@
 CONFLICTS=	milter-greylist-devel-[1-9]*.*
 PKGMESSAGE=	${WRKDIR}/pkg-message
 
+OPTIONS=	MANPAGES "Install manpages" YES \
+		LIBSPF2 "Include SPF support" NO \
+		GEOIP "Include GeoIP support" NO \
+		CURL "Include curl support" NO \
+		POSTFIX "Use Postfix instead of Sendmail" NO
+
+.include <bsd.port.pre.mk>
+
 ##
 # Use the following quirks to choose which sendmail to use (ports or system):
 #
@@ -30,7 +38,7 @@
 # installed port preference over it.
 ##
 
-.if !defined (NO_INSTALL_MANPAGES)
+.if defined (WITH_MANPAGES)
 MAN5=		greylist.conf.5
 MAN8=		milter-greylist.8
 .endif
@@ -50,6 +58,9 @@
 BUILD_DEPENDS+=	curl>=7.18:${PORTSDIR}/ftp/curl
 CONFIGURE_ARGS+=	--with-curl=${LOCALBASE}
 .endif
+.if defined(WITH_POSTFIX)
+CONFIGURE_ARGS+=	--enable-postfix
+.endif
 RUN_DEPENDS+=	${BUILD_DEPENDS}
 
 CFLAGS+=	${PTHREAD_CFLAGS}
@@ -67,8 +78,10 @@
 
 do-install:
 	@${MKDIR} ${PREFIX}/etc/mail
+.if defined (WITH_MANPAGES)
 	@${INSTALL_MAN} ${WRKSRC}/greylist.conf.5 ${PREFIX}/man/man5
 	@${INSTALL_MAN} ${WRKSRC}/milter-greylist.8 ${PREFIX}/man/man8
+.endif
 	@${INSTALL_PROGRAM} ${WRKSRC}/milter-greylist ${PREFIX}/libexec
 	@${INSTALL_DATA} ${WRKSRC}/greylist.conf \
 			${PREFIX}/etc/mail/greylist.conf.sample
@@ -100,8 +113,6 @@
 	) || ${TRUE}
 	@${CAT} ${PKGMESSAGE}
 
-.include <bsd.port.pre.mk>
-
 .include "${PORTSDIR}/mail/sendmail/bsd.milter.mk"
 
 .include <bsd.port.post.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ache 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Apr 16 17:45:21 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133783 
State-Changed-From-To: open->closed 
State-Changed-By: ache 
State-Changed-When: Wed Apr 22 10:33:03 UTC 2009 
State-Changed-Why:  
Committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133783 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/133783: commit references a PR
Date: Wed, 22 Apr 2009 10:32:11 +0000 (UTC)

 ache        2009-04-22 10:32:02 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/milter-greylist Makefile 
   Log:
   Use OPTIONS
   add --with-postfix there
   
   PR:             133783
   Submitted by:   John Baldwin <jhb@FreeBSD.org>
   
   Revision  Changes    Path
   1.33      +14 -3     ports/mail/milter-greylist/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
