From john@roof1.dnepro.net  Wed Apr 15 09:36:44 2009
Return-Path: <john@roof1.dnepro.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8A48C106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Apr 2009 09:36:44 +0000 (UTC)
	(envelope-from john@roof1.dnepro.net)
Received: from roof1.dnepro.net (b17.dnepro.net [195.24.131.17])
	by mx1.freebsd.org (Postfix) with ESMTP id 090C48FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 15 Apr 2009 09:36:43 +0000 (UTC)
	(envelope-from john@roof1.dnepro.net)
Received: from roof1.dnepro.net (localhost [127.0.0.1])
	by roof1.dnepro.net (8.14.3/8.14.3) with ESMTP id n3EFKfaW022175
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 14 Apr 2009 18:20:41 +0300 (EEST)
	(envelope-from john@roof1.dnepro.net)
Received: (from john@localhost)
	by roof1.dnepro.net (8.14.3/8.14.3/Submit) id n3EFKfO1022174;
	Tue, 14 Apr 2009 18:20:41 +0300 (EEST)
	(envelope-from john)
Message-Id: <200904141520.n3EFKfO1022174@roof1.dnepro.net>
Date: Tue, 14 Apr 2009 18:20:41 +0300 (EEST)
From: Eugene Perevyazko <john@dnepro.net>
Reply-To: Eugene Perevyazko <john@dnepro.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] port net/freeradius does not build sql driver for unixODBC
X-Send-Pr-Version: 3.113
X-GNATS-Notify: david@wood2.org.uk

>Number:         133746
>Category:       ports
>Synopsis:       [patch] port net/freeradius does not build sql driver for unixODBC
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 15 09:40:02 UTC 2009
>Closed-Date:    Tue May 12 11:31:23 UTC 2009
>Last-Modified:  Thu Jul 02 20:14:53 UTC 2009
>Originator:     Eugene Perevyazko
>Release:        FreeBSD 7.2-PRERELEASE i386
>Organization:
Dnepronet
>Environment:
System: FreeBSD traktor 7.2-PRERELEASE FreeBSD 7.2-PRERELEASE #1: Mon Apr 13 16:20:06 EEST 2009     john@:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
	Freeradius includes sql driver for unixODBC which is unconditionally
disabled in port's Makefile. Proposed patch adds option to build this driver
with dependency on databases/unixODBC port.	
>How-To-Repeat:
	Try to use freeradius with driver = "rlm_sql_unixodbc" in sql module
configuration in radiusd.conf.
>Fix:
	Use following patch, rebuild and reinstall port.

--- Makefile.bak	2009-04-14 17:28:50.000000000 +0300
+++ Makefile	2009-04-14 17:57:42.000000000 +0300
@@ -51,10 +51,11 @@
 		LDAP		"With LDAP database support" off
 .ifndef(FREERADIUS_SLAVE_MYSQL)
 OPTIONS+=	MYSQL		"With MySQL database support" off
 .endif
 OPTIONS+=	PGSQL		"With PostgreSQL database support" off \
+		UNIXODBC	"With unixODBC database support" off \
 		FIREBIRD	"With Firebird database support (EXPERIMENTAL)" off \
 		SNMP		"With SNMP support" off \
 		EDIR		"With Novell eDirectory support" off \
 		NOPERL		"Do not require perl (use only if necessary)" off \
 		EXPERIMENTAL	"Build experimental modules" off
@@ -89,12 +90,11 @@
 .endif
 CONFIGURE_ARGS+=--without-rlm_sql_db2 \
 		--without-rlm_sql_freetds \
 		--without-rlm_sql_iodbc \
 		--without-rlm_sql_oracle \
-		--without-rlm_sql_sybase \
-		--without-rlm_sql_unixodbc
+		--without-rlm_sql_sybase
 
 .if ${ARCH} == amd64
 CONFIGURE_ARGS+=	--with-pic
 .endif
 
@@ -152,10 +152,19 @@
 .else
 CONFIGURE_ARGS+=--without-rlm_sql_postgresql
 PLIST_SUB+=	PGSQL="@comment "
 .endif
 
+.ifdef(WITH_UNIXODBC)
+CONFIGURE_ARGS+=--with-rlm_sql_unixodbc
+PLIST_SUB+=	UNIXODBC=""
+LIB_DEPENDS+=	odbc.1:${PORTSDIR}/databases/unixODBC
+.else
+CONFIGURE_ARGS+=--without-rlm_sql_unixodbc
+PLIST_SUB+=	UNIXODBC="@comment "
+.endif
+
 .ifdef(WITH_FIREBIRD)
 USE_FIREBIRD=	YES
 CONFIGURE_ARGS+=--with-rlm_sql_firebird
 PLIST_SUB+=	FIREBIRD=""
 .else


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Apr 15 09:56:12 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133746 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: david@wood2.org.uk
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/133746: [patch] port net/freeradius does not build sql driver for unixODBC
Date: Wed, 15 Apr 2009 09:56:10 UT

 Maintainer of net/freeradius,
 
 Please note that PR ports/133746 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/133746
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Tue May 12 11:30:53 UTC 2009 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133746 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/133746: commit references a PR
Date: Tue, 12 May 2009 11:31:24 +0000 (UTC)

 pav         2009-05-12 11:31:12 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/freeradius       Makefile pkg-plist 
   Log:
   - Add an option for unixODBC
   
   PR:             ports/133746
   Submitted by:   Eugene Perevyazko <john@dnepro.net>
   Approved by:    maintainer timeout (27 days)
   
   Revision  Changes    Path
   1.67      +11 -2     ports/net/freeradius/Makefile
   1.33      +4 -0      ports/net/freeradius/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: David Wood <david@wood2.org.uk>
To: bug-followup@FreeBSD.org, john@dnepro.net
Cc:  
Subject: Re: ports/133746: [patch] port net/freeradius does not build sql driver for unixODBC
Date: Tue, 12 May 2009 22:06:25 +0100

 Hi there,
 
 My apologies for letting this go to maintainer timeout. Unfortunately my 
 development machine was temporarily unavailable - it was racked up again 
 yesterday.
 
 I realise this has been committed now to net/freeradius. I will 
 incorporate this change in the next update of net/freeradius2 - 2.1.6 is 
 due shortly. FreeRADIUS 2 is now the recommended version for all 
 deployments - FreeRADIUS 1.x is end of life.
 
 
 Best wishes,
 
 
 
 
 David
 -- 
 David Wood
 david@wood2.org.uk

From: David Wood <david@wood2.org.uk>
To: bug-followup@FreeBSD.org, john@dnepro.net
Cc:  
Subject: Re: ports/133746: [patch] port net/freeradius does not build sql driver for unixODBC
Date: Thu, 2 Jul 2009 20:07:31 +0100

 ports/136254 incorporates this change into net/freeradius2.
 
 
 With best wishes,
 
 
 
 
 David
 -- 
 David Wood
 david@wood2.org.uk
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: wxs 
Responsible-Changed-When: Thu Jul 2 20:14:52 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133746 
>Unformatted:
