From nobody@FreeBSD.org  Thu Apr  2 05:59:52 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 52D75106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  2 Apr 2009 05:59:52 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 409E98FC19
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  2 Apr 2009 05:59:52 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n325xqS3047205
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 2 Apr 2009 05:59:52 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n325xqbe047204;
	Thu, 2 Apr 2009 05:59:52 GMT
	(envelope-from nobody)
Message-Id: <200904020559.n325xqbe047204@www.freebsd.org>
Date: Thu, 2 Apr 2009 05:59:52 GMT
From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] sysutils/fusefs-sshfs add KMODDIR var
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: amistry@am-productions.biz

>Number:         133295
>Category:       ports
>Synopsis:       [patch] sysutils/fusefs-sshfs add KMODDIR var
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 02 06:00:05 UTC 2009
>Closed-Date:    Tue Apr 21 17:06:42 UTC 2009
>Last-Modified:  Tue Apr 21 17:10:03 UTC 2009
>Originator:     Alex Kozlov
>Release:        
>Organization:
private
>Environment:
>Description:
Add KMODDIR var to sysutils/fusefs-sshfs. (Catch with sysutils/fusefs-kmod 1.24)
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: sysutils/fusefs-sshfs/Makefile
@@ -15,8 +15,10 @@
 MAINTAINER=	amistry@am-productions.biz
 COMMENT=	Mount remote directories over ssh
 
+KMODDIR?=	${PREFIX}/modules
+
 LIB_DEPENDS=	fuse.2:${PORTSDIR}/sysutils/fusefs-libs
-RUN_DEPENDS=	${LOCALBASE}/modules/fuse.ko:${PORTSDIR}/sysutils/fusefs-kmod
+RUN_DEPENDS=	${KMODDIR}/fuse.ko:${PORTSDIR}/sysutils/fusefs-kmod
 BUILD_DEPENDS=	fusefs-libs>2.4.1:${PORTSDIR}/sysutils/fusefs-libs
 
 GNU_CONFIGURE=	yes


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Apr 2 06:00:17 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133295 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: amistry@am-productions.biz
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/133295: [patch] sysutils/fusefs-sshfs add KMODDIR var
Date: Thu, 2 Apr 2009 06:00:14 UT

 Maintainer of sysutils/fusefs-sshfs,
 
 Please note that PR ports/133295 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/133295
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: wxs 
Responsible-Changed-When: Thu Apr 2 13:46:34 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133295 

From: Wesley Shields <wxs@FreeBSD.org>
To: bug-followup@FreeBSD.org, spam@rm-rf.kiev.ua
Cc:  
Subject: Re: ports/133295: [patch] sysutils/fusefs-sshfs add KMODDIR var
Date: Tue, 21 Apr 2009 12:19:30 -0400

 --17pEHd4RhPHOinZp
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 The patch proposed in this PR is wrong.  We shouldn't be looking in
 ${PREFIX} for a dependency.  We should be looking in ${LOCALBASE}.
 
 How does this patch look?
 
 -- WXS
 
 --17pEHd4RhPHOinZp
 Content-Type: text/x-diff; charset=us-ascii
 Content-Disposition: attachment; filename="fusefs-sshfs.diff"
 
 Index: Makefile
 ===================================================================
 RCS file: /ncvs/ports/sysutils/fusefs-sshfs/Makefile,v
 retrieving revision 1.12
 diff -u -r1.12 Makefile
 --- Makefile	22 Jan 2009 03:16:41 -0000	1.12
 +++ Makefile	21 Apr 2009 16:21:10 -0000
 @@ -15,8 +15,10 @@
  MAINTAINER=	amistry@am-productions.biz
  COMMENT=	Mount remote directories over ssh
  
 +KMODDIR?=	${LOCALBASE}/modules
 +
  LIB_DEPENDS=	fuse.2:${PORTSDIR}/sysutils/fusefs-libs
 -RUN_DEPENDS=	${LOCALBASE}/modules/fuse.ko:${PORTSDIR}/sysutils/fusefs-kmod
 +RUN_DEPENDS=	${KMODDIR}/fuse.ko:${PORTSDIR}/sysutils/fusefs-kmod
  BUILD_DEPENDS=	fusefs-libs>2.4.1:${PORTSDIR}/sysutils/fusefs-libs
  
  GNU_CONFIGURE=	yes
 
 --17pEHd4RhPHOinZp--

From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: bug-followup@FreeBSD.org, Wesley Shields <wxs@FreeBSD.org>,
	spam@rm-rf.kiev.ua
Cc:  
Subject: Re: ports/133295: [patch] sysutils/fusefs-sshfs add KMODDIR var
Date: Tue, 21 Apr 2009 19:38:35 +0300

 On Tue, Apr 21, 2009 at 12:19:30PM -0400, Wesley Shields wrote:
 > The patch proposed in this PR is wrong.  We shouldn't be looking in
 > ${PREFIX} for a dependency.  We should be looking in ${LOCALBASE}.
 Yes, You're right.
  
 > How does this patch look?
 Please commit it.
 
 
 --
 Adios
State-Changed-From-To: feedback->closed 
State-Changed-By: wxs 
State-Changed-When: Tue Apr 21 17:06:41 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133295 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/133295: commit references a PR
Date: Tue, 21 Apr 2009 17:06:41 +0000 (UTC)

 wxs         2009-04-21 17:06:28 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/fusefs-sshfs Makefile 
   Log:
   - Look in ${KMODDIR} for dependency.
   - Default KMODDIR to ${LOCALBASE}/modules.
   
   PR:             ports/133295
   Submitted by:   Alex Kozlov <spam@rm-rf.kiev.ua>
   Approved by:    maintainer timeout
   
   Revision  Changes    Path
   1.13      +3 -1      ports/sysutils/fusefs-sshfs/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
