From nobody@FreeBSD.org  Wed Apr  1 16:53:31 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C57B5106567A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  1 Apr 2009 16:53:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A9F228FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  1 Apr 2009 16:53:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n31GrVDb038615
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 1 Apr 2009 16:53:31 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n31GrVBk038606;
	Wed, 1 Apr 2009 16:53:31 GMT
	(envelope-from nobody)
Message-Id: <200904011653.n31GrVBk038606@www.freebsd.org>
Date: Wed, 1 Apr 2009 16:53:31 GMT
From: bf <bf2006a@yahoo.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH]multimedia/clive: add support for youtube high-definition videos
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: legatvs@gmail.com

>Number:         133278
>Category:       ports
>Synopsis:       [PATCH]multimedia/clive: add support for youtube high-definition videos
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Apr 01 17:00:05 UTC 2009
>Closed-Date:    Sat Apr 04 18:18:06 UTC 2009
>Last-Modified:  Sat Apr 04 18:18:06 UTC 2009
>Originator:     bf
>Release:        8-CURRENT i386
>Organization:
-
>Environment:
>Description:
Allow requests for high-definition mp4s from youtube (which can be substantially
larger than the normal mp4s, so not everyone may want them...).  Also, several
minor Makefile tweaks:

-There isn't really a build, and perl isn't needed for it;
-Even if we're going to use a non-standard manpage knob, we should respect
the well-established NO_INSTALL_MANPAGES;
-Fix version check for p5-IO-Pager.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN clive.orig/Makefile clive/Makefile
--- clive.orig/Makefile	2009-03-27 18:41:33.000000000 -0400
+++ clive/Makefile	2009-04-01 12:24:45.341338429 -0400
@@ -29,9 +29,10 @@
 
 PLIST_FILES=	bin/clive
 
+NO_BUILD=	yes
 USE_BZIP2=	yes
 USE_GMAKE=	yes
-USE_PERL5=	5.8.2+
+USE_PERL5_RUN=	5.8.2+
 MAKE_JOBS_SAFE=	yes
 
 .include <bsd.port.pre.mk>
@@ -41,14 +42,14 @@
 .endif
 
 .if defined(WITH_PAGER)
-RUN_DEPENDS+=	p5-IO-Pager-0.06:${PORTSDIR}/devel/p5-IO-Pager
+RUN_DEPENDS+=	p5-IO-Pager>=0.06:${PORTSDIR}/devel/p5-IO-Pager
 .endif
 
 .if defined(WITH_EXPECT)
 RUN_DEPENDS+=	p5-Expect>=1.21:${PORTSDIR}/lang/p5-Expect
 .endif
 
-.if defined(WITH_MANPAGE)
+.if defined(WITH_MANPAGE) && !defined(NO_INSTALL_MANPAGES)
 MAKE_ENV=	WITH_MAN=yes
 MAN1=		clive.1
 .endif
diff -ruN clive.orig/files/patch-clive clive/files/patch-clive
--- clive.orig/files/patch-clive	1969-12-31 19:00:00.000000000 -0500
+++ clive/files/patch-clive	2009-04-01 12:24:45.340344169 -0400
@@ -0,0 +1,10 @@
+--- clive.orig	2009-04-01 14:49:10.000000000 +0000
++++ clive	2009-04-01 14:52:36.000000000 +0000
+@@ -768,6 +768,7 @@
+ 
+         my $fmt;
+         if    ($opts{format} eq "mp4")  { $fmt = 18; }
++        elsif ($opts{format} eq "mp4_hd")   { $fmt = 22; }
+         elsif ($opts{format} eq "3gpp") { $fmt = 17; }
+         elsif ($opts{format} eq "xflv") { $fmt = 6; }
+ 
diff -ruN clive.orig/files/patch-clive.1 clive/files/patch-clive.1
--- clive.orig/files/patch-clive.1	1969-12-31 19:00:00.000000000 -0500
+++ clive/files/patch-clive.1	2009-04-01 12:24:45.341338429 -0400
@@ -0,0 +1,19 @@
+--- clive.1.orig	2009-04-01 12:08:20.890212658 -0400
++++ clive.1	2009-04-01 12:18:30.263443613 -0400
+@@ -466,11 +466,13 @@
+ .IP "\fBwww.last.fm\fR" 4
+ .IX Item "www.last.fm"
+ .PD
+-Formats: (flv|mp4|3gpp|xflv)  Continue: Yes (except flv)
++Formats: (flv|mp4|mp4_hd|3gpp|xflv)  Continue: Yes (except flv)
+ .Sp
+-mp4 and 3gpp formats are typically, or will become later, available.
++mp4 and 3gpp formats are typically, or will soon become, available.
+ xflv appears to be very rare. Videos dating back to 2006 may only be
+-available as flv.
++available as flv. The high-definition mp4_hd format is currently available
++for a limited number of videos, which are usually explicitly marked as "HD"
++or "720p".
+ .Sp
+ Some of the videos displayed on last.fm site are actually Youtube videos.
+ You can pass the lastfm'ed video URLs to \fBclive\fR.


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Apr 1 17:00:17 UTC 2009 
Responsible-Changed-Why:  
miwi@ wants his PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133278 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Apr 1 17:00:21 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133278 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: legatvs@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/133278: [PATCH]multimedia/clive: add support for youtube high-definition videos
Date: Wed, 1 Apr 2009 17:00:19 UT

 Maintainer of multimedia/clive,
 
 Please note that PR ports/133278 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/133278
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Toni Gundogdu <legatvs@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/133278: [PATCH]multimedia/clive: add support for youtube 
	high-definition videos
Date: Wed, 1 Apr 2009 23:33:07 +0300

 On Wed, Apr 1, 2009 at 8:00 PM, Edwin Groothuis <edwin@freebsd.org> wrote:
 > Maintainer of multimedia/clive,
 >
 > Please note that PR ports/133278 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 > =A0 =A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/133278
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
 
 Looks good to me. Thanks bf. These changes should also include:
 
 --- /usr/ports/multimedia/clive/Makefile    2009-03-28 00:41:33.000000000 +=
 0200
 +++ clive/Makefile  2009-04-01 23:03:06.000000000 +0300
 @@ -7,6 +7,7 @@
 
  PORTNAME=3D  clive
  PORTVERSION=3D   2.1.9
 +PORTREVISION=3D  1
  CATEGORIES=3D    multimedia
  MASTER_SITES=3D  GOOGLE_CODE
 
 As bf pointed out in another PR.

From: Toni Gundogdu <legatvs@gmail.com>
To: bug-followup@FreeBSD.org, bf2006a@yahoo.com
Cc:  
Subject: Re: ports/133278: [PATCH]multimedia/clive: add support for youtube 
	high-definition videos
Date: Sat, 4 Apr 2009 21:07:18 +0300

 You can close this one. I submitted PR:
   http://www.freebsd.org/cgi/query-pr.cgi?pr=133379
 
 Which includes the above changes. Thanks.
State-Changed-From-To: feedback->closed 
State-Changed-By: miwi 
State-Changed-When: Sat Apr 4 18:18:06 UTC 2009 
State-Changed-Why:  
close by maintainer request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133278 
>Unformatted:
