From swell.k@gmail.com  Sun Mar 29 06:33:50 2009
Return-Path: <swell.k@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BEC3A106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 29 Mar 2009 06:33:50 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.155])
	by mx1.freebsd.org (Postfix) with ESMTP id 4F7C08FC17
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 29 Mar 2009 06:33:49 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: by fg-out-1718.google.com with SMTP id 13so470848fge.12
        for <FreeBSD-gnats-submit@freebsd.org>; Sat, 28 Mar 2009 23:33:49 -0700 (PDT)
Received: by 10.86.82.16 with SMTP id f16mr3336832fgb.32.1238308429267;
        Sat, 28 Mar 2009 23:33:49 -0700 (PDT)
Received: from localhost (95-24-174-59.broadband.corbina.ru [95.24.174.59])
        by mx.google.com with ESMTPS id 12sm2238578fgg.22.2009.03.28.23.33.47
        (version=TLSv1/SSLv3 cipher=RC4-MD5);
        Sat, 28 Mar 2009 23:33:48 -0700 (PDT)
Message-Id: <86ljqoj0s6.fsf@gmail.com>
Date: Sun, 29 Mar 2009 10:33:45 +0400
From: Anonymous <swell.k@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] x11/pixman: enable SSE2 support autodetection
X-Send-Pr-Version: 3.113

>Number:         133175
>Category:       ports
>Synopsis:       [patch] x11/pixman: enable SSE2 support autodetection
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-x11
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 29 06:40:00 UTC 2009
>Closed-Date:    Sat Sep 19 20:25:46 UTC 2009
>Last-Modified:  Sat Sep 19 20:30:06 UTC 2009
>Originator:     Anonymous
>Release:        FreeBSD 8.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD luffy 8.0-CURRENT FreeBSD 8.0-CURRENT #1 r190482:190483M: Sat Mar 28 05:26:15 UTC 2009     root@luffy:/usr/obj/usr/src/sys/PHOENIX  amd64

I don't have box without SSE2 extension to test on.
>Description:
As a result of ports/116551 SSE support was unconditionally disabled in
pixman-0.9.5. There is no way to enable it other than changing Makefile.

Since that PR pixman library grew support of autodetecting MMX and SSE2
separately.
>How-To-Repeat:
>Fix:
Unless autodetection goes wrong for someone remove that workaround.

--- pixman-remove-workaround.diff begins here ---
Index: x11/pixman/Makefile
===================================================================
RCS file: /home/csup/ports/x11/pixman/Makefile,v
retrieving revision 1.9
diff -u -p -r1.9 Makefile
--- x11/pixman/Makefile	13 Feb 2009 06:39:40 -0000	1.9
+++ x11/pixman/Makefile	29 Mar 2009 06:11:18 -0000
@@ -19,6 +19,6 @@ USE_GNOME=	ltverhack:9
 
 post-patch:
 	@${REINPLACE_CMD} -e 's|gtk+-2\.0|disable-gtk|g' \
-		-e 's|-msse||' ${WRKSRC}/configure
+		${WRKSRC}/configure
 
 .include <bsd.port.mk>
--- pixman-remove-workaround.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-x11 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Mar 29 06:40:13 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133175 

From: bf <bf2006a@yahoo.com>
To: bug-followup@FreeBSD.org
Cc: Anonymous <swell.k@gmail.com>
Subject: Re: ports/133175: [patch] x11/pixman: enable SSE2 support autodetection
Date: Sun, 29 Mar 2009 01:23:07 -0700 (PDT)

 Have you thought about the consequences for those architectures,
 like i386, that include machines with _and_ without these
 features?
 
 Right now, we don't distinguish between binary packages with
 and without SIMD in Ports, so many ports have such switches
 disabled, because binary packages built on one machine should
 be usable on another with the same architecture and OS version.
 
 Changes of this kind could break binary packages built,
 for example, by the FreeBSD package-building cluster, when used
 on older machines.  You may be able to enable _some_ SIMD
 support on architectures for which _every_ machine
 supports the SIMD instructions in question, but _only_
 on those architectures.  Otherwise you need to make bigger
 changes to the Ports infrastructure.  And in fact, some of
 these checks should be updated to disable SSE2, SSE3, etc.
 by default.
 
 Regards,
            b.
 
 
       

From: Anonymous <swell.k@gmail.com>
To: bf <bf2006a@yahoo.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/133175: [patch] x11/pixman: enable SSE2 support autodetection
Date: Sun, 29 Mar 2009 13:28:50 +0400

 bf <bf2006a@yahoo.com> writes:
 
 > Changes of this kind could break binary packages built,
 > for example, by the FreeBSD package-building cluster, when used
 > on older machines.
 
 Oops, forgot about packages. How about this patch
 
 --- pixman-add-simd-option.diff begins here ---
 Index: x11/pixman/Makefile
 ===================================================================
 RCS file: /home/csup/ports/x11/pixman/Makefile,v
 retrieving revision 1.9
 diff -u -p -r1.9 Makefile
 --- x11/pixman/Makefile	13 Feb 2009 06:39:40 -0000	1.9
 +++ x11/pixman/Makefile	29 Mar 2009 09:08:38 -0000
 @@ -17,8 +17,21 @@ USE_AUTOTOOLS=	libtool:15
  USE_PERL5_BUILD=yes
  USE_GNOME=	ltverhack:9
  
 +OPTIONS=	SIMD "Enable autodection of SIMD features (MMX, SSE2, VMX)" off
 +
 +.include <bsd.port.pre.mk>
 +
 +.if defined(WITHOUT_SIMD)
 +CONFIGURE_ARGS=	--disable-vmx --disable-arm-simd
 +
 +.if ${ARCH:Namd64}
 +CONFIGURE_ARGS+=	--disable-mmx --disable-sse2
 +.endif
 +
 +.endif
 +
  post-patch:
  	@${REINPLACE_CMD} -e 's|gtk+-2\.0|disable-gtk|g' \
 -		-e 's|-msse||' ${WRKSRC}/configure
 +		${WRKSRC}/configure
  
 -.include <bsd.port.mk>
 +.include <bsd.port.post.mk>
 --- pixman-add-simd-option.diff ends here ---
State-Changed-From-To: open->closed 
State-Changed-By: rnoland 
State-Changed-When: Sat Sep 19 20:25:45 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133175 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/133175: commit references a PR
Date: Sat, 19 Sep 2009 20:25:09 +0000 (UTC)

 rnoland     2009-09-19 20:25:01 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11/pixman           Makefile distinfo 
   Log:
   Update to 0.16.0
   
   - Incorporate patch from PR #133175, which adds optional mmx/sse2 detection
   
   Feature safe:   yes
   PR:             133175
   Submitted by:   Anonymous <swell.k@gmail.com>
   
   Revision  Changes    Path
   1.13      +16 -3     ports/x11/pixman/Makefile
   1.9       +3 -3      ports/x11/pixman/distinfo
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
