From nobody@FreeBSD.org  Thu Mar 26 15:24:00 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E9A28106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 26 Mar 2009 15:24:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id D6C608FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 26 Mar 2009 15:24:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n2QFO03g086940
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 26 Mar 2009 15:24:00 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n2QFO0Vf086930;
	Thu, 26 Mar 2009 15:24:00 GMT
	(envelope-from nobody)
Message-Id: <200903261524.n2QFO0Vf086930@www.freebsd.org>
Date: Thu, 26 Mar 2009 15:24:00 GMT
From: Scot Hetzel <swhetzel@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: misc/kdeedu3: Fails to build on -Current - 'USB_SET_TIMEOUT' undeclared 
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         133092
>Category:       ports
>Synopsis:       misc/kdeedu3: Fails to build on -Current - 'USB_SET_TIMEOUT' undeclared
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kde
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 26 15:30:04 UTC 2009
>Closed-Date:    Thu Apr 16 09:11:03 UTC 2009
>Last-Modified:  Thu Apr 16 10:00:10 UTC 2009
>Originator:     Scot Hetzel
>Release:        8.0-CURRENT
>Organization:
>Environment:
FreeBSD hp010.hetzel.org 8.0-CURRENT FreeBSD 8.0-CURRENT #6: Tue Mar 24 05:47:19 CDT 2009     root@hp010.hetzel.org:/usr/obj/usr/src/sys/DV8135NR  amd64
>Description:
Since the switch to the new usb stack misc/kdeedu3 fails to build due to undefined USB_SET_TIMEOUT.
>How-To-Repeat:
cd /usr/ports/misc/kdeedu3
make build

/bin/sh /usr/local/bin/libtool --silent --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I../../../.. -I/usr/local/include  -I/usr/local/include  -D_THREAD_SAFE -pthread -DQT_THREAD_SUPPORT   -I/usr/local/include -I/usr/local/include  -I/usr/local/include -D_GETOPT_H -D_THREAD_SAFE  -I/usr/local/include  -DNDEBUG -O2  -O2 -pipe -fno-strict-aliasing -MT libfli-usb-sys-bsd.lo -MD -MP -MF .deps/libfli-usb-sys-bsd.Tpo -c -o libfli-usb-sys-bsd.lo libfli-usb-sys-bsd.c
libfli-usb-sys-bsd.c: In function 'unix_usbverifydescriptor':
libfli-usb-sys-bsd.c:69: warning: comparison between pointer and integer
libfli-usb-sys-bsd.c:78: warning: comparison between pointer and integer
libfli-usb-sys-bsd.c:89: warning: assignment makes integer from pointer without a cast
libfli-usb-sys-bsd.c: In function 'bsd_bulkwrite':
libfli-usb-sys-bsd.c:104: error: 'USB_SET_TIMEOUT' undeclared (first use in this function)
libfli-usb-sys-bsd.c:104: error: (Each undeclared identifier is reported only once
libfli-usb-sys-bsd.c:104: error: for each function it appears in.)
libfli-usb-sys-bsd.c: In function 'bsd_bulkread':
libfli-usb-sys-bsd.c:124: error: 'USB_SET_TIMEOUT' undeclared (first use in this function)
gmake[5]: *** [libfli-usb-sys-bsd.lo] Error 1
gmake[5]: Leaving directory `/usr/ports/misc/kdeedu3/work/kdeedu-3.5.10/kstars/kstars/indi/fli'
gmake[4]: *** [all-recursive] Error 1
gmake[4]: Leaving directory `/usr/ports/misc/kdeedu3/work/kdeedu-3.5.10/kstars/kstars/indi'
gmake[3]: *** [all-recursive] Error 1
gmake[3]: Leaving directory `/usr/ports/misc/kdeedu3/work/kdeedu-3.5.10/kstars/kstars'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/misc/kdeedu3/work/kdeedu-3.5.10/kstars'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/misc/kdeedu3/work/kdeedu-3.5.10'
gmake: *** [all] Error 2
*** Error code 2
>Fix:
The attached patch adds an include for legacy/dev/usb/usb.h to kstars/kstars/indi/fli/libfli-usb-sys-bsd.c.

Patch attached with submission follows:

--- kstars/kstars/indi/fli/libfli-usb-sys-bsd.c.orig	2005-09-10 03:17:35.000000000 -0500
+++ kstars/kstars/indi/fli/libfli-usb-sys-bsd.c	2009-03-26 09:44:39.470081183 -0500
@@ -41,8 +41,13 @@
 
 */
 
+#include <sys/param.h>
 #include <sys/types.h>
+#if __FreeBSD_version > 800068
+#include <legacy/dev/usb/usb.h>
+#else
 #include <dev/usb/usb.h>
+#endif
 #include <sys/ioctl.h>
 
 #include <unistd.h>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kde 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Mar 26 15:30:19 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133092 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Thu Apr 16 09:11:02 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133092 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/133092: commit references a PR
Date: Thu, 16 Apr 2009 09:52:34 +0000 (UTC)

 miwi        2009-04-16 09:01:28 UTC
 
   FreeBSD ports repository
 
   Added files:
     misc/kdeedu3/files   
                          patch-kstars-indi-fli_libfli-usb-sys-bsd.c 
   Log:
   - Fix build with new usb2
   
   PR:             133092
   Submitted by:   Scot Hetzel <swhetzel@gmail.com>
   Approved by:    portmgr (joe)
   
   Revision  Changes    Path
   1.1       +19 -0     ports/misc/kdeedu3/files/patch-kstars-indi-fli_libfli-usb-sys-bsd.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
