From delphij@FreeBSD.org  Tue Mar 24 23:58:57 2009
Return-Path: <delphij@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 59514106564A;
	Tue, 24 Mar 2009 23:58:57 +0000 (UTC)
	(envelope-from delphij@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 2D6BA8FC18;
	Tue, 24 Mar 2009 23:58:57 +0000 (UTC)
	(envelope-from delphij@FreeBSD.org)
Received: from freefall.freebsd.org (delphij@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n2ONwueo050882;
	Tue, 24 Mar 2009 23:58:56 GMT
	(envelope-from delphij@freefall.freebsd.org)
Received: (from delphij@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n2ONwuOW050881;
	Tue, 24 Mar 2009 23:58:56 GMT
	(envelope-from delphij)
Message-Id: <200903242358.n2ONwuOW050881@freefall.freebsd.org>
Date: Tue, 24 Mar 2009 23:58:56 GMT
From: Xin LI <delphij@freebsd.org>
Reply-To: Xin LI <delphij@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: wxs@freebsd.org
Subject: [PATCH] net/cvsup-mirror: Don't compress cvsup.log
X-Send-Pr-Version: 3.113
X-GNATS-Notify: d@delphij.net

>Number:         133030
>Category:       ports
>Synopsis:       [PATCH] net/cvsup-mirror: Don't compress cvsup.log
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 25 00:00:12 UTC 2009
>Closed-Date:    Tue Apr 07 16:53:26 UTC 2009
>Last-Modified:  Tue Apr  7 17:00:11 UTC 2009
>Originator:     Xin LI
>Release:        FreeBSD 7.1-PRERELEASE i386
>Organization:
The FreeBSD Project
>Environment:
System: FreeBSD freefall.freebsd.org 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #36: Mon Dec 29 15:15:30 UTC 2008 simon@freefall.freebsd.org:/usr/src/sys/i386/compile/FREEFALL i386


>Description:
	By default, cvsup-mirror would create a newsyslog entry which not
only cut the cvsup.log file, but also compress it.  On the other hand, the
port does not implement proper logging mechanism which can be notified when
the log file is rotated.

	This would cause problem when the updating changeset is very large,
the system administrator just loses the opportunity to watch the progress
of the synchornization.

	The attached patch changes the flag from 'Z' to '-'.
>How-To-Repeat:
	Install a new cvsup mirror and watch the log.
>Fix:


--- cvsup-mirror.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net/cvsup-mirror/Makefile,v
retrieving revision 1.28
diff -u -p -r1.28 Makefile
--- Makefile	13 Mar 2008 21:31:02 -0000	1.28
+++ Makefile	24 Mar 2009 23:54:10 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	cvsup-mirror
 PORTVERSION=	1.3
-PORTREVISION=	7
+PORTREVISION=	8
 CATEGORIES=	net
 DISTFILES=
 
Index: pkg-install
===================================================================
RCS file: /home/ncvs/ports/net/cvsup-mirror/pkg-install,v
retrieving revision 1.7
diff -u -p -r1.7 pkg-install
--- pkg-install	2 Jan 2006 10:05:11 -0000	1.7
+++ pkg-install	24 Mar 2009 23:54:01 -0000
@@ -190,7 +190,7 @@ EOF
 
 	    echo "Adding cvsup and cvsupd log entry to \"/etc/newsyslog.conf\"."
 	    cat <<EOF >>/etc/newsyslog.conf
-/var/log/cvsup.log			664  7    *    24    Z
+/var/log/cvsup.log			664  7    *    24    -
 /var/log/cvsupd.log			664  7    *    24    Z
 EOF
 	    echo "Done."
--- cvsup-mirror.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Mar 25 00:00:25 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133030 
State-Changed-From-To: open->closed 
State-Changed-By: wxs 
State-Changed-When: Tue Apr 7 16:53:24 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=133030 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/133030: commit references a PR
Date: Tue,  7 Apr 2009 16:53:15 +0000 (UTC)

 wxs         2009-04-07 16:53:04 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/cvsup-mirror     Makefile pkg-install 
   Log:
   - Don't compress cvsup.log by default.
   
   PR:             ports/133030
   Submitted by:   delphij@
   
   Revision  Changes    Path
   1.29      +1 -1      ports/net/cvsup-mirror/Makefile
   1.8       +1 -1      ports/net/cvsup-mirror/pkg-install
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
