From hhyou@cs.nctu.edu.tw  Wed Mar 18 06:52:14 2009
Return-Path: <hhyou@cs.nctu.edu.tw>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0EA85106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 Mar 2009 06:52:14 +0000 (UTC)
	(envelope-from hhyou@cs.nctu.edu.tw)
Received: from csmailgate.cs.nctu.edu.tw (csmailgate.cs.nctu.edu.tw [140.113.235.103])
	by mx1.freebsd.org (Postfix) with ESMTP id D388A8FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 Mar 2009 06:52:13 +0000 (UTC)
	(envelope-from hhyou@cs.nctu.edu.tw)
Received: from csmail1.cs.nctu.edu.tw (csmail1 [140.113.235.71])
	by csmailgate.cs.nctu.edu.tw (Postfix) with ESMTP id C0B764146B;
	Wed, 18 Mar 2009 14:52:12 +0800 (CST)
Received: by csmail1.cs.nctu.edu.tw (Postfix, from userid 12860)
	id AA4104BE6B; Wed, 18 Mar 2009 14:52:12 +0800 (CST)
Message-Id: <20090318065212.AA4104BE6B@csmail1.cs.nctu.edu.tw>
Date: Wed, 18 Mar 2009 14:52:12 +0800 (CST)
From: Hsin-Han You <hhyou@cs.nctu.edu.tw>
To: FreeBSD-gnats-submit@freebsd.org
Cc: snowfly@yuntech.edu.tw
Subject: [PATCH] net-mgmt/p5-NetApp: Missing dependency
X-Send-Pr-Version: 3.113
X-GNATS-Notify: snowfly@yuntech.edu.tw

>Number:         132767
>Category:       ports
>Synopsis:       [PATCH] net-mgmt/p5-NetApp: Missing dependency
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lwhsu
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 18 07:00:13 UTC 2009
>Closed-Date:    Wed Mar 25 18:17:23 UTC 2009
>Last-Modified:  Wed Mar 25 18:20:01 UTC 2009
>Originator:     Hsin-Han You
>Release:        FreeBSD 7.1-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD csmail1.cs.nctu.edu.tw 7.1-RELEASE FreeBSD 7.1-RELEASE #1: Fri Jan  9 19:01:14 CST
>Description:

Missing p5-Clone as RUN_DEPEND,
A simple perl script like this will go wrong.

#!/usr/bin/perl

use NetApp::Filer;
use strict;

my $hostname = "somehost";

my $netapp = NetApp::Filer->new({
    hostname        => $hostname,
    ssh_command     => [ @ssh_command ],
    });

Running this script will cause:

BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/5.8.8/NetApp/Filer.pm line 19.


Port maintainer (snowfly@yuntech.edu.tw) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
Install net-mgmt/p5-NetApp without devel/p5-Clone
>Fix:

--- p5-NetApp-1.1.2_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net-mgmt/p5-NetApp/Makefile,v
retrieving revision 1.1
diff -u -u -r1.1 Makefile
--- Makefile	10 Mar 2009 15:13:43 -0000	1.1
+++ Makefile	18 Mar 2009 06:50:04 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	NetApp
 PORTVERSION=	1.1.2
+PORTREVISION=	1
 CATEGORIES=	net-mgmt perl5
 MASTER_SITES=	${MASTER_SITE_PERL_CPAN}
 MASTER_SITE_SUBDIR=	NetApp
@@ -22,7 +23,8 @@
 		p5-Regexp-Common>=0:${PORTSDIR}/textproc/p5-Regexp-Common \
 		p5-Memoize>=0:${PORTSDIR}/devel/p5-Memoize \
 		p5-Net-Telnet>=0:${PORTSDIR}/net/p5-Net-Telnet \
-		p5-Test-Exception>=0:${PORTSDIR}/devel/p5-Test-Exception
+		p5-Test-Exception>=0:${PORTSDIR}/devel/p5-Test-Exception \
+		p5-Clone>=0:${PORTSDIR}/devel/p5-Clone
 BUILD_DEPENDS=	${RUN_DEPENDS}
 
 PERL_MODBUILD=	5.8.0+
--- p5-NetApp-1.1.2_1.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Mar 18 07:00:25 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132767 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: snowfly@yuntech.edu.tw
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/132767: [PATCH] net-mgmt/p5-NetApp: Missing dependency
Date: Wed, 18 Mar 2009 07:00:23 UT

 Maintainer of net-mgmt/p5-NetApp,
 
 Please note that PR ports/132767 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/132767
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->lwhsu 
Responsible-Changed-By: lwhsu 
Responsible-Changed-When: Wed Mar 18 07:11:17 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132767 

From: "snowfly" <snowfly@yuntech.edu.tw>
To: "bug-followup" <bug-followup@FreeBSD.org>
Cc:  
Subject: Re: ports/132767: [PATCH] net-mgmt/p5-NetApp: Missing dependency
Date: Wed, 25 Mar 2009 23:23:02 +0800 (CST)

 Hi:
 
 I approve this PR, please commit it.
 Thanks.
 
 
 Best Regards,
 snowfly.
State-Changed-From-To: feedback->open 
State-Changed-By: lwhsu 
State-Changed-When: Wed Mar 25 16:52:09 UTC 2009 
State-Changed-Why:  
Maintainer has approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132767 
State-Changed-From-To: open->closed 
State-Changed-By: lwhsu 
State-Changed-When: Wed Mar 25 18:17:21 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132767 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/132767: commit references a PR
Date: Wed, 25 Mar 2009 18:17:26 +0000 (UTC)

 lwhsu       2009-03-25 18:17:13 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-mgmt/p5-NetApp   Makefile 
   Log:
   - Add devel/p5-Clone to RUN_DEPEND
   
   PR:             ports/132767
   Submitted by:   Hsin-Han You <hhyou AT cs.nctu.edu.tw>
   Approved by:    "snowfly" <snowfly AT yuntech.edu.tw> (maintainer)
   
   Revision  Changes    Path
   1.2       +3 -1      ports/net-mgmt/p5-NetApp/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
