From nobody@FreeBSD.org  Tue Mar 17 21:47:50 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7FB5F106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 17 Mar 2009 21:47:50 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 6D7E68FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 17 Mar 2009 21:47:50 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n2HLlnw8019655
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 17 Mar 2009 21:47:49 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n2HLlnw2019654;
	Tue, 17 Mar 2009 21:47:49 GMT
	(envelope-from nobody)
Message-Id: <200903172147.n2HLlnw2019654@www.freebsd.org>
Date: Tue, 17 Mar 2009 21:47:49 GMT
From: Michael Scheidell <scheidell@secnap.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [MAINTAINER UPDATE] minor fixes to p5-Mail-SpamAssassin for DKIM
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         132760
>Category:       ports
>Synopsis:       [MAINTAINER UPDATE] minor fixes to mail/p5-Mail-SpamAssassin for DKIM
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 17 21:50:01 UTC 2009
>Closed-Date:    Thu Mar 19 17:11:39 UTC 2009
>Last-Modified:  Thu Mar 19 17:20:01 UTC 2009
>Originator:     Michael Scheidell
>Release:        6.4
>Organization:
SECNAP Network Security
>Environment:
all
>Description:
DKIM continues to be updates to fix minor incompatibilities with vendor implementations.  DKIM .33 fixes a couple minor issues.

(see PR http://www.freebsd.org/cgi/query-pr.cgi?pr=132514 )

While not normally requiring a portrevision, the next fix will.

Bayes.pm was trying to cache/store/compare 'tokens' in the headers, and these tokens included dkim signatures.  However, as far as bayes would be concerned, these dkim signatures are 'random', as in never repeatable.  you would never have the same dkim signature token in any email.

this patch (recommended by spamassassin, see 
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5861 

addresses this.

Clients who are aggressively doing portsupgrade would get the .33 dkim anyway, but need the bump version to get the Bayes.pm patch


>How-To-Repeat:
get a email with a dkim or domainkey signature, see useless daya in bayes.

>Fix:
note, this includes the creation of files/patch-bayes.pm

(mind the wrap on Makefile , just bumped portrevision and set dkim minimum to .33)

diff -bBru ./ /var/tmp/SA/
diff -bBru ./Makefile /var/tmp/SA/Makefile
--- ./Makefile  2009-03-17 17:31:25.000000000 -0400
+++ /var/tmp/SA/Makefile        2009-01-14 10:40:16.000000000 -0500
@@ -7,7 +7,7 @@
 
 PORTNAME=      Mail-SpamAssassin
 PORTVERSION=   3.2.5
-PORTREVISION=  2
+PORTREVISION=  1
 CATEGORIES=    mail perl5
 MASTER_SITES=  ${MASTER_SITE_APACHE:S/$/:apache/} ${MASTER_SITE_PERL_CPAN:S/$/:cpan/}
 MASTER_SITE_SUBDIR=    spamassassin/source/:apache Mail/:cpan
@@ -98,7 +98,7 @@
 .endif
 
 .if defined(WITH_DKIM)
-RUN_DEPENDS+=  p5-Mail-DKIM>=0.33:${PORTSDIR}/mail/p5-Mail-DKIM
+RUN_DEPENDS+=  p5-Mail-DKIM>=0.31:${PORTSDIR}/mail/p5-Mail-DKIM
 RUN_DEPENDS+=  ${SITE_PERL}/IO/Socket/SSL.pm:${PORTSDIR}/security/p5-IO-Socket-SSL
 RUN_DEPENDS+=  p5-Crypt-OpenSSL-RSA>=0.24:${PORTSDIR}/security/p5-Crypt-OpenSSL-RSA
 .endif
diff -bBru ./files/patch-bayes.pm /var/tmp/SA/files/patch-bayes.pm
--- ./files/patch-bayes.pm      2009-03-17 17:28:23.000000000 -0400
+++ /var/tmp/SA/files/patch-bayes.pm    2009-03-17 17:28:23.000000000 -0400
@@ -1,10 +0,0 @@
---- Bayes.pm.orig      2008-06-10 05:20:22.000000000 -0400
-+++ lib/Mail/SpamAssassin/Bayes.pm     2008-08-22 03:23:38.000000000 -0400
-@@ -145,6 +145,7 @@
- # hapaxen they generate.
- $MARK_PRESENCE_ONLY_HDRS = qr{(?: X-Face
-   |X-(?:Gnu-?PG|PGP|GPG)(?:-Key)?-Fingerprint
-+  |D(?:KIM|omainKey)-Signature
- )}ix;
- 
- # tweaks tested as of Nov 18 2002 by jm: see SpamAssassin-devel list archives


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Thu Mar 19 17:03:53 UTC 2009 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132760 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/132760: commit references a PR
Date: Thu, 19 Mar 2009 17:11:37 +0000 (UTC)

 pav         2009-03-19 17:11:28 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/p5-Mail-SpamAssassin Makefile 
   Added files:
     mail/p5-Mail-SpamAssassin/files patch-bayes.pm 
   Log:
   - Fix bayesian filtering with DKIM enabled, bump PORTREVISION
   
   PR:             ports/132760
   Submitted by:   Michael Scheidell <scheidell@secnap.net> (maintainer)
   
   Revision  Changes    Path
   1.123     +2 -2      ports/mail/p5-Mail-SpamAssassin/Makefile
   1.1       +10 -0     ports/mail/p5-Mail-SpamAssassin/files/patch-bayes.pm (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
