From nobody@FreeBSD.org  Sat Mar  7 13:59:58 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 97AE81065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  7 Mar 2009 13:59:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 863ED8FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  7 Mar 2009 13:59:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n27DxwLa049965
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 7 Mar 2009 13:59:58 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n27DxvkM049964;
	Sat, 7 Mar 2009 13:59:57 GMT
	(envelope-from nobody)
Message-Id: <200903071359.n27DxvkM049964@www.freebsd.org>
Date: Sat, 7 Mar 2009 13:59:57 GMT
From: "Scot W. Hetzel" <swhetzel@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] devel/git: Change hard coded TCL dependancy to USE_TCL
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         132386
>Category:       ports
>Synopsis:       [patch] devel/git: Change hard coded TCL dependancy to USE_TCL
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 07 14:00:09 UTC 2009
>Closed-Date:    Mon Mar 09 16:08:35 UTC 2009
>Last-Modified:  Mon Mar  9 16:10:05 UTC 2009
>Originator:     Scot W. Hetzel
>Release:        8.0-CURRENT
>Organization:
>Environment:
FreeBSD hp010 8.0-CURRENT FreeBSD 8.0-CURRENT #1: Fri Mar  6 02:22:28 CST 2009     root@hp010:/usr/obj/usr/src/8x-zfs/sys/DV8135NR  amd64

>Description:
Currently, devel/git has a hardcoded run dependency on TK 8.4. The attached patch allows devel/git to use TK 8.4+.
>How-To-Repeat:

>Fix:
Apply the attached patch.

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/git/Makefile,v
retrieving revision 1.48
diff -u -r1.48 Makefile
--- Makefile	24 Feb 2009 19:59:43 -0000	1.48
+++ Makefile	7 Mar 2009 13:35:24 -0000
@@ -199,12 +199,13 @@
 .endif
 
 .ifndef (WITHOUT_GUI)
+USE_TK=		84+
+.include "${PORTSDIR}/Mk/bsd.tcl.mk"
 MAN1+=		git-citool.1 \
 		git-gui.1 \
 		gitk.1
 PLIST_SUB+=	GUI=""
-RUN_DEPENDS+=	wish8.4:${PORTSDIR}/x11-toolkits/tk84
-MAKE_ENV+=	TCL_PATH=tclsh8.4 TCLTK_PATH=wish8.4
+MAKE_ENV+=	TCL_PATH=${TCLSH} TCLTK_PATH=${WISH}
 .else
 PLIST_SUB+=	GUI="@comment "
 MAKE_ENV+=	NO_TCLTK=yes


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Mar 7 14:00:24 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132386 

From: Martin Matuska <mm@FreeBSD.org>
To: bug-followup@FreeBSD.org, swhetzel@gmail.com
Cc:  
Subject: Re: ports/132386: [patch] devel/git: Change hard coded TCL dependancy
 to USE_TCL
Date: Sat, 07 Mar 2009 20:54:09 +0100

 I agree to this patch.
State-Changed-From-To: open->closed 
State-Changed-By: wxs 
State-Changed-When: Mon Mar 9 16:08:34 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132386 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/132386: commit references a PR
Date: Mon,  9 Mar 2009 16:09:20 +0000 (UTC)

 wxs         2009-03-09 16:08:24 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/git            Makefile 
   Log:
   - Switch to USE_TK= 84+
   
   PR:             ports/132386
   Submitted by:   "Scot W. Hetzel" <swhetzel@gmail.com>
   Approved by:    mm, wxs (maintainer)
   
   Revision  Changes    Path
   1.49      +3 -2      ports/devel/git/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
