From nobody@FreeBSD.org  Sat Mar  7 07:47:29 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B2EDC106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  7 Mar 2009 07:47:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A11BA8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  7 Mar 2009 07:47:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n277lTZL017040
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 7 Mar 2009 07:47:29 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n277lTY8017038;
	Sat, 7 Mar 2009 07:47:29 GMT
	(envelope-from nobody)
Message-Id: <200903070747.n277lTY8017038@www.freebsd.org>
Date: Sat, 7 Mar 2009 07:47:29 GMT
From: "Scot W. Hetzel" <swhetzel@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] databases/sqlite3: Change hard coded TCL dependancy to USE_TCL
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         132382
>Category:       ports
>Synopsis:       [patch] databases/sqlite3: Change hard coded TCL dependancy to USE_TCL
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mnag
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Mar 07 07:50:05 UTC 2009
>Closed-Date:    Mon Mar 23 13:45:38 UTC 2009
>Last-Modified:  Mon Mar 23 13:45:38 UTC 2009
>Originator:     Scot W. Hetzel
>Release:        8.0-CURRENT
>Organization:
>Environment:
FreeBSD hp010 8.0-CURRENT FreeBSD 8.0-CURRENT #1: Fri Mar  6 02:22:28 CST 2009     root@hp010:/usr/obj/usr/src/8x-zfs/sys/DV8135NR  amd64

>Description:
Currently, databases/sqlite3 has a dependency on TCL 8.4.  The port uses an inconsistent variable (TCL_V) to select a different version of TCL.

This will cause all dependant ports on sqlite3 to have an indirect dependency on TCL 8.4 (or ${TCL_V}).
>How-To-Repeat:
Install TCL > 8.4 and set WITH_TCL_VER to that version
Then install databases/sqlite3

This will cause the installation to TCL 8.4

>Fix:
The attached patch allows databases/sqlite3 to choose the TCL version through the USE_TCL variable.

Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/databases/sqlite3/Makefile,v
retrieving revision 1.34
diff -u -r1.34 Makefile
--- Makefile	27 Jan 2009 02:16:09 -0000	1.34
+++ Makefile	7 Mar 2009 05:07:36 -0000
@@ -46,12 +46,12 @@
 .endif
 
 .if defined(WITH_TCLWRAPPER)
-TCL_V?=			8.4
-MAKE_ARGS+=		TCLSH=tclsh${TCL_V}
-MAKE_ENV+=		TCL_VER=${TCL_V}
+USE_TCL=		84+
+.include		"${PORTSDIR}/Mk/bsd.tcl.mk"
+MAKE_ARGS+=		TCLSH=${TCLSH}
+MAKE_ENV+=		TCL_VER=${TCL_VER}
 CATEGORIES+=		lang tcl
-LIB_DEPENDS+=		tcl${TCL_V:S/.//}:${PORTSDIR}/lang/tcl${TCL_V:S/.//}
-CONFIGURE_ARGS+=	--with-tcl=${LOCALBASE}/lib/tcl${TCL_V}
+CONFIGURE_ARGS+=	--with-tcl=${TCL_LIBDIR}
 PLIST_SUB+=		WITH_TCLWRAPPER=""
 .else
 CONFIGURE_ARGS+=	--disable-tcl


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->mnag 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Mar 7 07:50:15 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132382 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/132382: commit references a PR
Date: Mon, 23 Mar 2009 05:31:25 +0000 (UTC)

 mnag        2009-03-23 05:31:15 UTC
 
   FreeBSD ports repository
 
   Modified files:
     databases/sqlite3    Makefile distinfo pkg-plist 
     databases/sqlite3/files patch-Makefile.in 
   Log:
   - Update to 3.6.11
   - Change hard coded TCL dependancy to USE_TCL [1]
   
   PR:             132382 [1]
   Submitted by:   Scot W. Hetzel <swhetzel___gmail.com> [1]
   
   Revision  Changes    Path
   1.35      +12 -11    ports/databases/sqlite3/Makefile
   1.25      +3 -3      ports/databases/sqlite3/distinfo
   1.7       +24 -0     ports/databases/sqlite3/files/patch-Makefile.in
   1.13      +5 -5      ports/databases/sqlite3/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: mnag 
State-Changed-When: Mon Mar 23 13:45:37 UTC 2009 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132382 
>Unformatted:
