From nobody@FreeBSD.org  Wed Feb 25 12:44:46 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7F904106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Feb 2009 12:44:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 6E2E18FC1D
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Feb 2009 12:44:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n1PCijH3044423
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 25 Feb 2009 12:44:45 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n1PCijTd044422;
	Wed, 25 Feb 2009 12:44:45 GMT
	(envelope-from nobody)
Message-Id: <200902251244.n1PCijTd044422@www.freebsd.org>
Date: Wed, 25 Feb 2009 12:44:45 GMT
From: Oleg Ginzburg <oleg.ginzburg@nevosoft.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: devel/distcc: fixing valid shell for user distcc in pkg-install
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         132096
>Category:       ports
>Synopsis:       devel/distcc: fixing valid shell for user distcc in pkg-install
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ahze
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 25 12:50:01 UTC 2009
>Closed-Date:    Mon Apr 19 20:05:07 UTC 2010
>Last-Modified:  Mon Apr 19 20:10:05 UTC 2010
>Originator:     Oleg Ginzburg
>Release:        8-CURRENT
>Organization:
>Environment:
FreeBSD oleg.net.nevosoft.ru 8.0-CURRENT FreeBSD 8.0-CURRENT #2 r188990: Tue Feb 24 14:34:57 MSK 2009     root@oleg.net.nevosoft.ru:/usr/obj/usr/src/sys/o20090103  i386
>Description:
Deprecated path to nologin shell in pkg-install for distcc user. 
Must be /usr/sbin/nologin according to `grep ^distcc /usr/ports/UIDs`

>How-To-Repeat:

>Fix:
patch.txt

Patch attached with submission follows:

diff -ruN distcc.bak/pkg-install distcc/pkg-install
--- distcc.bak/pkg-install	2009-02-25 15:37:15.000000000 +0300
+++ distcc/pkg-install	2009-02-25 15:38:04.000000000 +0300
@@ -23,7 +23,7 @@
 		echo "You already have a user \"${USER}\", so I will use it."
 	else
 		if ${PW} useradd ${USER} -u ${UID} -g ${GROUP} -h - \
-			-d "/nonexistent" -s /sbin/nologin -c "Distcc user"
+			-d "/nonexistent" -s /usr/sbin/nologin -c "Distcc user"
 		then
 			echo "Added user \"${USER}\"."
 		else


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ahze 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Feb 25 12:50:17 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132096 
State-Changed-From-To: open->closed 
State-Changed-By: skreuzer 
State-Changed-When: Mon Apr 19 20:05:06 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=132096 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/132096: commit references a PR
Date: Mon, 19 Apr 2010 20:04:31 +0000 (UTC)

 skreuzer    2010-04-19 20:04:23 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/distcc         pkg-install 
   Log:
   Set the distcc user's shell to /usr/sbin/nologin
   
   PR:             ports/132096
   Submitted by:   Oleg Ginzburg <oleg.ginzburg@nevosoft.ru>
   Approved by:    Steven Kreuzer <skreuzer@FreeBSD.org>
   
   Revision  Changes    Path
   1.3       +1 -1      ports/devel/distcc/pkg-install
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
