From nobody@FreeBSD.org  Sun Feb 22 15:57:25 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8FAAD106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 22 Feb 2009 15:57:25 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 7DEB78FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 22 Feb 2009 15:57:25 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n1MFvOHs081159
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 22 Feb 2009 15:57:24 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n1MFvOgN081158;
	Sun, 22 Feb 2009 15:57:24 GMT
	(envelope-from nobody)
Message-Id: <200902221557.n1MFvOgN081158@www.freebsd.org>
Date: Sun, 22 Feb 2009 15:57:24 GMT
From: Dmitry <dmitry2006@yandex.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: security/racoon2 not worked simultaneously ikev1 and ikev2 [PATCH]
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         131976
>Category:       ports
>Synopsis:       security/racoon2 not worked simultaneously ikev1 and ikev2 [PATCH]
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    sumikawa
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 22 16:00:07 UTC 2009
>Closed-Date:    Mon Feb 23 12:17:31 JST 2009
>Last-Modified:  Mon Feb 23 03:20:01 UTC 2009
>Originator:     Dmitry
>Release:        FreeBSD 7.1-STABLE amd64
>Organization:
>Environment:
FreeBSD *** 7.1-STABLE FreeBSD 7.1-STABLE #0: Sat Feb 21 04:30:04 YEKT 2009     root@***:/usr/src/sys/GENERIC_  amd64
>Description:
Before I made the corrections I have not worked simultaneously ikev1 and ikev2 
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- lib/cfsetup.c.orig	2007-12-05 12:26:10.000000000 +0500
+++ lib/cfsetup.c	2008-11-12 14:44:48.000000000 +0500
@@ -3636,15 +3637,15 @@
 			    "invalid kmp type %s\n", rct2str(proto));
 			return -1;
 		}
-		if (!kmp || !kmp->peers_ipaddr)
-			return -1;
-		for (al = kmp->peers_ipaddr; al != 0; al = al->next) {
-			if (al->type != RCT_ADDR_INET)
-				continue;
-			if (rcs_cmpsa_wop(al->a.ipaddr, s) != 0)
-				continue;
-			src = n;
-			goto found;
+		if (kmp && kmp->peers_ipaddr) {
+			for (al = kmp->peers_ipaddr; al != 0; al = al->next) {
+				if (al->type != RCT_ADDR_INET)
+					continue;
+				if (rcs_cmpsa_wop(al->a.ipaddr, s) != 0)
+					continue;
+				src = n;
+				goto found;
+			}
 		}
 	}
   found:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sumikawa 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Feb 22 16:00:17 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131976 
State-Changed-From-To: open->closed 
State-Changed-By: sumikawa 
State-Changed-When: Mon Feb 23 12:17:06 JST 2009 
State-Changed-Why:  
commited, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131976 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/131976: commit references a PR
Date: Mon, 23 Feb 2009 03:16:44 +0000 (UTC)

 sumikawa    2009-02-23 03:16:29 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security/racoon2     Makefile 
   Added files:
     security/racoon2/files patch-lib-cfsetup.c 
   Log:
   Fix rcf_get_remotebyaddr() condition.
   This fixes not worked simultaneously ikev1 and ikev2.
   
   From:           Dmitry <dmitry2006@yandex.ru>
   PR:             ports/131976
   Obtained from:  http://www.racoon2.wide.ad.jp/cvsweb/racoon2/lib/cfsetup.c.diff?r1=1.102&r2=1.103
   
   Revision  Changes    Path
   1.58      +1 -1      ports/security/racoon2/Makefile
   1.1       +27 -0     ports/security/racoon2/files/patch-lib-cfsetup.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
Commited, thanks.
