From kheuer@gwdu60.gwdg.de  Mon Feb 16 10:57:32 2009
Return-Path: <kheuer@gwdu60.gwdg.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AE85B106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 16 Feb 2009 10:57:32 +0000 (UTC)
	(envelope-from kheuer@gwdu60.gwdg.de)
Received: from gwdu60.gwdg.de (gwdu60.gwdg.de [134.76.8.60])
	by mx1.freebsd.org (Postfix) with ESMTP id 3602F8FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 16 Feb 2009 10:57:31 +0000 (UTC)
	(envelope-from kheuer@gwdu60.gwdg.de)
Received: from gwdu60.gwdg.de (localhost [127.0.0.1])
	by gwdu60.gwdg.de (8.14.2/8.14.2) with ESMTP id n1GAfObt084782
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 16 Feb 2009 11:41:24 +0100 (CET)
	(envelope-from kheuer@gwdu60.gwdg.de)
Received: (from kheuer@localhost)
	by gwdu60.gwdg.de (8.14.2/8.14.2/Submit) id n1GAfO0Q084781;
	Mon, 16 Feb 2009 11:41:24 +0100 (CET)
	(envelope-from kheuer)
Message-Id: <200902161041.n1GAfO0Q084781@gwdu60.gwdg.de>
Date: Mon, 16 Feb 2009 11:41:24 +0100 (CET)
From: Konrad Heuer <kheuer@gwdg.de>
Reply-To: Konrad Heuer <kheuer@gwdg.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Port Upgrade
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         131741
>Category:       ports
>Synopsis:       [maintainer] sysutils/rmonitor: fix problem on 64bit platforms
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    itetcu
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 16 11:00:07 UTC 2009
>Closed-Date:    Fri Feb 20 15:06:29 UTC 2009
>Last-Modified:  Fri Feb 20 15:10:01 UTC 2009
>Originator:     Konrad Heuer
>Release:        FreeBSD 7.0-RELEASE-p9 i386
>Organization:
GWDG
>Environment:
System: FreeBSD gwdu60.gwdg.de 7.0-RELEASE-p9 FreeBSD 7.0-RELEASE-p9 #7: Wed Jan 14 10:13:51 CET 2009 root@gwdu60.gwdg.de:/usr/obj/usr/src/sys/GWDU60 i386


	
>Description:
	Update port: sysutils/rmonitor
	Added patch to fix problem on 64bit platforms
	Added CFLAGS in Makefile to suppress warnings of newer gcc
>How-To-Repeat:
	
>Fix:

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	rmonitor
#	rmonitor/distinfo
#	rmonitor/files
#	rmonitor/files/patch-64bit.in
#	rmonitor/pkg-descr
#	rmonitor/Makefile
#	rmonitor/pkg-plist
#
echo c - rmonitor
mkdir -p rmonitor > /dev/null 2>&1
echo x - rmonitor/distinfo
sed 's/^X//' >rmonitor/distinfo << 'END-of-rmonitor/distinfo'
XMD5 (rmonitor-1.2.tar.gz) = e11210f20bcfc8fef7ed2e3bb453c20c
XSHA256 (rmonitor-1.2.tar.gz) = bb61cc16ab989fdd15a55fb915b397e5b4eaa70599215f8511a7bf4c7886d7da
XSIZE (rmonitor-1.2.tar.gz) = 11197
END-of-rmonitor/distinfo
echo c - rmonitor/files
mkdir -p rmonitor/files > /dev/null 2>&1
echo x - rmonitor/files/patch-64bit.in
sed 's/^X//' >rmonitor/files/patch-64bit.in << 'END-of-rmonitor/files/patch-64bit.in'
X--- ./src/rmonitor.c	2001-07-20 17:31:10.000000000 +0200
X+++ ./src/rmonitor_64ok.c	2009-02-16 11:14:31.087841000 +0100
X@@ -294,7 +294,7 @@
X #define samples 2
X   double lavg[samples];
X   int    dbufs  = 0;
X-  int    len;
X+  long   len;
X   int    maxf   = -1;
X   int    maxp   = -1;
X   int    memfre = 0;
END-of-rmonitor/files/patch-64bit.in
echo x - rmonitor/pkg-descr
sed 's/^X//' >rmonitor/pkg-descr << 'END-of-rmonitor/pkg-descr'
XRmonitor is a client-server application for monitoring a couple of (or even
Xmore) remote hosts. It prints gathered system statistics on a standard
Xterminal display or within an xterm window; using one line for each host
Xmonitored.
X
XKonrad Heuer
Xkheuer@gwdu60.gwdg.de
END-of-rmonitor/pkg-descr
echo x - rmonitor/Makefile
sed 's/^X//' >rmonitor/Makefile << 'END-of-rmonitor/Makefile'
X# New ports collection makefile for:    rmonitor
X# Date created:         March 1st, 2001
X# Whom:                 Konrad Heuer
X#
X# $FreeBSD: ports/sysutils/rmonitor/Makefile,v 1.5 2003/02/21 13:28:52 knu Exp $
X#
X
XPORTNAME=	rmonitor
XPORTVERSION=	1.2
XCATEGORIES=	sysutils
XMASTER_SITES=	ftp://gwdu111.gwdg.de/pub/FreeBSD/misc/ \
X		ftp://gwdu112.gwdg.de/pub/FreeBSD/misc/
X
XMAINTAINER=	kheuer@gwdu60.gwdg.de
XCOMMENT=	Remote system monitoring utility
X
XMAN1=		rmonitor.1
XMANCOMPRESSED=	yes
X
XCFLAGS+=	-w
X
X.include <bsd.port.mk>
END-of-rmonitor/Makefile
echo x - rmonitor/pkg-plist
sed 's/^X//' >rmonitor/pkg-plist << 'END-of-rmonitor/pkg-plist'
Xbin/rmonitor
Xetc/rc.d/rmonitor.sh
END-of-rmonitor/pkg-plist
exit


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->itetcu 
Responsible-Changed-By: itetcu 
Responsible-Changed-When: Mon Feb 16 11:59:21 UTC 2009 
Responsible-Changed-Why:  
Take for didactic reasons 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131741 
Class-Changed-From-To: change-request->maintainer-update 
Class-Changed-By: itetcu 
Class-Changed-When: Mon Feb 16 12:14:53 UTC 2009 
Class-Changed-Why:  
Fix synopsis, etc. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131741 
State-Changed-From-To: open->feedback 
State-Changed-By: itetcu 
State-Changed-When: Mon Feb 16 12:17:38 UTC 2009 
State-Changed-Why:  
Please submit a diff -u. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131741 

From: Ion-Mihai Tetcu <itetcu@FreeBSD.org>
To: Konrad Heuer <kheuer@gwdg.de>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/131741: Port Upgrade
Date: Mon, 16 Feb 2009 14:14:37 +0200

 --Sig_/0BoFzs=azsmZIY+CJoMXvN2
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: quoted-printable
 
 > >Synopsis:       Port Upgrade
 
 Please use a more descriptive synopsis line next time like:
 [maintainer] category/port: short description of PR's content
 eg.:
 [maintainer] sysutils/rmonitor: fix problem on 64bit platforms
 
 This server for:
 - users and committers to easily visual inspect your PR and decide if
   they are interested in it
 - the PR auto-assigner to assign your PR to the appropriate committer.
 
 > >Confidential:   no
 > >Severity:       serious
 
 Is it?
 
 > >Priority:       medium
 
 Is it?
 
 > >Class:          change-request
 
 Since you're the maintainer:
 maintainer-update
 
 
 > >Description:
 > 	Update port: sysutils/rmonitor
 > 	Added patch to fix problem on 64bit platforms
 
 Maybe you could be more verbose here: what's the problem? How does it
 affects users? etc.
 
 > 	Added CFLAGS in Makefile to suppress warnings of newer gcc
 > >How-To-Repeat:
 > =09
 > >Fix:
 >=20
 > # This is a shell archive.  Save it in a file, remove anything before
 
 Please submit updates to existing ports in diff -u format. It makes it
 much easier to handle and see what really changed.
 http://t32.tecnik93.com/FreeBSD/How-to-submit-a-diff.txt
 
 Since you're fixing a bug you should also bump PORTREVISION, else users
 won't know to update.
 
 
 --=20
 IOnut - Un^d^dregistered ;) FreeBSD "user"
   "Intellectual Property" is   nowhere near as valuable   as "Intellect"
 FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B
 
 
 --Sig_/0BoFzs=azsmZIY+CJoMXvN2
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Disposition: attachment; filename=signature.asc
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.10 (FreeBSD)
 
 iEYEARECAAYFAkmZWLMACgkQJ7GIuiH/oeWw3wCfT+Tm5AMtxRUOY6xekaBeINQR
 0D8An3hauBccPuXYmG/G+jBVcDsf+n+F
 =S0NK
 -----END PGP SIGNATURE-----
 
 --Sig_/0BoFzs=azsmZIY+CJoMXvN2--

From: Konrad Heuer <kheuer@gwdg.de>
To: Ion-Mihai Tetcu <itetcu@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/131741: Port Upgrade
Date: Mon, 16 Feb 2009 14:29:58 +0100 (CET)

 On Mon, 16 Feb 2009, Ion-Mihai Tetcu wrote:
 
 >>> Synopsis:       Port Upgrade
 >
 > Please use a more descriptive synopsis line next time like:
 > [maintainer] category/port: short description of PR's content
 > eg.:
 > [maintainer] sysutils/rmonitor: fix problem on 64bit platforms
 >
 > This server for:
 > - users and committers to easily visual inspect your PR and decide if
 >  they are interested in it
 > - the PR auto-assigner to assign your PR to the appropriate committer.
 >
 
 I will do better next time ...
 
 
 >>> Confidential:   no
 >>> Severity:       serious
 >
 > Is it?
 >
 >>> Priority:       medium
 >
 > Is it?
 
 Isn't it? I'm not sure ... what do you suggest if an application gives bad 
 results because of an integer overflow?
 
 >>> Class:          change-request
 >
 > Since you're the maintainer:
 > maintainer-update
 >>> Description:
 >> 	Update port: sysutils/rmonitor
 >> 	Added patch to fix problem on 64bit platforms
 >
 > Maybe you could be more verbose here: what's the problem? How does it
 > affects users? etc.
 >
 >> 	Added CFLAGS in Makefile to suppress warnings of newer gcc
 
 That's right; I'll learn, see above ..
 
 >>> Fix:
 >>
 >> # This is a shell archive.  Save it in a file, remove anything before
 >
 > Please submit updates to existing ports in diff -u format. It makes it
 > much easier to handle and see what really changed.
 > http://t32.tecnik93.com/FreeBSD/How-to-submit-a-diff.txt
 >
 > Since you're fixing a bug you should also bump PORTREVISION, else users
 > won't know to update.
 
 You're right. PORTREVISION has now been set.
 
 I tried to follow your instructions concerning "diff -u" but wasn't 
 successful. My privileges were insufficient for creating a directory named 
 "files" within the CVS repository.
 
 A simple "diff -u" doesn't help too. It won't give you a "files" directory 
 containing the patch file, or did I miss something?
 
 Thus, please find a shar archive with last modifications below.
 
 Best regards
 Konrad Heuer (kheuer@gwdg.de)
 
 # This is a shell archive.  Save it in a file, remove anything before
 # this line, and then unpack it by entering "sh file".  Note, it may
 # create directories; files and directories will be owned by you and
 # have default permissions.
 #
 # This archive contains:
 #
 #	rmonitor
 #	rmonitor/distinfo
 #	rmonitor/files
 #	rmonitor/files/patch-64bit.in
 #	rmonitor/pkg-descr
 #	rmonitor/Makefile
 #	rmonitor/pkg-plist
 #
 echo c - rmonitor
 mkdir -p rmonitor > /dev/null 2>&1
 echo x - rmonitor/distinfo
 sed 's/^X//' >rmonitor/distinfo << 'END-of-rmonitor/distinfo'
 XMD5 (rmonitor-1.2.tar.gz) = e11210f20bcfc8fef7ed2e3bb453c20c
 XSHA256 (rmonitor-1.2.tar.gz) = bb61cc16ab989fdd15a55fb915b397e5b4eaa70599215f8511a7bf4c7886d7da
 XSIZE (rmonitor-1.2.tar.gz) = 11197
 END-of-rmonitor/distinfo
 echo c - rmonitor/files
 mkdir -p rmonitor/files > /dev/null 2>&1
 echo x - rmonitor/files/patch-64bit.in
 sed 's/^X//' >rmonitor/files/patch-64bit.in << 'END-of-rmonitor/files/patch-64bit.in'
 X--- ./src/rmonitor.c	2001-07-20 17:31:10.000000000 +0200
 X+++ ./src/rmonitor_64ok.c	2009-02-16 11:14:31.087841000 +0100
 X@@ -294,7 +294,7 @@
 X #define samples 2
 X   double lavg[samples];
 X   int    dbufs  = 0;
 X-  int    len;
 X+  long   len;
 X   int    maxf   = -1;
 X   int    maxp   = -1;
 X   int    memfre = 0;
 END-of-rmonitor/files/patch-64bit.in
 echo x - rmonitor/pkg-descr
 sed 's/^X//' >rmonitor/pkg-descr << 'END-of-rmonitor/pkg-descr'
 XRmonitor is a client-server application for monitoring a couple of (or even
 Xmore) remote hosts. It prints gathered system statistics on a standard
 Xterminal display or within an xterm window; using one line for each host
 Xmonitored.
 X
 XKonrad Heuer
 Xkheuer@gwdu60.gwdg.de
 END-of-rmonitor/pkg-descr
 echo x - rmonitor/Makefile
 sed 's/^X//' >rmonitor/Makefile << 'END-of-rmonitor/Makefile'
 X# New ports collection makefile for:    rmonitor
 X# Date created:         March 1st, 2001
 X# Whom:                 Konrad Heuer
 X#
 X# $FreeBSD: ports/sysutils/rmonitor/Makefile,v 1.5 2003/02/21 13:28:52 knu Exp $
 X#
 X
 XPORTNAME=	rmonitor
 XPORTVERSION=	1.2
 XPORTREVISION=	1
 XCATEGORIES=	sysutils
 XMASTER_SITES=	ftp://gwdu111.gwdg.de/pub/FreeBSD/misc/ \
 X		ftp://gwdu112.gwdg.de/pub/FreeBSD/misc/
 X
 XMAINTAINER=	kheuer@gwdu60.gwdg.de
 XCOMMENT=	Remote system monitoring utility
 X
 XMAN1=		rmonitor.1
 XMANCOMPRESSED=	yes
 X
 XCFLAGS+=	-w
 X
 X.include <bsd.port.mk>
 END-of-rmonitor/Makefile
 echo x - rmonitor/pkg-plist
 sed 's/^X//' >rmonitor/pkg-plist << 'END-of-rmonitor/pkg-plist'
 Xbin/rmonitor
 Xetc/rc.d/rmonitor.sh
 END-of-rmonitor/pkg-plist
 exit
 

From: Ion-Mihai Tetcu <itetcu@FreeBSD.org>
To: Konrad Heuer <kheuer@gwdg.de>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/131741: Port Upgrade
Date: Mon, 16 Feb 2009 23:46:47 +0200

 --Sig_/nNRvjxeXcKLYMLbXHo+ti+U
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: quoted-printable
 
 On Mon, 16 Feb 2009 14:29:58 +0100 (CET)
 Konrad Heuer <kheuer@gwdg.de> wrote:
 
 >=20
 > On Mon, 16 Feb 2009, Ion-Mihai Tetcu wrote:
 >=20
 > >>> Synopsis:       Port Upgrade
 > >
 > > Please use a more descriptive synopsis line next time like:
 > > [maintainer] category/port: short description of PR's content
 > > eg.:
 > > [maintainer] sysutils/rmonitor: fix problem on 64bit platforms
 > >
 > > This server for:
 > > - users and committers to easily visual inspect your PR and decide
 > > if they are interested in it
 > > - the PR auto-assigner to assign your PR to the appropriate
 > > committer.
 >=20
 > I will do better next time ...
 
 Thanks.
 
 > >>> Confidential:   no
 > >>> Severity:       serious
 > >
 > > Is it?
 > >
 > >>> Priority:       medium
 > >
 > > Is it?
 >=20
 > Isn't it? I'm not sure ... what do you suggest if an application
 > gives bad results because of an integer overflow?
 
 No.
 
 The fact is that this two fields get so much abuse that is very hard to
 do any meaningful sorting based on them.
 
 AFAIK serious is usually for security fixes, but YMMV. :-)
 
 > >>> Class:          change-request
 > >
 > > Since you're the maintainer:
 > > maintainer-update
 > >>> Description:
 > >> 	Update port: sysutils/rmonitor
 > >> 	Added patch to fix problem on 64bit platforms
 > >
 > > Maybe you could be more verbose here: what's the problem? How does
 > > it affects users? etc.
 > >
 > >> 	Added CFLAGS in Makefile to suppress warnings of newer gcc
 >=20
 > That's right; I'll learn, see above ..
 
 OK, so there was an integer overflow.
 
 > >>> Fix:
 > >>
 > >> # This is a shell archive.  Save it in a file, remove anything
 > >> before
 > >
 > > Please submit updates to existing ports in diff -u format. It makes
 > > it much easier to handle and see what really changed.
 > > http://t32.tecnik93.com/FreeBSD/How-to-submit-a-diff.txt
 > >
 > > Since you're fixing a bug you should also bump PORTREVISION, else
 > > users won't know to update.
 >=20
 > You're right. PORTREVISION has now been set.
 >=20
 > I tried to follow your instructions concerning "diff -u" but wasn't=20
 > successful. My privileges were insufficient for creating a directory
 > named "files" within the CVS repository.
 
 ?
 Please send me a script(1) of what you are doing.
 
 > A simple "diff -u" doesn't help too. It won't give you a "files"
 > directory containing the patch file, or did I miss something?
 
 diff -uN
 
 You might have missed cvs add.
 If you add a dir, then you have first to do 'cvs add dir_name', then
 'cvs add dir_name/file'.
 =20
 > Thus, please find a shar archive with last modifications below.
 
 Please do try to follow the instructions. Usually diffs or shars
 copy/pasted or included in the mail are mangled by MUAs and they become
 unusable. (see [11] in that link I gave you).
 
 I could try to work with your included shar, but maybe we'd better
 spend time to get this right so that it will be easier for all net time?
 Let me know.
 
 
 --=20
 IOnut - Un^d^dregistered ;) FreeBSD "user"
   "Intellectual Property" is   nowhere near as valuable   as "Intellect"
 FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B
 
 --Sig_/nNRvjxeXcKLYMLbXHo+ti+U
 Content-Type: application/pgp-signature; name=signature.asc
 Content-Disposition: attachment; filename=signature.asc
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.10 (FreeBSD)
 
 iEYEARECAAYFAkmZ3s0ACgkQJ7GIuiH/oeUfwACghAMj7QGHNe2epb1NVyWedkBH
 HNgAnAzU+rthxuWk4SPrvQnG3+BHoqY6
 =k8TZ
 -----END PGP SIGNATURE-----
 
 --Sig_/nNRvjxeXcKLYMLbXHo+ti+U--

From: Konrad Heuer <kheuer@gwdg.de>
To: Ion-Mihai Tetcu <itetcu@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/131741: Port Upgrade
Date: Tue, 17 Feb 2009 10:13:14 +0100 (CET)

 On Mon, 16 Feb 2009, Ion-Mihai Tetcu wrote:
 
 > Please do try to follow the instructions. Usually diffs or shars
 > copy/pasted or included in the mail are mangled by MUAs and they become
 > unusable. (see [11] in that link I gave you).
 >
 > I could try to work with your included shar, but maybe we'd better
 > spend time to get this right so that it will be easier for all net time?
 > Let me know.
 
 Thank you for your help. Here is what I do and what happens if I try do 
 follow your suggestions:
 
 gwdu60% mkdir rwork
 
 gwdu60% cd rwork
 
 gwdu60% cp -pR ../rmonitor.new .
 
 gwdu60% cvs -d anoncvs@anoncvs.fr.FreeBSD.org:/home/ncvs co rmonitor
 cvs checkout: Updating rmonitor
 U rmonitor/Makefile
 U rmonitor/distinfo
 U rmonitor/pkg-descr
 U rmonitor/pkg-plist
 
 gwdu60% cd rmonitor
 
 gwdu60% cp -p ../rmonitor.new/Makefile .
 
 gwdu60% cp -pR ../rmonitor.new/files .
 
 gwdu60% cvs -d anoncvs@anoncvs.fr.FreeBSD.org:/home/ncvs add files
 ? files/patch-64bit.in
 cvs add: cannot mkdir /home/ncvs/ports/sysutils/rmonitor/files: Permission 
 denied
 
 What can I do here?
 
 Best regards
 Konrad Heuer (kheuer@gwdg.de)
State-Changed-From-To: feedback->closed 
State-Changed-By: itetcu 
State-Changed-When: Fri Feb 20 15:06:28 UTC 2009 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131741 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/131741: commit references a PR
Date: Fri, 20 Feb 2009 15:06:30 +0000 (UTC)

 itetcu      2009-02-20 15:06:15 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/rmonitor    Makefile 
   Added files:
     sysutils/rmonitor/files patch-src__rmonitor.c 
   Log:
   - Fix integer overflow on 64bit platforms
   - bump PORTREVISION
   
   PR:             131741
   Submitted by:   maintainer
   
   Revision  Changes    Path
   1.6       +3 -0      ports/sysutils/rmonitor/Makefile
   1.1       +11 -0     ports/sysutils/rmonitor/files/patch-src__rmonitor.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
