From nobody@FreeBSD.org  Fri Feb 13 15:42:57 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 00876106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 13 Feb 2009 15:42:56 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id E23338FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 13 Feb 2009 15:42:56 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n1DFguMe070590
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 13 Feb 2009 15:42:56 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n1DFguSP070589;
	Fri, 13 Feb 2009 15:42:56 GMT
	(envelope-from nobody)
Message-Id: <200902131542.n1DFguSP070589@www.freebsd.org>
Date: Fri, 13 Feb 2009 15:42:56 GMT
From: "Ben C. O. Grimm" <freebsd@bengrimm.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: rsnapshot exclude statements not properly documented
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         131646
>Category:       ports
>Synopsis:       sysutils/rsnapshot exclude statements not properly documented
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pav
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 13 15:50:00 UTC 2009
>Closed-Date:    Sun Mar 22 21:03:01 UTC 2009
>Last-Modified:  Sun Mar 22 21:03:01 UTC 2009
>Originator:     Ben C. O. Grimm
>Release:        7.1-STABLE
>Organization:
None
>Environment:
FreeBSD hail.bengrimm.net 7.1-STABLE FreeBSD 7.1-STABLE #0: Fri Feb  6 17:12:09 CET 2009     root@hail.bengrimm.net:/usr/obj/usr/src/sys/HAIL  i386

>Description:
The sysutils/rsnapshot port's config file (rsnapshot.conf) has include/exclude statements. The statements are applied to every rsnapshot backup, even when included config files have different include/exclude statements, or have no include/exclude statements at all.

For example:

in rsnapshot.conf:
include         #
exclude         #
include_conf    /usr/local/etc/host1_rsnapshot.conf
include_conf    /usr/local/etc/host2_rsnapshot.conf

in host1_rsnapshot.conf:
exclude         backups*

in host2_rsnapshot.conf:
exclude         docs*

Executing rsnapshot -v will produce, FOR BOTH HOSTS:

/usr/local/bin/rsync -a --delete --numeric-ids --relative --delete-excluded \
    --exclude=backups* --exclude=docs* [etcetera)

Nothing in the man page suggests that this functionality exists when include/exclude statements are used in several included config files. 

I'm aware of the fact that includes/excludes will work correctly when they are passed on the backup line itself, like this:

backup root@example.com:/etc/  example.com/    exclude=mtab,exclude=core
>How-To-Repeat:

>Fix:
I think the man file should make it clear that any include/exclude statements that are not part of a 'backup' line will be used for every single backup in a single rsnapshot run, and will be 'added up' and applied across the board.

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: tabthorpe 
State-Changed-When: Wed Feb 18 17:01:17 UTC 2009 
State-Changed-Why:  
Ask for maintainer fix. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131646 
State-Changed-From-To: feedback->open 
State-Changed-By: pav 
State-Changed-When: Sun Mar 22 20:32:44 UTC 2009 
State-Changed-Why:  
Maintainer feedback timeout 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131646 
State-Changed-From-To: open->feedback 
State-Changed-By: pav 
State-Changed-When: Sun Mar 22 20:34:05 UTC 2009 
State-Changed-Why:  
Is this a problem with FreeBSD port, or a general issue with rsnapshot? 
If it's not FreeBSD specific, you should really go directly to the vendor. 


Responsible-Changed-From-To: freebsd-ports-bugs->pav 
Responsible-Changed-By: pav 
Responsible-Changed-When: Sun Mar 22 20:34:05 UTC 2009 
Responsible-Changed-Why:  
Is this a problem with FreeBSD port, or a general issue with rsnapshot? 
If it's not FreeBSD specific, you should really go directly to the vendor. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131646 

From: "Ben C. O. Grimm" <freebsd@bengrimm.net>
To: bug-followup@FreeBSD.org, freebsd@bengrimm.net
Cc:  
Subject: Re: ports/131646: sysutils/rsnapshot exclude statements not properly
 documented
Date: Sun, 22 Mar 2009 21:46:01 +0100

 Will do. Close if you like.
State-Changed-From-To: feedback->closed 
State-Changed-By: pav 
State-Changed-When: Sun Mar 22 21:02:55 UTC 2009 
State-Changed-Why:  
Closing. Thank you! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131646 
>Unformatted:
