From matthias.andree@uni-paderborn.de  Tue Feb 10 11:23:47 2009
Return-Path: <matthias.andree@uni-paderborn.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 12ED4106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Feb 2009 11:23:47 +0000 (UTC)
	(envelope-from matthias.andree@uni-paderborn.de)
Received: from ponyo.sfc.wide.ad.jp (unknown [IPv6:2001:200:0:8801:2e0:7dff:fe78:410])
	by mx1.freebsd.org (Postfix) with ESMTP id 884FC8FC25
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Feb 2009 11:23:46 +0000 (UTC)
	(envelope-from matthias.andree@uni-paderborn.de)
Received: from ponyo.sfc.wide.ad.jp (localhost [127.0.0.1])
	by ponyo.sfc.wide.ad.jp (8.14.3/8.14.3) with ESMTP id n1ABNepb042954;
	Tue, 10 Feb 2009 20:23:40 +0900 (JST)
	(envelope-from matthias.andree@uni-paderborn.de)
Received: (from mandree@localhost)
	by ponyo.sfc.wide.ad.jp (8.14.3/8.14.3/Submit) id n1ABNdV6042953;
	Tue, 10 Feb 2009 20:23:39 +0900 (JST)
	(envelope-from matthias.andree@uni-paderborn.de)
Message-Id: <200902101123.n1ABNdV6042953@ponyo.sfc.wide.ad.jp>
Date: Tue, 10 Feb 2009 20:23:39 +0900 (JST)
From: Matthias Andree <matthias.andree@gmx.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [MAINTAINER] sysutils/e2fsprogs: default inode size for mke2fs to 128
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         131556
>Category:       ports
>Synopsis:       [MAINTAINER] sysutils/e2fsprogs: default inode size for mke2fs to 128
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 10 11:30:03 UTC 2009
>Closed-Date:    Tue Feb 10 22:36:50 UTC 2009
>Last-Modified:  Tue Feb 10 22:40:01 UTC 2009
>Originator:     Matthias Andree
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD ponyo.sfc.wide.ad.jp 8.0-CURRENT FreeBSD 8.0-CURRENT #7: Tue Feb 10 15:37:31 JST 2009
>Description:
- default inode size for mke2fs to 128
  Inspired by: Wesley Shields
- remove BROKEN; Solaris 8 SPARC64 compiles package just fine
  (I have no access to FreeBSD/sparc64)

Added file(s):
- files/diff-inode_size

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- e2fsprogs-1.41.4_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/sysutils/e2fsprogs/Makefile,v
retrieving revision 1.51
diff -u -r1.51 Makefile
--- Makefile	8 Feb 2009 22:53:32 -0000	1.51
+++ Makefile	10 Feb 2009 11:22:34 -0000
@@ -7,7 +7,7 @@
 
 PORTNAME=	e2fsprogs
 PORTVERSION=	1.41.4
-PORTREVISION?=	0
+PORTREVISION?=	1
 CATEGORIES?=	sysutils
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE_EXTENDED}
 MASTER_SITE_SUBDIR=	${PORTNAME}
@@ -58,10 +58,6 @@
 libintl=	"${LOCALBASE}/lib/libintl.a ${LOCALBASE}/lib/libiconv.a"
 .endif
 
-.if ${ARCH} == "sparc64"
-BROKEN=		Does not compile on sparc64
-.endif
-
 post-patch::
 	@${REINPLACE_CMD} -E -e \
 		's:\$$\(libdir\)/pkgconfig:${PREFIX}/libdata/pkgconfig:' \
@@ -107,6 +103,9 @@
 	@${ECHO_CMD} '===>  Running e2fsprogs self-test suite'
 	cd ${WRKSRC}/tests && ${GMAKE} check \
 	    || { head -n30000 ${WRKSRC}/tests/*.failed 2>/dev/null ; exit 1 ; }
+# Now patch mke2fs.conf to default to 128 byte inodes - we need to do this
+# after self tests since they assume 256 byte inodes.
+	${PATCH} -N -d ${WRKSRC} <${FILESDIR}/diff-inode_size
 
 post-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/fsck_ext2fs ${PREFIX}/sbin/
Index: pkg-message
===================================================================
RCS file: /home/ncvs/ports/sysutils/e2fsprogs/pkg-message,v
retrieving revision 1.3
diff -u -r1.3 pkg-message
--- pkg-message	23 Sep 2008 08:18:45 -0000	1.3
+++ pkg-message	10 Feb 2009 11:22:34 -0000
@@ -1,4 +1,10 @@
 ===========================================================================
+Note: FreeBSD's ext2fs module, as of release 7.1, cannot mount file systems
+with 256-byte large inodes, but only 128 byte. Unfortunately, 256 byte is
+the default size with many recent Linux distributions; so when installing
+Linux, pass '-I 128' to mke2fs. This port uses 128 byte inodes as default.
+However, the inode size cannot be changed after creation.
+---------------------------------------------------------------------------
 Note: this is a modified version of the e2fsprogs package, not the official
 package. Report all building and run-time trouble that originates in the
 package to the port maintainer, <matthias.andree@gmx.de>.
Index: files/diff-inode_size
===================================================================
RCS file: files/diff-inode_size
diff -N files/diff-inode_size
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/diff-inode_size	10 Feb 2009 11:22:34 -0000
@@ -0,0 +1,14 @@
+# do not call this patch-* - we need to apply this after running self-tests!
+# -- Matthias Andree, 2009-02-10
+
+--- ./misc/mke2fs.conf.orig	2009-02-10 18:32:45.000000000 +0900
++++ ./misc/mke2fs.conf	2009-02-10 18:32:52.000000000 +0900
+@@ -1,7 +1,7 @@
+ [defaults]
+ 	base_features = sparse_super,filetype,resize_inode,dir_index,ext_attr
+ 	blocksize = 4096
+-	inode_size = 256
++	inode_size = 128
+ 	inode_ratio = 16384
+ 
+ [fs_types]
--- e2fsprogs-1.41.4_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Tue Feb 10 11:35:16 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131556 

From: "Matthias Andree" <matthias.andree@gmx.de>
To: bug-followup@freebsd.org, "Martin Wilke" <miwi@freebsd.org>
Cc: =?iso-8859-15?Q?Sylvio_C=E9sar_Teixeira_Amorim?= <scjamorim@bsd.com.br>
Subject: Re: ports/131556: [MAINTAINER] sysutils/e2fsprogs: default inode size
 for mke2fs to 128
Date: Tue, 10 Feb 2009 14:58:36 +0100

 Hi Martin,
 
 the pkg-message should instead be (please include the horizontal "lines"):
 (copy & paste should be fine, there are no TABs.)
 
 =============================================================================
 Note: FreeBSD's ext2fs module, as of release 7.1, cannot mount ext2 file
 systems with 256-byte large inodes, only 128 byte sized.  Unfortunately,
 256 byte is the default size with many recent Linux distributions.
 The inode size cannot be changed after creation of a file system either.
 This port overrides the default to 128 bytes, but this only applies to ext2
 file systems created with this particular mke2fs.  If you format ext2 file
 systems with other operating systems, make sure that mke2fs is called with
 "-I 128" for partitions that you plan to share with FreeBSD.
 Remember to backup your data before re-formatting any existing file  
 systems!
 -----------------------------------------------------------------------------
 Note: this is a modified version of the e2fsprogs package, not the official
 package.  Report all building and run-time trouble that originates in the
 package to the port maintainer, <matthias.andree@gmx.de>.
 =============================================================================
 
 -- 
 Matthias Andree
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Tue Feb 10 22:36:49 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131556 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/131556: commit references a PR
Date: Tue, 10 Feb 2009 22:36:50 +0000 (UTC)

 miwi        2009-02-10 22:36:42 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/e2fsprogs   Makefile pkg-message 
   Added files:
     sysutils/e2fsprogs/files diff-inode_size 
   Log:
   - default inode size for mke2fs to 128
     Inspired by: Wesley Shields
   - remove BROKEN; Solaris 8 SPARC64 compiles package just fine
   
   PR:             131556
   Submitted by:   Matthias Andree <matthias.andree@gmx.de> (maintainer)
   
   Revision  Changes    Path
   1.52      +4 -5      ports/sysutils/e2fsprogs/Makefile
   1.1       +14 -0     ports/sysutils/e2fsprogs/files/diff-inode_size (new)
   1.4       +11 -0     ports/sysutils/e2fsprogs/pkg-message
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
