From beyert@cs.ucr.edu  Thu Feb  5 22:15:33 2009
Return-Path: <beyert@cs.ucr.edu>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7DE86106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  5 Feb 2009 22:15:33 +0000 (UTC)
	(envelope-from beyert@cs.ucr.edu)
Received: from sentoku.ucr.edu (sentoku.ucr.edu [138.23.214.80])
	by mx1.freebsd.org (Postfix) with ESMTP id 66AC38FC16
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  5 Feb 2009 22:15:33 +0000 (UTC)
	(envelope-from beyert@cs.ucr.edu)
Received: from aeonserv.aeonnet (cpe-76-90-217-240.socal.res.rr.com [76.90.217.240])
	by sentoku.ucr.edu (MOS 3.10.3-GA)
	with ESMTP id DYP97032 (AUTH tbeye001);
	Thu, 5 Feb 2009 14:05:25 -0800 (PST)
Message-Id: <871vucv8ue.wl%beyert@cs.ucr.edu>
Date: Thu, 05 Feb 2009 14:04:41 -0800
From: Timothy Beyer <beyert@cs.ucr.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Timothy Beyer <beyert@cs.ucr.edu>
Subject: add options to port: math/gnumeric (perl and guile)

>Number:         131436
>Category:       ports
>Synopsis:       add options to port: math/gnumeric (perl and guile)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 05 22:20:01 UTC 2009
>Closed-Date:    Sat Apr 25 20:51:09 UTC 2009
>Last-Modified:  Sat Apr 25 21:00:04 UTC 2009
>Originator:     Timothy Beyer
>Release:        FreeBSD 7.1-RELEASE-p2 i386
>Organization:
no organization
>Environment:
System: FreeBSD aeonserv.aeonnet 7.1-RELEASE-p2 FreeBSD 7.1-RELEASE-p2 #4: Sun Jan 25 21:45:5
3 PST 2009 beyert@aeonserv.aeonnet:/usr/obj/usr/src/sys/CUSTOM i386

>Description:
This patch makes the following changes:

-Add option to turn on/off guile scheme support (might as well enable it though)
-Add option to turn on/off perl support (on my system gnumeric does not compile when perl support is turned on)

The defaults have been unchanged (perl enabled, guile disabled) to avoid disrupting the compilation for users where it was already working properly.

>How-To-Repeat:
    Apply the patch
>Fix:
    The included patch

--- Makefile.diff begins here ---
--- Makefile.orig	2009-02-02 03:37:25.000000000 -0800
+++ Makefile	2009-02-05 14:02:51.000000000 -0800
@@ -8,7 +8,7 @@
 
 PORTNAME=	gnumeric
 PORTVERSION=	1.9.3
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	math gnome
 MASTER_SITES=	GNOME
 DIST_SUBDIR=	gnome2
@@ -21,7 +21,6 @@
 
 USE_BZIP2=	yes
 USE_GETTEXT=	yes
-USE_PERL5=	yes
 USE_GMAKE=	yes
 USE_GNOME=	gnomeprefix intlhack gnomehack gnomehier \
 		libgsf_gnome pygtk2 desktopfileutils libgnomeui
@@ -30,7 +29,7 @@
 USE_LDCONFIG=	yes
 INSTALLS_ICONS=	yes
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS=	--without-guile --with-bonobo
+CONFIGURE_ARGS=	--with-bonobo
 CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include ${PTHREAD_CFLAGS}" \
 		LIBS="-L${LOCALBASE}/lib -liconv ${PTHREAD_LIBS}" \
 		python_prog=${PYTHON_VERSION}
@@ -42,10 +41,25 @@
 
 PLIST_SUB=	VERSION=${PORTVERSION}
 
-OPTIONS=	GNOMEDB "Enable libgnomedb support" off
+OPTIONS=	GNOMEDB "Enable libgnomedb support" off \
+			PERL "Enable Perl as extension language" on \
+			GUILE "Enable Guile as extension language" off
 
 .include <bsd.port.pre.mk>
 
+.if defined(WITH_GUILE)
+LIB_DEPENDS+=	guile.19:${PORTSDIR}/lang/guile
+CONFIGURE_ARGS+=	--with-guile
+.else
+CONFIGURE_ARGS+=	--without-guile
+.endif
+
+.if defined(WITH_PERL)
+USE_PERL5=	yes
+.else
+CONFIGURE_ARGS+=	--without-perl
+.endif
+
 .if defined(WITH_GNOMEDB)
 USE_GNOME+=		libgnomedb
 CONFIGURE_ARGS+=	--with-gda
--- Makefile.diff ends here ---
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Feb 5 22:22:48 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131436 
State-Changed-From-To: open->closed 
State-Changed-By: marcus 
State-Changed-When: Sat Apr 25 20:50:59 UTC 2009 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131436 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/131436: commit references a PR
Date: Sat, 25 Apr 2009 20:51:08 +0000 (UTC)

 marcus      2009-04-25 20:50:54 UTC
 
   FreeBSD ports repository
 
   Modified files:
     math/gnumeric        Makefile pkg-plist 
   Log:
   Make Perl support optional.
   
   PR:             131436
   Submitted by:   Timothy Beyer <beyert@cs.ucr.edu> (based on)
   
   Revision  Changes    Path
   1.150     +11 -3     ports/math/gnumeric/Makefile
   1.76      +7 -7      ports/math/gnumeric/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
