From mad@madpilot.net  Tue Feb  3 22:37:14 2009
Return-Path: <mad@madpilot.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3D8C91065677
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  3 Feb 2009 22:37:14 +0000 (UTC)
	(envelope-from mad@madpilot.net)
Received: from megatron.madpilot.net (megatron.madpilot.net [88.149.173.206])
	by mx1.freebsd.org (Postfix) with ESMTP id DD2F38FC13
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  3 Feb 2009 22:37:13 +0000 (UTC)
	(envelope-from mad@madpilot.net)
Received: by megatron.madpilot.net (Postfix, from userid 1000)
	id F3E3E130C40; Tue,  3 Feb 2009 23:37:11 +0100 (CET)
Message-Id: <20090203223711.F3E3E130C40@megatron.madpilot.net>
Date: Tue,  3 Feb 2009 23:37:11 +0100 (CET)
From: Guido Falsi <mad@madpilot.net>
Reply-To: Guido Falsi <mad@madpilot.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [maintainer-update] fix use of strndup in gnokii
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         131350
>Category:       ports
>Synopsis:       [maintainer-update] fix use of strndup in comms/gnokii
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 03 22:40:00 UTC 2009
>Closed-Date:    Wed Feb 04 07:56:38 UTC 2009
>Last-Modified:  Wed Feb  4 08:00:01 UTC 2009
>Originator:     Guido Falsi
>Release:        FreeBSD 7.1-STABLE i386
>Organization:
none
>Environment:
System: FreeBSD megatron.madpilot.net 7.1-STABLE FreeBSD 7.1-STABLE #14: Sat Jan 24 11:42:24 CET 2009 root@megatron.madpilot.net:/usr/obj/usr/src/sys/MEGATRON i386

>Description:

A function in gnokii happens to use strndup() which is implemented
only in 8.0, so revert it to a simple strdup().

added file:

files/patch-gnokii-gnokii.c

Reported by: ledondo2000 at gmail.com

>How-To-Repeat:

trying to compile gnokii with readline support.

>Fix:

diff -ruN gnokii.old/files/patch-gnokii-gnokii.c gnokii/files/patch-gnokii-gnokii.c
--- gnokii.old/files/patch-gnokii-gnokii.c	1970-01-01 01:00:00.000000000 +0100
+++ gnokii/files/patch-gnokii-gnokii.c	2009-02-03 23:24:44.000000000 +0100
@@ -0,0 +1,11 @@
+--- gnokii/gnokii.c.orig	2009-02-03 23:23:35.000000000 +0100
++++ gnokii/gnokii.c	2009-02-03 23:24:01.000000000 +0100
+@@ -1082,7 +1082,7 @@
+ 			else
+ 				len = strlen(input);
+ 			if (len > 0)
+-				argv[argc++] = strndup(input, len);
++				argv[argc++] = strdup(input);
+ 			input = tmp;
+ 		} while (input);
+ 		argv[argc] = NULL;
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Wed Feb 4 04:02:20 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131350 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Wed Feb 4 07:56:36 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131350 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/131350: commit references a PR
Date: Wed,  4 Feb 2009 07:56:36 +0000 (UTC)

 pgollucci    2009-02-04 07:56:26 UTC
 
   FreeBSD ports repository
 
   Modified files:
     comms/gnokii         Makefile 
   Added files:
     comms/gnokii/files   patch-gnokii-gnokii.c 
   Log:
   - A function in gnokii happens to use strndup() which is implemented
       only in 8.0, so revert it to a simple strdup().
   
   PR:             ports/131350
   Reported by:    ledondo2000 at gmail.com
   Submitted by:   Guido Falsi <mad@madpilot.net>  (maintainer)
   
   Revision  Changes    Path
   1.75      +1 -0      ports/comms/gnokii/Makefile
   1.1       +11 -0     ports/comms/gnokii/files/patch-gnokii-gnokii.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
