From nobody@FreeBSD.org  Sat Jan 31 02:52:26 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 74C271065670
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 31 Jan 2009 02:52:26 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 62DE08FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 31 Jan 2009 02:52:26 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n0V2qQcb042002
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 31 Jan 2009 02:52:26 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n0V2qPjd042001;
	Sat, 31 Jan 2009 02:52:25 GMT
	(envelope-from nobody)
Message-Id: <200901310252.n0V2qPjd042001@www.freebsd.org>
Date: Sat, 31 Jan 2009 02:52:25 GMT
From: "Pedro F. Giffuni" <giffunip@tutopia.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: lang/gcc43: add regression-test target
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         131185
>Category:       ports
>Synopsis:       lang/gcc43: add regression-test target
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gerald
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 31 03:00:17 UTC 2009
>Closed-Date:    Sun Feb 01 15:25:15 UTC 2009
>Last-Modified:  Sun Mar  1 23:30:02 UTC 2009
>Originator:     Pedro F. Giffuni
>Release:        7.1-RELEASE
>Organization:
>Environment:
%uname -a
FreeBSD kakumen.cable.net.co 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan  1 08:58:24 UTC 2009     root@driscoll.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
It now makes sense to have checks to gcc43 done in the package building cluster:

- Fortran ports (114?) now depend on lang/gcc43.
- Since gcc43 is not part of the base system we are doing less checks on these newer versions of gcc by default.

This simple patch adds the "regression-test" target to early detect bugs and have the packages checked on different platforms.
>How-To-Repeat:

>Fix:
diff -ruN gcc43.orig/Makefile gcc43/Makefile
--- gcc43.orig/Makefile	2009-01-30 20:56:32.000000000 -0500
+++ gcc43/Makefile	2009-01-30 21:22:54.000000000 -0500
@@ -25,6 +25,10 @@
 LIB_DEPENDS=	gmp.7:${PORTSDIR}/math/libgmp4 \
 		mpfr.3:${PORTSDIR}/math/mpfr
 
+.if defined(PACKAGE_BUILDING) || defined(MAINTAINER_MODE)
+BUILD_DEPENDS=	runtest:${PORTSDIR}/misc/dejagnu
+.endif
+
 SUFFIX=		43
 LATEST_LINK?=	gcc${SUFFIX}${PKGNAMESUFFIX}
 NOT_FOR_ARCHS=	alpha ia64
@@ -160,7 +164,7 @@
 	@${ECHO_MSG} "if you have not performed this build on -STABLE or -CURRENT."
 	@${ECHO_MSG} "This assumes that you have the dejagnu port installed."
 
-check: build
+regression-test check: build
 	cd ${WRKSRC}; export RUNTESTFLAGS='--target_board ''unix{-pthread}'''; ${GMAKE} -sk check
 
 post-install:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gerald 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Jan 31 03:00:26 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131185 
State-Changed-From-To: open->feedback 
State-Changed-By: gerald 
State-Changed-When: Sun Feb 1 13:21:50 UTC 2009 
State-Changed-Why:  
Sadly, PACKAGE_BUILDING is not described in `man ports` nor anywhere 
in ports/Mk. 

And MAINTAINER_MODE does not even appear in any of these two.                    

Nor does the string regression-test. 

So, while I am in favor of these changes, there is no documentation 
about any of these in the regular ports infrastructure.  Is this 
something you could help with? 

(I'll continue to look into the proposed patch in parallel...) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131185 
State-Changed-From-To: feedback->closed 
State-Changed-By: gerald 
State-Changed-When: Sun Feb 1 15:18:55 UTC 2009 
State-Changed-Why:  
Committed, with some enhancements, thanks for the suggestion! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131185 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/131185: commit references a PR
Date: Sun,  1 Feb 2009 15:24:42 +0000 (UTC)

 gerald      2009-02-01 15:24:32 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/gcc43           Makefile 
   Log:
   Rename target check to regression-test [1], remove the post-build target
   and its note on testing, add a conditional dependency on misc/dejagnu [1]
   and make the inclusion of gcc-testsuite in DISTFILES conditional, too.
   
   PR:             131185
   Submitted by:   Pedro F. Giffuni <giffunip@tutopia.com>
   
   Revision  Changes    Path
   1.374     +7 -8      ports/lang/gcc43/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/131185: commit references a PR
Date: Sun,  1 Mar 2009 23:25:49 +0000 (UTC)

 gerald      2009-03-01 23:25:34 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/gcc43           Makefile 
   Log:
   Rename 131185
   
   Rename the regression-test target to full-regression-test.  The GCC
   testsuite simply is too expensive and has been dragging tinderboxes
   and other testers down.
   
   PR:             131185
   
   Revision  Changes    Path
   1.378     +1 -1      ports/lang/gcc43/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
