From matthias.andree@gmx.de  Tue Jan 27 16:04:19 2009
Return-Path: <matthias.andree@gmx.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E780510656D7
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 27 Jan 2009 16:04:19 +0000 (UTC)
	(envelope-from matthias.andree@gmx.de)
Received: from mail.gmx.net (mail.gmx.net [213.165.64.20])
	by mx1.freebsd.org (Postfix) with SMTP id 1C0CE8FC22
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 27 Jan 2009 16:04:18 +0000 (UTC)
	(envelope-from matthias.andree@gmx.de)
Received: (qmail invoked by alias); 27 Jan 2009 16:04:17 -0000
Received: from g225197042.adsl.alicedsl.de (EHLO m2a2.dyndns.org) [92.225.197.42]
  by mail.gmx.net (mp046) with SMTP; 27 Jan 2009 17:04:17 +0100
Received: by merlin.emma.line.org (Postfix, from userid 1001)
	id 863F7B8B6; Tue, 27 Jan 2009 17:04:14 +0100 (CET)
Message-Id: <20090127160414.863F7B8B6@merlin.emma.line.org>
Date: Tue, 27 Jan 2009 17:04:14 +0100 (CET)
From: Matthias Andree <matthias.andree@gmx.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc: question+fbsdports@closedsrc.org
Subject: [PATCH] mail/getmail: fix excessive log volume
X-Send-Pr-Version: 3.113
X-GNATS-Notify: question+fbsdports@closedsrc.org

>Number:         131047
>Category:       ports
>Synopsis:       [PATCH] mail/getmail: fix excessive log volume
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    amdmi3
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 27 16:10:02 UTC 2009
>Closed-Date:    Wed Jan 28 17:59:02 UTC 2009
>Last-Modified:  Wed Jan 28 18:00:09 UTC 2009
>Originator:     Matthias Andree
>Release:        FreeBSD 7.1-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD merlin.emma.line.org 7.1-RELEASE-p2 FreeBSD 7.1-RELEASE-p2 #2: Wed Jan 14 17:14:29 CET 2009
>Description:
getmail 4.8.3 introduced a logging change that causes excessive (dozens of
megabytes per day) log growth by logging skipped messages in delete-after or
keep configurations.

The patch reverts to old behaviour, while leaving the opportunity for full
logging in verbose mode.

The patch has been submitted to the upstream maintainer as well, but I don't
expect a new getmail release soonish.

Added file(s):
- files/patch-excessive-logs

Port maintainer (question+fbsdports@closedsrc.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- getmail-4.8.4_1.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/mail/getmail/Makefile /usr/home/emma/ports/mail/getmail/Makefile
--- /usr/ports/mail/getmail/Makefile	2008-09-28 07:51:04.000000000 +0200
+++ /usr/home/emma/ports/mail/getmail/Makefile	2009-01-27 16:57:14.000000000 +0100
@@ -7,6 +7,7 @@
 
 PORTNAME=	getmail
 PORTVERSION=	4.8.4
+PORTREVISION=	1
 CATEGORIES=	mail python
 MASTER_SITES=	http://pyropus.ca/software/getmail/%SUBDIR%/ \
 		http://mirrors.closedsrc.org/getmail/
diff -ruN --exclude=CVS /usr/ports/mail/getmail/files/patch-excessive-logs /usr/home/emma/ports/mail/getmail/files/patch-excessive-logs
--- /usr/ports/mail/getmail/files/patch-excessive-logs	1970-01-01 01:00:00.000000000 +0100
+++ /usr/home/emma/ports/mail/getmail/files/patch-excessive-logs	2009-01-27 16:58:46.000000000 +0100
@@ -0,0 +1,17 @@
+--- getmail
++++ getmail
+@@ -210,10 +210,10 @@ def go(configs):
+ 
+                 if (retrieve or delete or oplevel > 1):
+                     log.info('  %s\n' % info)
+-                if options['logfile']:
+-                    options['logfile'].write(logline)
+-                if options['message_log_syslog']:
+-                    syslog.syslog(syslog.LOG_INFO, logline)
++                    if options['logfile']:
++                        options['logfile'].write(logline)
++                    if options['message_log_syslog']:
++                        syslog.syslog(syslog.LOG_INFO, logline)
+ 
+                 if (options['max_messages_per_session']
+                         and msgs_retrieved >=
--- getmail-4.8.4_1.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Jan 27 16:10:13 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131047 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: question+fbsdports@closedsrc.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/131047: [PATCH] mail/getmail: fix excessive log volume
Date: Tue, 27 Jan 2009 16:10:12 UT

 Maintainer of mail/getmail,
 
 Please note that PR ports/131047 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/131047
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Linh Pham <question+fbsdports@closedsrc.org>
To: bug-followup@FreeBSD.org
Cc: edwin@FreeBSD.org
Subject: Re: ports/131047: [PATCH] mail/getmail: fix excessive log volume
Date: Tue, 27 Jan 2009 08:27:33 -0800

 On 2009-01-27 16:10 +0000, Edwin Groothuis <edwin@FreeBSD.org> wrote:
 
 > Maintainer of mail/getmail,
 > 
 > Please note that PR ports/131047 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/131047
 
 Approved.
 
 -- 
 Linh Pham
 question+fbsdports@closedsrc.org
 http://closedsrc.org/
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Tue Jan 27 16:51:11 UTC 2009 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131047 
Responsible-Changed-From-To: freebsd-ports-bugs->amdmi3 
Responsible-Changed-By: amdmi3 
Responsible-Changed-When: Wed Jan 28 15:11:01 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131047 
State-Changed-From-To: open->closed 
State-Changed-By: amdmi3 
State-Changed-When: Wed Jan 28 17:59:01 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131047 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/131047: commit references a PR
Date: Wed, 28 Jan 2009 17:59:07 +0000 (UTC)

 amdmi3      2009-01-28 17:58:53 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/getmail         Makefile 
   Added files:
     mail/getmail/files   patch-excessive-logs 
   Log:
   - Add patch to reduce excess logging
   
   PR:             131047
   Submitted by:   Matthias Andree <matthias dot andree at gmx dot de>
   Approved by:    Linh Pham <question+fbsdports at closedsrc dot org> (maintainer)
   
   Revision  Changes    Path
   1.81      +1 -0      ports/mail/getmail/Makefile
   1.1       +17 -0     ports/mail/getmail/files/patch-excessive-logs (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
