From simon@comsys.ntu-kpi.kiev.ua  Sat Jan 24 13:11:06 2009
Return-Path: <simon@comsys.ntu-kpi.kiev.ua>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5B9D7106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 24 Jan 2009 13:11:06 +0000 (UTC)
	(envelope-from simon@comsys.ntu-kpi.kiev.ua)
Received: from comsys.ntu-kpi.kiev.ua (comsys.ntu-kpi.kiev.ua [77.47.192.42])
	by mx1.freebsd.org (Postfix) with ESMTP id A5AE38FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 24 Jan 2009 13:11:05 +0000 (UTC)
	(envelope-from simon@comsys.ntu-kpi.kiev.ua)
Received: from pm513-1.comsys.ntu-kpi.kiev.ua (pm513-1.comsys.ntu-kpi.kiev.ua [10.18.52.101])
	(authenticated bits=0)
	by comsys.ntu-kpi.kiev.ua (8.13.7/8.13.7) with ESMTP id n0OCtq1X048538
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 24 Jan 2009 14:55:53 +0200 (EET)
Received: by pm513-1.comsys.ntu-kpi.kiev.ua (Postfix, from userid 1001)
	id D4FF01CC44; Sat, 24 Jan 2009 14:51:24 +0200 (EET)
Message-Id: <20090124125124.GA60744@pm513-1.comsys.ntu-kpi.kiev.ua>
Date: Sat, 24 Jan 2009 14:51:24 +0200
From: Andrey Simonenko <simon@comsys.ntu-kpi.kiev.ua>
To: FreeBSD-gnats-submit@freebsd.org
Subject: editors/le does not install all needed files

>Number:         130943
>Category:       ports
>Synopsis:       editors/le does not install all needed files
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    rafan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 24 13:20:01 UTC 2009
>Closed-Date:    Sat Jan 24 16:23:49 UTC 2009
>Last-Modified:  Sat Jan 24 16:30:03 UTC 2009
>Originator:     Andrey Simonenko
>Release:        FreeBSD 7.1-STABLE amd64
>Organization:
>Environment:
>Description:

le-1.14.0 needs share/le/syntax.d directory with files.

Changes:

- Add PORTREVISION

- Add syntax.d do MISC_DATA

- Remove mkdir for DATADIR and .for for all file names from MISC_DATA,
  instead use le/misc/Makefile for installing all needed files.

>How-To-Repeat:

Install editors/le and try to edit .c file, check colors in the editor.

>Fix:
--- Makefile.orig	2009-01-14 14:10:09.000000000 +0200
+++ Makefile	2009-01-24 14:26:51.000000000 +0200
@@ -7,6 +7,7 @@
 
 PORTNAME=	le
 PORTVERSION=	1.14.0
+PORTREVISION=	1
 CATEGORIES=	editors
 MASTER_SITES=	ftp://ftp.yar.ru/pub/source/le/%SUBDIR%/
 MASTER_SITE_SUBDIR=	. old
@@ -23,17 +24,14 @@
 PLIST_FILES=	bin/le
 
 MISC_DATA=	colors-black colors-blue colors-defbg colors-green \
-		colors-white keymap-emacs mainmenu mainmenu-ru syntax
+		colors-white keymap-emacs mainmenu mainmenu-ru syntax syntax.d
 SRC_DATA=	le.hlp
 
 do-install:
 	cd ${WRKSRC}/src && ${INSTALL_PROGRAM} le ${PREFIX}/bin
 	cd ${WRKSRC}/doc && ${INSTALL_MAN} le.1 ${MANPREFIX}/man/man1
 .if !defined(NOPORTDATA)
-	@${MKDIR} ${DATADIR}
-.for file in ${MISC_DATA}
-	cd ${WRKSRC}/misc && ${INSTALL_DATA} ${file} ${DATADIR}
-.endfor
+	cd ${WRKSRC}/misc && ${MAKE} install
 .for file in ${SRC_DATA}
 	cd ${WRKSRC}/src && ${INSTALL_DATA} ${file} ${DATADIR}
 .endfor


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->rafan 
Responsible-Changed-By: rafan 
Responsible-Changed-When: Sat Jan 24 15:52:22 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130943 
State-Changed-From-To: open->closed 
State-Changed-By: rafan 
State-Changed-When: Sat Jan 24 16:23:47 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130943 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/130943: commit references a PR
Date: Sat, 24 Jan 2009 16:23:53 +0000 (UTC)

 rafan       2009-01-24 16:23:39 UTC
 
   FreeBSD ports repository
 
   Modified files:
     editors/le           Makefile 
   Log:
   - This port needs files under DATADIR/syntax.d to do correct syntax highlight.
     Make this happen by using distributor's Makefile to install files.
   - Bump PORTREVISION
   
   PR:             ports/130943
   Submitted by:   Andrey Simonenko <simon at comsys.ntu-kpi.kiev.ua>
   
   Revision  Changes    Path
   1.41      +3 -5      ports/editors/le/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
