From nobody@FreeBSD.org  Tue Jan 20 13:54:21 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 973EA1065746
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 20 Jan 2009 13:54:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 6ABCB8FC17
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 20 Jan 2009 13:54:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n0KDsL9C006393
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 20 Jan 2009 13:54:21 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n0KDsKXO006380;
	Tue, 20 Jan 2009 13:54:20 GMT
	(envelope-from nobody)
Message-Id: <200901201354.n0KDsKXO006380@www.freebsd.org>
Date: Tue, 20 Jan 2009 13:54:20 GMT
From: Alexey Shuvaev <shuvaev@physik.uni-wuerzburg.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] emulators/dosbox enable directserial passthrough
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: knyght@gmail.com

>Number:         130779
>Category:       ports
>Synopsis:       [PATCH] emulators/dosbox enable directserial passthrough
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 20 14:00:02 UTC 2009
>Closed-Date:    Mon Jun 29 11:21:47 UTC 2009
>Last-Modified:  Mon Jun 29 11:21:47 UTC 2009
>Originator:     Alexey Shuvaev
>Release:        8.0-CURRENT
>Organization:
University of Wuerzburg
>Environment:
FreeBSD wep4035 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Wed Jan 14 22:02:23 CET 2009     root@wep4035:/usr/obj/usr/src/sys/NOUSB  amd64
>Description:
Enable POSIX directserial passthrough.

***    Tested (compiling and functioning)    ***
*** only on 8.0-CURRENT systems (i386 amd64) ***

It is better to commit this fix upstream but one should probably check if
other *BSD flavours are working too.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN dosbox.orig/Makefile dosbox/Makefile
--- dosbox.orig/Makefile	2008-08-31 15:28:02.000000000 +0200
+++ dosbox/Makefile	2009-01-20 00:23:33.000000000 +0100
@@ -7,7 +7,7 @@
 
 PORTNAME=	dosbox
 PORTVERSION=	0.72
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	emulators
 MASTER_SITES=	${MASTER_SITE_SOURCEFORGE}
 MASTER_SITE_SUBDIR=	${PORTNAME}
@@ -17,7 +17,7 @@
 
 LIB_DEPENDS=	png.5:${PORTSDIR}/graphics/png
 
-GNU_CONFIGURE=	yes
+USE_AUTOTOOLS=	autoconf:262
 USE_SDL=	sdl net
 
 MAN1=		dosbox.1
diff -ruN dosbox.orig/files/patch-directserial dosbox/files/patch-directserial
--- dosbox.orig/files/patch-directserial	1970-01-01 01:00:00.000000000 +0100
+++ dosbox/files/patch-directserial	2009-01-19 23:52:14.000000000 +0100
@@ -0,0 +1,34 @@
+--- configure.in.orig	2007-08-23 12:24:49.000000000 +0200
++++ configure.in	2009-01-19 23:45:18.000000000 +0100
+@@ -417,7 +417,8 @@
+        dnl directserial detection should be rewritten to test for the needed
+        dnl functions and headers. I currently do not know 
+        dnl which ones are needed for BSD
+-       dnl       AC_DEFINE(C_DIRECTSERIAL, 1, [ Define to 1 if you want serial passthrough support (Win32, Posix and OS/2).])
++       AC_DEFINE(BSD, 1, [Compiling on BSD])
++       AC_DEFINE(C_DIRECTSERIAL, 1, [ Define to 1 if you want serial passthrough support (Win32, Posix and OS/2).])
+        ;;
+     *-*-os2-emx*)
+        AC_DEFINE(OS2, 1, [Compiling on OS/2 EMX])
+--- src/hardware/serialport/directserial_posix.h.orig	2007-08-26 19:19:46.000000000 +0200
++++ src/hardware/serialport/directserial_posix.h	2009-01-19 23:50:34.000000000 +0100
+@@ -25,7 +25,7 @@
+ #include "dosbox.h"
+ 
+ #if C_DIRECTSERIAL
+-#if defined (LINUX) || defined (MACOSX)
++#if defined (LINUX) || defined (MACOSX) || defined (BSD)
+ 
+ 
+ 
+--- src/hardware/serialport/directserial_posix.cpp.orig	2007-08-26 19:19:46.000000000 +0200
++++ src/hardware/serialport/directserial_posix.cpp	2009-01-19 23:50:52.000000000 +0100
+@@ -23,7 +23,7 @@
+ #if C_DIRECTSERIAL
+ 
+ // Posix version
+-#if defined (LINUX) || defined (MACOSX)
++#if defined (LINUX) || defined (MACOSX) || defined (BSD)
+ 
+ #include "serialport.h"
+ #include "directserial_posix.h"


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Jan 20 14:00:17 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130779 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: knyght@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/130779: [PATCH] emulators/dosbox enable directserial passthrough
Date: Tue, 20 Jan 2009 14:00:15 UT

 Maintainer of emulators/dosbox,
 
 Please note that PR ports/130779 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/130779
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Tom Carrick <knyght@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/130779: [PATCH] emulators/dosbox enable directserial 
	passthrough
Date: Tue, 20 Jan 2009 20:47:06 +0000

 --000e0cd28bfc70c36f0460f024e6
 Content-Type: text/plain; charset=UTF-8
 Content-Transfer-Encoding: 7bit
 
 I've brought this up with one of the developers and shown him the patch. He
 says he should be able to get the patch in CVS in time for 0.73, which is on
 track for the end of next month. He just needs testers for OpenBSD and
 NetBSD. I'm not sure there's much reason to change something now just to
 change it back next update (assuming the patch gets in). Apparently this
 only affects a few games, such as Settlers 2, so I don't think it's of high
 importance.
 
 On the other hand, apart from having to revert it later, there shouldn't be
 any negative effects, and there are a few positive ones.
 
 --000e0cd28bfc70c36f0460f024e6
 Content-Type: text/html; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 I&#39;ve brought this up with one of the developers and shown him the patch=
 . He says he should be able to get the patch in CVS in time for 0.73, which=
  is on track for the end of next month. He just needs testers for OpenBSD a=
 nd NetBSD. I&#39;m not sure there&#39;s much reason to change something now=
  just to change it back next update (assuming the patch gets in). Apparentl=
 y this only affects a few games, such as Settlers 2, so I don&#39;t think i=
 t&#39;s of high importance.<br>
 <br>On the other hand, apart from having to revert it later, there shouldn&=
 #39;t be any negative effects, and there are a few positive ones.<br>
 
 --000e0cd28bfc70c36f0460f024e6--
State-Changed-From-To: feedback->patched 
State-Changed-By: amdmi3 
State-Changed-When: Tue Mar 17 20:40:58 UTC 2009 
State-Changed-Why:  
The patch was added to dosbox CVS (7 weeks ago actually), the PR may be 
closed when dosbox 0.93 is released and the port updated. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130779 
State-Changed-From-To: patched->closed 
State-Changed-By: makc 
State-Changed-When: Mon Jun 29 11:21:46 UTC 2009 
State-Changed-Why:  
ports/135277 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130779 
>Unformatted:
