From nobody@FreeBSD.org  Sun Jan 18 02:53:08 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0A2D21065676
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 18 Jan 2009 02:53:08 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id D1E3C8FC1C
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 18 Jan 2009 02:53:07 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n0I2r7BX038045
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 18 Jan 2009 02:53:07 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n0I2r7A4038044;
	Sun, 18 Jan 2009 02:53:07 GMT
	(envelope-from nobody)
Message-Id: <200901180253.n0I2r7A4038044@www.freebsd.org>
Date: Sun, 18 Jan 2009 02:53:07 GMT
From: Cristiano Rolim Pereira <cristianorolim@hotmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] - update sysutils/phplogcon
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         130673
>Category:       ports
>Synopsis:       [patch] - update sysutils/phplogcon
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jadawin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 18 03:00:08 UTC 2009
>Closed-Date:    Wed Jan 21 15:18:14 UTC 2009
>Last-Modified:  Wed Jan 21 15:20:03 UTC 2009
>Originator:     Cristiano Rolim Pereira
>Release:        7.1-RELEASE
>Organization:
>Environment:
FreeBSD bsd64.local 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan  1 08:58:24 UTC 2009     root@driscoll.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
-Added necessary PHP dependencies:
    session
    gd
    xml
    pdo

-Added PHP version check
-Included pkg-message
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN ../phplogcon.ori/Makefile ./Makefile
--- ../phplogcon.ori/Makefile	2008-12-28 09:42:28.000000000 -0200
+++ ./Makefile	2009-01-17 18:41:54.000000000 -0200
@@ -7,6 +7,7 @@
 
 PORTNAME=	phplogcon
 PORTVERSION=	2.5.23
+PORTREVISION=	1
 CATEGORIES=	sysutils www
 MASTER_SITES=	http://download.adiscon.com/phplogcon/
 
@@ -14,8 +15,10 @@
 COMMENT=	Web Based Syslog Review
 
 .if !defined(WITHOUT_PHP_DEPENDS)
-USE_PHP=	YES
+USE_PHP=	session pdo gd xml
 WANT_PHP_WEB=	YES
+IGNORE_WITH_PHP=4
+DEFAULT_PHP_VER=5
 .endif
 NO_BUILD=	YES
 LOGCONDIR?=	www/phplogcon
@@ -41,4 +44,6 @@
 	${INSTALL_SCRIPT} ${WRKSRC}/contrib/* ${DATADIR}
 .endif
 
+	@${CAT} ${PKGMESSAGE}
+
 .include <bsd.port.post.mk>
diff -ruN ../phplogcon.ori/pkg-message ./pkg-message
--- ../phplogcon.ori/pkg-message	1969-12-31 21:00:00.000000000 -0300
+++ ./pkg-message	2009-01-17 18:35:43.000000000 -0200
@@ -0,0 +1,17 @@
+==========================================================================
+Additional notes:
+
+1. If you want access MySQL databases with built in php functions, install
+the port:
+	databases/php5-mysql
+
+2. If you want access some database via PDO, consider installing one of
+the following ports:
+	databases/php5-pdo_dblib
+	databases/php5-pdo_firebird
+	databases/php5-pdo_mysql
+	databases/php5-pdo_oci
+	databases/php5-pdo_odbc
+	databases/php5-pdo_pgsql
+	databases/php5-pdo_sqlite
+==========================================================================


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jadawin 
Responsible-Changed-By: jadawin 
Responsible-Changed-When: Mon Jan 19 16:02:21 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130673 
State-Changed-From-To: open->feedback 
State-Changed-By: jadawin 
State-Changed-When: Mon Jan 19 16:02:34 UTC 2009 
State-Changed-Why:  
Why don't using OPTIONS for additional php function instead pkg-message? 


http://www.freebsd.org/cgi/query-pr.cgi?pr=130673 

From: "Cristiano Rolim" <cristianorolim@hotmail.com>
To: <bug-followup@FreeBSD.org>,
	<cristianorolim@hotmail.com>
Cc:  
Subject: Re: ports/130673: [patch] - update sysutils/phplogcon
Date: Mon, 19 Jan 2009 18:03:58 -0200

 This patch replaces the previous pkg-message with OPTIONS in the Makefile:
 
 diff -ruN ../phplogcon.ori/Makefile ./Makefile
 --- ../phplogcon.ori/Makefile	2008-12-28 09:42:28.000000000 -0200
 +++ ./Makefile	2009-01-19 15:37:56.000000000 -0200
 @@ -7,6 +7,7 @@
 
  PORTNAME=	phplogcon
  PORTVERSION=	2.5.23
 +PORTREVISION=	1
  CATEGORIES=	sysutils www
  MASTER_SITES=	http://download.adiscon.com/phplogcon/
 
 @@ -14,8 +15,10 @@
  COMMENT=	Web Based Syslog Review
 
  .if !defined(WITHOUT_PHP_DEPENDS)
 -USE_PHP=	YES
 +USE_PHP=	session pdo gd xml
  WANT_PHP_WEB=	YES
 +IGNORE_WITH_PHP=4
 +DEFAULT_PHP_VER=5
  .endif
  NO_BUILD=	YES
  LOGCONDIR?=	www/phplogcon
 @@ -25,8 +28,51 @@
  	@${ECHO_CMD} "# you can customize the installation directory"
  	@${ECHO_CMD} "# by setting LOGCON in /etc/make.conf"
 
 +OPTIONS=	PHP_MYSQL "MySQL database support (PHP extension)" Off \
 +		PDO_DBLIB "Microsoft SQL Server and Sybase PDO driver" Off \
 +		PDO_FIREBIRD "Firebird/Interbase PDO driver" Off \
 +		PDO_MYSQL "MySQL Server PDO driver" Off \
 +		PDO_OCI "Oracle PDO driver (i386 onnly)" Off \
 +		PDO_ODBC "ODBC and DB2 PDO driver" Off \
 +		PDO_PGSQL "PostgreSQL PDO driver" Off \
 +		PDO_SQLITE "SQLite PDO driver" Off
 +
  .include <bsd.port.pre.mk>
 
 +.if !defined(WITHOUT_PHP_DEPENDS)
 +.if defined(WITH_PHP_MYSQL)
 +USE_PHP+=	mysql
 +.endif
 +
 +.if defined(WITH_PDO_DBLIB)
 +RUN_DEPENDS+=${PHPBASE}/lib/php/${PHP_EXT_DIR}/pdo_dblib.so:${PORTSDIR}/databases/php5-pdo_dblib+.endif
 +
 +.if defined(WITH_PDO_FIREBIRD)
 +RUN_DEPENDS+=${PHPBASE}/lib/php/${PHP_EXT_DIR}/pdo_firebird.so:${PORTSDIR}/databases/php5-pdo_firebird+.endif
 +
 +.if defined(WITH_PDO_MYSQL)
 +USE_PHP+=	pdo_mysql
 +.endif
 +
 +.if defined(WITH_PDO_OCI) && ${ARCH} == "i386"
 +RUN_DEPENDS+=${PHPBASE}/lib/php/${PHP_EXT_DIR}/pdo_oci.so:${PORTSDIR}/databases/php5-pdo_oci+.endif
 +
 +.if defined(WITH_PDO_ODBC)
 +RUN_DEPENDS+=${PHPBASE}/lib/php/${PHP_EXT_DIR}/pdo_odbc.so:${PORTSDIR}/databases/php5-pdo_odbc+.endif
 +
 +.if defined(WITH_PDO_PGSQL)
 +RUN_DEPENDS+=${PHPBASE}/lib/php/${PHP_EXT_DIR}/pdo_pgsql.so:${PORTSDIR}/databases/php5-pdo_pgsql+.endif
 +
 +.if defined(WITH_PDO_SQLITE)
 +USE_PHP+=	pdo_sqlite
 +.endif
 +.endif
 +
  do-install:
  	${MKDIR} ${PREFIX}/${LOGCONDIR}
  	${CP} -Rp ${WRKSRC}/src/ ${PREFIX}/${LOGCONDIR}/
 
State-Changed-From-To: feedback->closed 
State-Changed-By: jadawin 
State-Changed-When: Wed Jan 21 15:18:12 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130673 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/130673: commit references a PR
Date: Wed, 21 Jan 2009 15:17:37 +0000 (UTC)

 jadawin     2009-01-21 15:17:21 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/phplogcon   Makefile 
   Log:
   - Add PHP dependencies
   - Add OPTIONS
   - Bump PORTREVISION
   
   PR:             ports/130673
   Submitted by:   Cristiano Rolim Pereira <cristianorolim _AT_ hotmail _DOT_ com> (maintainer)
   
   Revision  Changes    Path
   1.2       +49 -4     ports/sysutils/phplogcon/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
