From ben@morrow.me.uk  Sat Jan 17 23:21:54 2009
Return-Path: <ben@morrow.me.uk>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4D2F1106573B
	for <freebsd-gnats-submit@freebsd.org>; Sat, 17 Jan 2009 23:21:54 +0000 (UTC)
	(envelope-from ben@morrow.me.uk)
Received: from plesk-mail01.plus.net (plesk-mail01.plus.net [212.56.83.229])
	by mx1.freebsd.org (Postfix) with ESMTP id AD91A8FC1E
	for <freebsd-gnats-submit@freebsd.org>; Sat, 17 Jan 2009 23:21:53 +0000 (UTC)
	(envelope-from ben@morrow.me.uk)
Received: (qmail 29307 invoked from network); 17 Jan 2009 22:55:11 +0000
Received: from host81-141-107-54.wlms-broadband.com (HELO osiris.mauzo.dyndns.org) (81.141.107.54)
  by plesk-mail01.plus.net with SMTP; 17 Jan 2009 22:55:00 +0000
Received: (qmail 14670 invoked by uid 1001); 17 Jan 2009 22:54:45 -0000
Message-Id: <20090117225445.14669.qmail@osiris.mauzo.dyndns.org>
Date: 17 Jan 2009 22:54:45 -0000
From: Ben Morrow <ben@morrow.me.uk>
Reply-To: Ben Morrow <ben@morrow.me.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] x11/roxterm: install manpages
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         130664
>Category:       ports
>Synopsis:       [PATCH] x11/roxterm: install manpages
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 17 23:30:01 UTC 2009
>Closed-Date:    Tue Feb 03 09:51:16 UTC 2009
>Last-Modified:  Tue Feb 03 09:51:16 UTC 2009
>Originator:     Ben Morrow <ben@morrow.me.uk>
>Release:        FreeBSD 7.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD osiris.mauzo.dyndns.org 7.1-RELEASE FreeBSD 7.1-RELEASE #1: Thu Jan 8 20:32:44 GMT 2009 root@osiris.mauzo.dyndns.org:/usr/obj/usr/src/sys/OSIRIS i386
>Description:
The ROXTerm port does not currently install the manpages, but it would
be useful to do so. There is also a bug in the configure script that
needs patching before they can be generated.

I'm not sure whether it's correct to only install manpages when
!NOPORTDOCS: is this option for all documentation, or just for extra
docs in HTML and such?
>How-To-Repeat:
Install x11/roxterm. No manpages are installed.
>Fix:

--- roxterm-man.patch begins here ---
diff -Nur roxterm-orig/Makefile roxterm/Makefile
--- roxterm-orig/Makefile	2009-01-17 22:27:26.000000000 +0000
+++ roxterm/Makefile	2009-01-17 22:20:12.000000000 +0000
@@ -20,6 +20,14 @@
 GNU_CONFIGURE=	yes
 
 .if !defined(NOPORTDOCS)
+XSL_DIR=	${LOCALBASE}/share/xsl/docbook
+
+BUILD_DEPENDS=	${XSL_DIR}:${PORTSDIR}/textproc/docbook-xsl \
+		xsltproc:$(PORTSDIR}/textproc/libxslt
+
+CONFIGURE_ARGS+=    --with-docbook-man-xsl=${XSL_DIR}/manpages/docbook.xsl
+MAN1=		roxterm.1 roxterm-config.1
+
 INSTALL_TARGET+=install install-doc-local
 .endif
 
diff -Nur roxterm-orig/files/patch-configure roxterm/files/patch-configure
--- roxterm-orig/files/patch-configure	1970-01-01 01:00:00.000000000 +0100
+++ roxterm/files/patch-configure	2009-01-17 22:20:12.000000000 +0000
@@ -0,0 +1,11 @@
+--- configure	2009-01-17 21:39:24.000000000 +0000
++++ configure	2009-01-17 21:39:41.000000000 +0000
+@@ -20208,7 +20208,7 @@
+ 
+ # Check whether --with-docbook-man-xsl was given.
+ if test "${with_docbook_man_xsl+set}" = set; then
+-  withval=$with_docbook_man_xsl; if test "x$withval" != "x" -a test -f "$withval"
++  withval=$with_docbook_man_xsl; if test "x$withval" != "x" -a -f "$withval"
+ 	then
+ 		DOCBOOK_XSL="$withval"
+ 	else
--- roxterm-man.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Jan 17 23:30:12 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130664 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Tue Feb 3 09:51:15 UTC 2009 
State-Changed-Why:  
fixed in upstream and will be included with next upstream update. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130664 
>Unformatted:
