From bsam@bb.ipt.ru  Fri Jan 16 09:38:17 2009
Return-Path: <bsam@bb.ipt.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DC86310656DD
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 16 Jan 2009 09:38:17 +0000 (UTC)
	(envelope-from bsam@bb.ipt.ru)
Received: from bb.ipt.ru (bb.ipt.ru [194.62.233.89])
	by mx1.freebsd.org (Postfix) with ESMTP id 45A3E8FC1D
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 16 Jan 2009 09:38:16 +0000 (UTC)
	(envelope-from bsam@bb.ipt.ru)
Received: from bb.ipt.ru (localhost [127.0.0.1])
	by bb.ipt.ru (8.14.3/8.14.3) with ESMTP id n0G9cH8N068727
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 16 Jan 2009 12:38:17 +0300 (MSK)
	(envelope-from bsam@bb.ipt.ru)
Received: (from bsam@localhost)
	by bb.ipt.ru (8.14.3/8.14.3/Submit) id n0G9cHaK068632;
	Fri, 16 Jan 2009 12:38:17 +0300 (MSK)
	(envelope-from bsam)
Message-Id: <200901160938.n0G9cHaK068632@bb.ipt.ru>
Date: Fri, 16 Jan 2009 12:38:17 +0300 (MSK)
From: Boris Samorodov <bsam@freebsd.org>
Reply-To: Boris Samorodov <bsam@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] lang/fpc-units: build all packages by default
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         130613
>Category:       ports
>Synopsis:       [patch] lang/fpc-units: build all packages by default
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    acm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 16 09:40:00 UTC 2009
>Closed-Date:    Fri Jan 16 12:44:48 UTC 2009
>Last-Modified:  Fri Jan 16 12:50:02 UTC 2009
>Originator:     Boris Samorodov
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
InPharmTech, Co.
>Environment:
System: FreeBSD bb.ipt.ru 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Mon Jan 12 22:04:34 MSK 2009 bsam@bb.ipt.ru:/usr/obj/usr/src/sys/BB i386

>Description:
	1. The logic at lang/fpc-units/Makefile seems to be faulted: all options
	are "on" by default, but when no options file exists (i.e. for automatic
	batch building) none of packages are build.
	2. The unit numlib should be defined at _FPC_ALL_UNITS (ports/Mk/bsd.fpc.mk).
>How-To-Repeat:
	-----
	% cd /usr/ports/lang/fpc-units
	% ls -l `make -V OPTIONSFILE`
	-rw-r--r--  1 root  wheel  943 16 ### 12:06 /var/db/ports/fpc-units/options
	bb% make -V UNITS_SELECTED
	 aspell bfd cairo chm fftw fpmkunit fpgtk fv gdbm ggi gtk2 imagemagick imlib libcurl libgd libpng ncurses numlib opengl openssl pcap pxlib sdl svgalib symbolic syslog tcl unzip users utmp x11 xforms zlib
	bb% sudo rm `make -V OPTIONSFILE`
	bb% make -V UNITS_SELECTED
	
	bb%
	-----
>Fix:
	% cd /usr/ports
	% patch -p0 < _the_following_patch_

--- ports.diff begins here ---
Index: Mk/bsd.fpc.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.fpc.mk,v
retrieving revision 1.4
diff -u -r1.4 bsd.fpc.mk
--- Mk/bsd.fpc.mk	14 Jan 2009 15:58:10 -0000	1.4
+++ Mk/bsd.fpc.mk	16 Jan 2009 09:24:05 -0000
@@ -58,7 +58,7 @@
 _FPC_ALL_UNITS=	aspell bfd cairo chm fcl-async fcl-base fcl-db fcl-fpcunit fcl-image \
 		fcl-json fcl-net fcl-passrc fcl-process fcl-registry fcl-web fcl-xml fftw \
 		fpmkunit fpgtk fv gdbint gdbm ggi gnome1 graph gtk1 gtk2 hash httpd \
-		ibase imagemagick imlib libcurl libgd libpng mysql ncurses \
+		ibase imagemagick imlib libcurl libgd libpng mysql ncurses numlib \
 		odbc opengl openssl oracle pasjpeg paszlib pcap postgres pthreads pxlib \
 		regexpr sdl sqlite svgalib symbolic syslog tcl unzip users utmp x11 xforms \
 		zlib
Index: lang/fpc-units/Makefile
===================================================================
RCS file: /home/pcvs/ports/lang/fpc-units/Makefile,v
retrieving revision 1.12
diff -u -r1.12 Makefile
--- lang/fpc-units/Makefile	14 Jan 2009 06:12:13 -0000	1.12
+++ lang/fpc-units/Makefile	16 Jan 2009 09:24:05 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	units
 PORTVERSION=	2.2.2
+PORTREVISION=	1
 CATEGORIES=	lang
 MASTER_SITES=	# none
 PKGNAMEPREFIX=	fpc-
@@ -85,7 +86,7 @@
 
 UNITS_SELECTED=		#
 .for OPT in ${ALL_OPTIONS}
-.	if defined(WITH_${OPT})  && !defined(WITHOUT_${OPT})
+.	if defined(WITH_${OPT})  || !defined(WITHOUT_${OPT})
 UNITS_SELECTED+=	${OPT:L}
 .	endif
 .endfor
--- ports.diff ends here ---

WBR
-- 
bsam
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->acm 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jan 16 09:40:14 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130613 
State-Changed-From-To: open->closed 
State-Changed-By: acm 
State-Changed-When: Fri Jan 16 12:44:36 UTC 2009 
State-Changed-Why:  
Committed thanks :) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=130613 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/130613: commit references a PR
Date: Fri, 16 Jan 2009 12:41:59 +0000 (UTC)

 acm         2009-01-16 12:41:45 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/fpc-units       Makefile 
   Log:
   - Fix the logic with the options selected
   - Bump PORTREVISION
   
   PR:             130613
   Submitted by:   bsam
   
   Revision  Changes    Path
   1.13      +2 -1      ports/lang/fpc-units/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/130613: commit references a PR
Date: Fri, 16 Jan 2009 12:45:06 +0000 (UTC)

 acm         2009-01-16 12:44:23 UTC
 
   FreeBSD ports repository
 
   Modified files:
     Mk                   bsd.fpc.mk 
   Log:
   - Add numlib unit to _FPC_ALL_UNITS.
   
   PR:             130613
   Submitted by:   bsam
   
   Revision  Changes    Path
   1.5       +2 -2      ports/Mk/bsd.fpc.mk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
