From keramida@freebsd.org  Mon Dec 22 18:57:14 2008
Return-Path: <keramida@freebsd.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AE0EC1065670
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Dec 2008 18:57:14 +0000 (UTC)
	(envelope-from keramida@freebsd.org)
Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36])
	by mx1.freebsd.org (Postfix) with ESMTP id 0625B8FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Dec 2008 18:57:13 +0000 (UTC)
	(envelope-from keramida@freebsd.org)
Received: from kobe.laptop (adsl28-172.kln.forthnet.gr [77.49.155.172])
	(authenticated bits=128)
	by igloo.linux.gr (8.14.3/8.14.3/Debian-5) with ESMTP id mBMIe5oe008972
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT)
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Dec 2008 20:40:15 +0200
Received: from kobe.laptop (kobe.laptop [127.0.0.1])
	by kobe.laptop (8.14.3/8.14.3) with ESMTP id mBMIe4C4049220
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 Dec 2008 20:40:04 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Received: (from keramida@localhost)
	by kobe.laptop (8.14.3/8.14.3/Submit) id mBMIe4Ul049219;
	Mon, 22 Dec 2008 20:40:04 +0200 (EET)
	(envelope-from keramida@freebsd.org)
Message-Id: <87vdtcm4u3.fsf@kobe.laptop>
Date: Mon, 22 Dec 2008 20:40:04 +0200
From: Giorgos Keramidas <keramida@freebsd.org>
Reply-To: Giorgos Keramidas <keramida@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [PATCH] editors/emacs-devel needs gettext to link correctly
X-Send-Pr-Version: 3.113
X-GNATS-Notify: keramida@ceid.upatras.gr keramida

>Number:         129864
>Category:       ports
>Synopsis:       editors/emacs-devel fails to build when gettext
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    stefan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 22 19:00:07 UTC 2008
>Closed-Date:    Thu Jan 08 12:42:44 UTC 2009
>Last-Modified:  Thu Jan  8 12:50:02 UTC 2009
>Originator:     Giorgos Keramidas
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
<organization of PR author (multiple lines)>
>Environment:
System: FreeBSD kobe 8.0-CURRENT FreeBSD 8.0-CURRENT #0: \
Sat Dec 20 17:54:13 EET 2008 build@kobe:/usr/obj/usr/src/sys/KOBE i386

>Description:

editors/emacs-devel fails to build when gettext is not already
installed from the Ports.  It seems that devel/m17n-lib needs
gettext, but emacs-devel does not link with gettext right now.

The build of editors/emacs-devel fails when gettext is missing with a
link error:

/usr/local/lib/libm17n-core.so: undefined reference to `libintl_bindtextdomain'
/usr/local/lib/libm17n-core.so: undefined reference to `libintl_bind_textdomain_codeset'
gmake[2]: *** [temacs] Error 1

Clemens Fischer (ino-qc at spotteswoode dot de dot eu dot org) first
reported this, and helped me test a patch that pulls in gettext.

Attached below is the patch Clemens has tested...

>How-To-Repeat:

Try building editors/emacs-devel on a system that does not have
gettext already.

>Fix:

----- cut here ----- 8< ----- cut here ----- 8< ----- cut here ----- 8< -----
--- Makefile.orig	2008-12-22 19:32:56.000000000 +0200
+++ Makefile	2008-12-22 19:33:02.000000000 +0200
@@ -57,6 +57,11 @@
 LIB_DEPENDS+=		freetype.9:${PORTSDIR}/print/freetype2 \
 			m17n.3:${PORTSDIR}/devel/m17n-lib
 # also libotf, which is pulled in by m17n
+
+# m17n depends on libintl.so too
+CONFIGURE_ENV+= CPPFLAGS="-I${LOCALBASE}/include" \
+		LDFLAGS="-L${LOCALBASE}/lib -lintl"
+USE_GETTEXT=	yes
 .endif
 
 .if defined(WITHOUT_XIM)
----- cut here ----- 8< ----- cut here ----- 8< ----- cut here ----- 8< -----
>Release-Note:
>Audit-Trail:
Class-Changed-From-To: maintainer-update->change-request 
Class-Changed-By: edwin 
Class-Changed-When: Tue Dec 23 20:56:17 UTC 2008 
Class-Changed-Why:  
Fix category (submitter is not maintainer) (via the GNATS Auto Assign 
Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=129864 
Responsible-Changed-From-To: freebsd-ports-bugs->keramida 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Dec 23 20:56:22 UTC 2008 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=129864 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Dec 23 20:56:27 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=129864 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: keramida@ceid.upatras.gr
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/129864: editors/emacs-devel fails to build when gettext
Date: Tue, 23 Dec 2008 20:56:24 UT

 Maintainer of editors/emacs-devel,
 
 Please note that PR ports/129864 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/129864
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: keramida->freebsd-ports-bugs 
Responsible-Changed-By: keramida 
Responsible-Changed-When: Tue Dec 23 22:24:23 UTC 2008 
Responsible-Changed-Why:  
Undo auto-assign script and put back into the ports-bugs pool; 
maintainer is not a ports committer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=129864 
Responsible-Changed-From-To: freebsd-ports-bugs->stefan 
Responsible-Changed-By: stefan 
Responsible-Changed-When: Wed Jan 7 21:29:15 UTC 2009 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=129864 
State-Changed-From-To: feedback->closed 
State-Changed-By: stefan 
State-Changed-When: Thu Jan 8 12:42:16 UTC 2009 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=129864 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/129864: commit references a PR
Date: Thu,  8 Jan 2009 12:42:14 +0000 (UTC)

 stefan      2009-01-08 12:42:03 UTC
 
   FreeBSD ports repository
 
   Modified files:
     editors/emacs-devel  Makefile 
   Log:
   Add explicit dependency on gettext.
   
   PR:             129864
   Submitted by:   keramida (maintainer)
   
   Revision  Changes    Path
   1.24      +6 -1      ports/editors/emacs-devel/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
