From nobody@FreeBSD.org  Sun Nov 16 20:28:00 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 34627106568F
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 16 Nov 2008 20:28:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 275338FC1F
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 16 Nov 2008 20:28:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id mAGKRxJL033041
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 16 Nov 2008 20:27:59 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id mAGKRxgN033040;
	Sun, 16 Nov 2008 20:27:59 GMT
	(envelope-from nobody)
Message-Id: <200811162027.mAGKRxgN033040@www.freebsd.org>
Date: Sun, 16 Nov 2008 20:27:59 GMT
From: Tom Russo <russo@bogodyn.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Wine version 1.1.8,1 gives "Invalide address" for any windows binary
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         128926
>Category:       ports
>Synopsis:       emulators/wine: Wine version 1.1.8,1 gives "Invalid address" for many windows binaries
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gerald
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 16 20:30:02 UTC 2008
>Closed-Date:    Sat Dec 13 10:14:59 UTC 2008
>Last-Modified:  Sat Dec 13 10:50:02 UTC 2008
>Originator:     Tom Russo
>Release:        6.3-STABLE last built Feb 8  2008
>Organization:
>Environment:
FreeBSD bogodyn.org 6.3-STABLE FreeBSD 6.3-STABLE #0: Fri Feb  8 21:03:49 MST 2008     russo@bogodyn.org:/users2/obj/usr/src/sys/BOGODYN  i386

>Description:
Ever since upgrade to port version 1.1.8,1, I am unable to run any of the windows binaries that I had been using regularly until the upgrade.  They all now fail immediately with the following error message:

wine: could not load L"<path to program>": Invalid address

This is for every single .exe file I've tried to run, every one of which worked flawlessly before the upgrade.  The last working version was 1.1.7,1

>How-To-Repeat:
Install wine 1.1.8,1 from ports (source install) and attempt to run a .exe file.

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gerald 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Nov 16 23:10:03 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128926 

From: Chris Paget <ivegotta@tombom.co.uk>
To: bug-followup@FreeBSD.org, russo@bogodyn.org, gerald@freebsd.org
Cc:  
Subject: Re: ports/128926: emulators/wine: Wine version 1.1.8,1 gives "Invalide
 address" for any windows binary
Date: Sat, 22 Nov 2008 00:56:54 -0800

 Same behaviour here:
 FreeBSD diddums.tombom.co.uk 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb
 24 19:59:52 UTC 2008
 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
 
 Downgrading to 0.9.48 from pkg_add -r wine immediately fixes the problem.
State-Changed-From-To: open->closed 
State-Changed-By: gerald 
State-Changed-When: Sun Nov 23 20:47:09 UTC 2008 
State-Changed-Why:  
Thanks for the report.  This did affect a number of users and applications, 
but not all, so I'm adjusting the summary. 

I have an update for emulators/wine that I'll commit in a minute that does 
work for me, both testing 16-bit and 32-bit Windows application.  I hope 
that also resolves the issue for you. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128926 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/128926: commit references a PR
Date: Sun, 23 Nov 2008 20:53:23 +0000 (UTC)

 gerald      2008-11-23 20:53:10 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/wine       Makefile distinfo pkg-plist 
   Log:
   Update to Wine 1.1.9.  Among others, this includes the following changes:
    - A large number of regression test fixes.
    - Performance improvements in memory management.
    - Improved POP3 support in inetcomm.
    - Initial implementation of the XInput DLL.
    - Various bug fixes.
   
   It also fixes the "Invalid address" issue reported by some users, at least
   according to my testing.
   
   PR:             128926
   
   Revision  Changes    Path
   1.277     +1 -1      ports/emulators/wine/Makefile
   1.169     +3 -3      ports/emulators/wine/distinfo
   1.141     +7 -1      ports/emulators/wine/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: Heath Nielson <heathn@gmail.com>
To: bug-followup@FreeBSD.org, russo@bogodyn.org
Cc:  
Subject: Re: ports/128926: emulators/wine: Wine version 1.1.8,1 gives
	"Invalid address" for many windows binaries
Date: Mon, 24 Nov 2008 18:26:26 -0700

 I still get the the "Invalid address" for Quicken 2003.  When I back the
 revision down to 1.1.7, everything works.  This issue appears to a
 similar to an issue in Wine's bugzilla
 (http://bugs.winehq.org/show_bug.cgi?id=16023).
 
State-Changed-From-To: closed->open 
State-Changed-By: gerald 
State-Changed-When: Tue Nov 25 21:39:53 UTC 2008 
State-Changed-Why:  
Sadly, there have been reports of some Win32 binaries still not working, 
thus reopening this. 

On the positive side, Alex Kozlov <spam@rm-rf.kiev.ua> has proposed a 
patch which is reported to address this: 

http://lists.freebsd.org/pipermail/freebsd-emulation/2008-November/005537.html  
I won't be able to commit today, but will be happy to receive any tests 
results. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128926 

From: Uwe Laverenz <uwe@laverenz.de>
To: bug-followup@FreeBSD.org, russo@bogodyn.org
Cc:  
Subject: Re: ports/128926: emulators/wine: Wine version 1.1.8,1 gives "Invalid address" for many windows binaries
Date: Sat, 29 Nov 2008 14:17:39 +0100

 Hi,
 
 I justed wanted to confirm that the problem still exists with
 wine-1.1.9_1,1 on RELENG_7 and that the patch from Alex Kozlov fixes it.
 
 The Windows binary I used for testing was "Firefox Setup 3.0.4.exe".
 
 bye,
 Uwe
 

From: Tijl Coosemans <tijl@ulyssis.org>
To: bug-followup@freebsd.org, russo@bogodyn.org
Cc: Alex Kozlov <spam@rm-rf.kiev.ua>, Gerald Pfeifer <gerald@pfeifer.com>,
        Daichi GOTO <daichi@ongs.co.jp>
Subject: Re: ports/128926: emulators/wine: Wine version 1.1.8,1 gives "Invalid address" for many windows binaries
Date: Sun, 7 Dec 2008 17:45:50 +0100

 --Boundary-00=_/2/OJvQE0Z5eJL4
 Content-Type: text/plain;
   charset="us-ascii"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Here's a patch for the port.
 
 Original patch by Alex Kozlov, with small modifications.
 
 --Boundary-00=_/2/OJvQE0Z5eJL4
 Content-Type: text/plain;
   charset="us-ascii";
   name="wine.update"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename="wine.update"
 
 diff -urN wine.orig/Makefile wine/Makefile
 --- wine.orig/Makefile	2008-12-07 17:38:37.000000000 +0100
 +++ wine/Makefile	2008-12-07 17:39:01.000000000 +0100
 @@ -8,7 +8,7 @@
  
  PORTNAME=	wine
  DISTVERSION=	1.1.9
 -PORTREVISION=	1
 +PORTREVISION=	2
  PORTEPOCH=	1
  CATEGORIES=	emulators
  MASTER_SITES=	SFE \
 diff -urN wine.orig/files/patch-dlls-ntdll-virtual.c wine/files/patch-dlls-ntdll-virtual.c
 --- wine.orig/files/patch-dlls-ntdll-virtual.c	1970-01-01 01:00:00.000000000 +0100
 +++ wine/files/patch-dlls-ntdll-virtual.c	2008-12-07 17:38:22.000000000 +0100
 @@ -0,0 +1,13 @@
 +--- dlls/ntdll/virtual.c.orig	2008-12-07 17:26:02.000000000 +0100
 ++++ dlls/ntdll/virtual.c	2008-12-07 17:28:46.000000000 +0100
 +@@ -1249,9 +1249,7 @@
 +         }
 +     }
 + 
 +-    /* try to find space in a reserved area for the virtual heap */
 +-    if (!wine_mmap_enum_reserved_areas( alloc_virtual_heap, &heap_base, 1 ))
 +-        heap_base = wine_anon_mmap( NULL, VIRTUAL_HEAP_SIZE, PROT_READ|PROT_WRITE, 0 );
 ++    heap_base = wine_anon_mmap( (void *)0x81000000, VIRTUAL_HEAP_SIZE, PROT_READ|PROT_WRITE, 0 );
 + 
 +     assert( heap_base != (void *)-1 );
 +     virtual_heap = RtlCreateHeap( HEAP_NO_SERIALIZE, heap_base, VIRTUAL_HEAP_SIZE,
 
 --Boundary-00=_/2/OJvQE0Z5eJL4--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/128926: commit references a PR
Date: Sat, 13 Dec 2008 09:57:43 +0000 (UTC)

 gerald      2008-12-13 09:57:30 UTC
 
   FreeBSD ports repository
 
   Modified files:
     emulators/wine       Makefile distinfo 
   Log:
   Update to Wine 1.1.10.  Among others, this includes the following changes:
    - Support for virtual memory write watches.
    - Some more GdiPlus functions.
    - Various bug fixes.
   
   Also, add a patch that fixes the "Invalid address" issue for real. [1]
   
   PR:             128926 [1], 129585
   Submitted by:   Tijl Coosemans <tijl@ulyssis.org> [1]
   Obtained from:  Alex Kozlov <spam@rm-rf.kiev.ua> [1]
   
   Revision  Changes    Path
   1.279     +1 -2      ports/emulators/wine/Makefile
   1.170     +3 -3      ports/emulators/wine/distinfo
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: gerald 
State-Changed-When: Sat Dec 13 10:14:20 UTC 2008 
State-Changed-Why:  
Thanks to Alex and Tijl! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128926 

From: Gerald Pfeifer <gerald@pfeifer.com>
To: Tijl Coosemans <tijl@ulyssis.org>
Cc: bug-followup@freebsd.org, russo@bogodyn.org, 
    Alex Kozlov <spam@rm-rf.kiev.ua>, Daichi GOTO <daichi@ongs.co.jp>
Subject: Re: ports/128926: emulators/wine: Wine version 1.1.8,1 gives "Invalid
 address" for many windows binaries
Date: Sat, 13 Dec 2008 11:23:48 +0100 (CET)

 On Sun, 7 Dec 2008, Tijl Coosemans wrote:
 > Here's a patch for the port.
 > 
 > Original patch by Alex Kozlov, with small modifications.
 
 Thanks a lot, Tijl and Alex!  Turns out that I got Internet access for
 a bit (~2s pings to freebsd.org ;-) and managed to commit an update to 
 the port with this patch.
 
 Please keep pushing this upstream as well, that is really important in
 my experience (where local patches have hurt us).
 
 Gerald
>Unformatted:
