From nobody@FreeBSD.org  Mon Nov 10 09:30:47 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C7C1A1065673
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 10 Nov 2008 09:30:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id B23CE8FC21
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 10 Nov 2008 09:30:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id mAA9UlX8033348
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 10 Nov 2008 09:30:47 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id mAA9UlKV033347;
	Mon, 10 Nov 2008 09:30:47 GMT
	(envelope-from nobody)
Message-Id: <200811100930.mAA9UlKV033347@www.freebsd.org>
Date: Mon, 10 Nov 2008 09:30:47 GMT
From: "Joseph S. Atkinson" <jsa@wickedmachine.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: multimedia/vlc-devel fix conflicting WITH_SKINS + WITHOUT_QT4
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         128747
>Category:       ports
>Synopsis:       multimedia/vlc-devel fix conflicting WITH_SKINS + WITHOUT_QT4
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 10 09:40:00 UTC 2008
>Closed-Date:    Sat Nov 15 23:38:19 UTC 2008
>Last-Modified:  Sat Nov 15 23:40:04 UTC 2008
>Originator:     Joseph S. Atkinson
>Release:        
>Organization:
>Environment:
>Description:
If a user opts not to build the QT interface, but has opted for the skinnable UI, configure fails.

This informs people selecting these via the OPTIONS framework that QT4 is required for SKINS. If a user defines both anyway via `make config` or in the environment, then WITH_SKINS will be silently ignored in favor of honoring WITHOUT_QT4.

No need to bump PORTREVISION.

Discovered reviewing config.log sent via private email.

Thanks A. B.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile.orig	2008-11-10 03:32:26.000000000 -0500
+++ Makefile	2008-11-10 04:04:26.000000000 -0500
@@ -51,7 +51,7 @@
 OPTIONS+=	SVG "SVG graphics support" Off
 OPTIONS+=	SVGALIB "SVGALIB video output" Off
 OPTIONS+=	SHOUT "Shout2 support" Off
-OPTIONS+=	SKINS "Enable winamp skins interface" Off
+OPTIONS+=	SKINS "Enable winamp skins interface (requires QT4)" Off
 OPTIONS+=	SPEEX "Speex voice codec support" On
 OPTIONS+=	THEORA "OGG/Vorbis video codec support" On
 OPTIONS+=	TWOLAME "Twolame mpeg2 audio encoder support" On
@@ -165,7 +165,7 @@
 CONFIGURE_ARGS+=--disable-notify
 .endif
 
-.if defined(WITH_SKINS) && !defined(WITHOUT_SKINS)
+.if defined(WITH_SKINS) && !defined(WITHOUT_SKINS) && !defined(WITHOUT_QT4)
 CONFIGURE_ARGS+=--enable-skins2
 .else
 CONFIGURE_ARGS+=--disable-skins2


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Mon Nov 10 11:24:17 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128747 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Sat Nov 15 23:38:18 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128747 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/128747: commit references a PR
Date: Sat, 15 Nov 2008 23:38:23 +0000 (UTC)

 miwi        2008-11-15 23:38:13 UTC
 
   FreeBSD ports repository
 
   Modified files:
     multimedia/vlc-devel Makefile 
   Log:
   - Fix conflicting WITH_SKINS + WITHOUT_QT4
   
   PR:             128747
   Submitted by:   "Joseph S. Atkinson" <jsa@wickedmachine.net> (maintainer)
   
   Revision  Changes    Path
   1.210     +2 -2      ports/multimedia/vlc-devel/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
