From amdmi3@amdmi3.ru  Sun Nov  9 17:33:36 2008
Return-Path: <amdmi3@amdmi3.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 09B161065679;
	Sun,  9 Nov 2008 17:33:36 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [217.170.79.85])
	by mx1.freebsd.org (Postfix) with ESMTP id B854E8FC0C;
	Sun,  9 Nov 2008 17:33:35 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.69)
	(envelope-from <amdmi3@amdmi3.ru>)
	id 1KzEAL-0005jS-8o; Sun, 09 Nov 2008 20:33:37 +0300
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id EB600E6CE;
	Sun,  9 Nov 2008 20:33:20 +0300 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
	id 9851A1702D; Sun,  9 Nov 2008 20:33:34 +0300 (MSK)
Message-Id: <20081109173334.9851A1702D@hades.panopticon>
Date: Sun,  9 Nov 2008 20:33:34 +0300 (MSK)
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: multimedia@FreeBSD.org
Subject: [PATCH] multimedia/libquicktime: default LAME option to on
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         128730
>Category:       ports
>Synopsis:       [PATCH] multimedia/libquicktime: default LAME option to on
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-multimedia
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 09 17:40:07 UTC 2008
>Closed-Date:    Tue Mar 31 12:22:23 UTC 2009
>Last-Modified:  Tue Mar 31 12:22:23 UTC 2009
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 7.0-RELEASE-p1 i386
>Organization:
>Environment:
System: FreeBSD hades.panopticon 7.0-RELEASE-p1 FreeBSD 7.0-RELEASE-p1 #1: Wed Jun 25 15:36:22 MSD 2008
>Description:
Enable LAME option by default. I have a port (pending multimedia/openmovieeditor update) that needs lame-enabled libquicktime and unfortunately, there's no way to depend on other ports' options :(

Port maintainer (multimedia@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- libquicktime-1.0.3_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/multimedia/libquicktime/Makefile,v
retrieving revision 1.61
diff -u -u -r1.61 Makefile
--- Makefile	20 Aug 2008 00:57:00 -0000	1.61
+++ Makefile	9 Nov 2008 17:29:04 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	libquicktime
 PORTVERSION=	1.0.3
+PORTREVISION=	1
 CATEGORIES=	multimedia
 MASTER_SITES=	SFE
 
@@ -26,7 +27,7 @@
 CFLAGS+=	-fPIC
 MAN1=		lqtplay.1
 
-OPTIONS=	LAME "Enable Lame mp3 encoding support" Off \
+OPTIONS=	LAME "Enable Lame mp3 encoding support" On \
 		OPENGL "Enable OpenGL support" On \
 		DV "Enable libdv support for digital cameras" On \
 		JPEG "Enable JPEG support" On \
@@ -58,7 +59,7 @@
 PLIST_SUB+=	GTK="@comment "
 .endif
 
-.if defined(WITH_LAME)
+.if !defined(WITHOUT_LAME)
 LIB_DEPENDS+=	mp3lame.0:${PORTSDIR}/audio/lame
 PLIST_SUB+=	LAME=""
 CONFIGURE_ARGS+=	--with-lame
--- libquicktime-1.0.3_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-multimedia 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Nov 9 17:40:21 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

Date: Mon, 10 Nov 2008 14:04:02 -0600
From: "Michael Johnson" <ahze@ahze.net>
Subject: Re: [PATCH] multimedia/libquicktime: default LAME option to on

 The reason lame is off by default is so we can have a libquicktime package
 due to license restrictions in lame.

Date: Tue, 11 Nov 2008 15:12:47 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Michael Johnson <ahze@ahze.net>
Subject: Re: [PATCH] multimedia/libquicktime: default LAME option to on

 Got it. Then maybe any suggestions on how to properly update
 openmovieeditor? I can think of some hacky stuff like checking for
 WITH_LAME in PORT_DBDIR/libquicktime and marking port with IGNORE
 otherwise.
 
 -- 
 Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
 amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru

http://www.freebsd.org/cgi/query-pr.cgi?pr=128730 

Date: Tue, 11 Nov 2008 10:16:47 -0600
From: "Jeremy Messenger" <mezz7@cox.net>
To: "Dmitry Marakasov" <amdmi3@amdmi3.ru>
Subject: Re: [PATCH] multimedia/libquicktime: default LAME option to on

 All you have to use exists() to check on lib/libquicktime/lqt_lame.so.
 
 Is it allows to enable lame support by default in ports tree, but disable  
 only on package (PACKAGE_BUILDING)? Of course, you will have to add  
 something to not build package for openmovieeditor too to avoid get error  
  from tinderbox.
 
 Maybe you should make a request to the openmovieeditor team to see if they  
 can make lame to optional? Explain them about that it has license  
 restrictions in lame.
 
 Oh hey ahze! ;-)
 
 Cheers,
 Mezz
 
 -- 
 mezz7@cox.net  -  mezz@FreeBSD.org
 FreeBSD GNOME Team
 http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org

Date: Tue, 11 Nov 2008 19:29:01 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Jeremy Messenger <mezz7@cox.net>
Subject: Re: [PATCH] multimedia/libquicktime: default LAME option to on

 >> Got it. Then maybe any suggestions on how to properly update
 >> openmovieeditor? I can think of some hacky stuff like checking for
 >> WITH_LAME in PORT_DBDIR/libquicktime and marking port with IGNORE
 >> otherwise.
 > All you have to use exists() to check on lib/libquicktime/lqt_lame.so.
 Oh, thanks! For some reason I thought libquicktime doesn't install
 extra files when lame is enabled.
 
 > Maybe you should make a request to the openmovieeditor team to see if 
 > they can make lame to optional? Explain them about that it has license  
 > restrictions in lame.
 Will try as well, thanks.
 
 -- 
 Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
 amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru

State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Tue Mar 31 12:21:32 UTC 2009 
State-Changed-Why:  
Cannot change that option's default 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128730 
>Unformatted:
