From rea-fbsd@codelabs.ru  Thu Nov  6 10:10:16 2008
Return-Path: <rea-fbsd@codelabs.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 186D4106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  6 Nov 2008 10:10:16 +0000 (UTC)
	(envelope-from rea-fbsd@codelabs.ru)
Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45])
	by mx1.freebsd.org (Postfix) with ESMTP id B1A0F8FC1A
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  6 Nov 2008 10:10:15 +0000 (UTC)
	(envelope-from rea-fbsd@codelabs.ru)
Received: from amnesiac.at.no.dns (dns.ccsem.infn.it [192.135.15.3])
	by 0.mx.codelabs.ru with esmtps (TLSv1:CAMELLIA256-SHA:256)
	id 1Ky1oc-000Ole-G4 for FreeBSD-gnats-submit@freebsd.org; Thu, 06 Nov 2008 13:10:14 +0300
Received: by amnesiac.at.no.dns (Postfix, from userid 1001)
	id D609D1710C; Thu,  6 Nov 2008 13:10:12 +0300 (MSK)
Message-Id: <20081106101012.D609D1710C@amnesiac.at.no.dns>
Date: Thu,  6 Nov 2008 13:10:12 +0300 (MSK)
From: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
Reply-To: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] fix SEGV in mutt-devel
X-Send-Pr-Version: 3.113
X-GNATS-Notify: udo.schweigert@siemens.com udo.schweigert@siemens.com udo.schweigert@siemens.com

>Number:         128637
>Category:       ports
>Synopsis:       [patch] fix SEGV in mail/mutt-devel
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 06 10:20:00 UTC 2008
>Closed-Date:    Wed Nov 12 12:41:03 UTC 2008
>Last-Modified:  Wed Nov 12 12:50:01 UTC 2008
>Originator:     Eygene Ryabinkin
>Release:        FreeBSD 7.1-PRERELEASE amd64
>Organization:
Code Labs
>Environment:

System: FreeBSD XXX 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #17: Thu Nov 6 12:14:18 MSK 2008 root@XXX:/usr/obj/usr/src/sys/XXX amd64

>Description:

There is a known bug in the Mutt 1.5.18: http://dev.mutt.org/trac/ticket/3057
It is rather nasty, because it crashes Mutt.

>How-To-Repeat:

From the bug description:
-----
I start mutt. With c+<TAB>+<TAB> I change to imap.gmail.com where I have
to enter the passwort. With c+! I change back to home server. When I
press c+<TAB>+>TAB> again to access another preconfigured mailbox, mutt
crashes reproducible.
-----

>Fix:

Since Mutt release cycle is "floating" and it is not currently known
where the next release will happen, I propose to patch FreeBSD port
just now.  The patch itself was obtained from the upstream.

--- 1.5.18_4-fix-SEGV.patch begins here ---
diff -urN ./Makefile ../mutt-devel/Makefile
--- ./Makefile	2008-11-05 11:29:47.000000000 +0300
+++ ../mutt-devel/Makefile	2008-11-05 11:30:40.000000000 +0300
@@ -117,7 +117,7 @@
 
 PORTNAME=	mutt-devel
 PORTVERSION=	1.5.18
-PORTREVISION?=	3
+PORTREVISION?=	4
 CATEGORIES+=	mail ipv6
 .if defined(WITH_MUTT_NNTP)
 CATEGORIES+=	news
diff -urN ./files/patch-imap::browse.c-fix-SEGV ../mutt-devel/files/patch-imap::browse.c-fix-SEGV
--- ./files/patch-imap::browse.c-fix-SEGV	1970-01-01 03:00:00.000000000 +0300
+++ ../mutt-devel/files/patch-imap::browse.c-fix-SEGV	2008-11-05 11:32:54.000000000 +0300
@@ -0,0 +1,13 @@
+Index: imap/browse.c
+Obtained from: http://dev.mutt.org/trac/changeset/5401%3Abba92e401440/imap/browse.c?old=5378%3Aac00273b3a88&old_path=imap%2Fbrowse.c
+Bug description: http://dev.mutt.org/trac/ticket/3057
+===================================================================
+--- imap/browse.c
++++ imap/browse.c
+@@ -229,5 +229,5 @@
+   }
+ 
+-  if (!imap_mxcmp(mx.mbox, idata->mailbox))
++  if (idata->ctx && !imap_mxcmp(mx.mbox, idata->mailbox))
+   {
+     state->new = idata->ctx->new;
--- 1.5.18_4-fix-SEGV.patch ends here ---
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Nov 6 11:24:12 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128637 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: udo.schweigert@siemens.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/128637: [patch] fix SEGV in mail/mutt-devel
Date: Thu, 6 Nov 2008 11:24:11 UT

 Maintainer of mail/mutt-devel,
 
 Please note that PR ports/128637 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/128637
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: wxs 
Responsible-Changed-When: Thu Nov 6 14:07:39 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128637 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: udo.schweigert@siemens.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/128637: [patch] fix SEGV in mail/mutt-devel
Date: Thu, 6 Nov 2008 15:04:16 UT

 Maintainer of mail/mutt-devel,
 
 Please note that PR ports/128637 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/128637
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Edwin Groothuis <edwin@FreeBSD.org>
To: udo.schweigert@siemens.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/128637: [patch] fix SEGV in mail/mutt-devel
Date: Thu, 6 Nov 2008 15:11:05 UT

 Maintainer of mail/mutt-devel,
 
 Please note that PR ports/128637 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/128637
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: "Schweigert, Udo CERT" <Udo.Schweigert@siemens.com>
To: bug-followup@FreeBSD.ORG
Cc:  
Subject: Re: ports/128637: [patch] fix SEGV in mail/mutt-devel
Date: Tue, 11 Nov 2008 22:43:42 +0100

 Maintainer feedback: please apply this patch:
 
 diff -ru  /usr/ports/mail/mutt-devel/Makefile ./Makefile
 --- /usr/ports/mail/mutt-devel/Makefile	2008-10-23 09:21:45.000000000 +0200
 +++ ./Makefile	2008-11-10 23:03:30.000000000 +0100
 @@ -117,7 +117,7 @@
  
  PORTNAME=	mutt-devel
  PORTVERSION=	1.5.18
 -PORTREVISION?=	3
 +PORTREVISION?=	4
  CATEGORIES+=	mail ipv6
  .if defined(WITH_MUTT_NNTP)
  CATEGORIES+=	news
 diff -ru  /usr/ports/mail/mutt-devel/files/patch-imap-browse.c ./files/patch-imap-browse.c
 --- /usr/ports/mail/mutt-devel/files/patch-imap-browse.c	1970-01-01 01:00:00.000000000 +0100
 +++ ./files/patch-imap-browse.c	2008-11-10 23:06:04.000000000 +0100
 @@ -0,0 +1,13 @@
 +Index: imap/browse.c
 +Obtained from: http://dev.mutt.org/trac/changeset/5401%3Abba92e401440/imap/browse.c?old=5378%3Aac00273b3a88&old_path=imap%2Fbrowse.c
 +Bug description: http://dev.mutt.org/trac/ticket/3057
 +===================================================================
 +--- imap/browse.c
 ++++ imap/browse.c
 +@@ -229,5 +229,5 @@
 +   }
 + 
 +-  if (!imap_mxcmp(mx.mbox, idata->mailbox))
 ++  if (idata->ctx && !imap_mxcmp(mx.mbox, idata->mailbox))
 +   {
 +     state->new = idata->ctx->new;
 
 On Thu, Nov 06, 2008 at 15:11:05 +0000, Edwin Groothuis wrote:
 > Maintainer of mail/mutt-devel,
 > 
 > Please note that PR ports/128637 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 > 
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/128637
 > 
 > -- 
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 > 
State-Changed-From-To: feedback->closed 
State-Changed-By: wxs 
State-Changed-When: Wed Nov 12 12:41:01 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128637 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/128637: commit references a PR
Date: Wed, 12 Nov 2008 12:41:10 +0000 (UTC)

 wxs         2008-11-12 12:40:55 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/mutt-devel      Makefile 
   Added files:
     mail/mutt-devel/files patch-imap-browse.c 
   Log:
   Add a patch that fixes a crash (http://dev.mutt.org/trac/ticket/3057).
   
   PR:             ports/128637
   Submitted by:   Eygene Ryabinkin <rea-fbsd@codelabs.ru>
   Reviewed by:    Udo.Schweigert@siemens.com (maintainer)
   
   Revision  Changes    Path
   1.298     +1 -1      ports/mail/mutt-devel/Makefile
   1.3       +13 -0     ports/mail/mutt-devel/files/patch-imap-browse.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
