From nobody@FreeBSD.org  Mon Oct 27 17:48:49 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 59BA41065672
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 Oct 2008 17:48:49 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 47BA78FC21
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 Oct 2008 17:48:49 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id m9RHmncM006892
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 Oct 2008 17:48:49 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id m9RHmm2o006891;
	Mon, 27 Oct 2008 17:48:48 GMT
	(envelope-from nobody)
Message-Id: <200810271748.m9RHmm2o006891@www.freebsd.org>
Date: Mon, 27 Oct 2008 17:48:48 GMT
From: "G. Paul Ziemba" <p-fbsd-bugs@ziemba.us>
To: freebsd-gnats-submit@FreeBSD.org
Subject: port www/opera operapluginwrapper misparses command line
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: freebsd-maintainer@opera.com

>Number:         128420
>Category:       ports
>Synopsis:       port www/opera operapluginwrapper misparses command line
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    itetcu
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 27 17:50:01 UTC 2008
>Closed-Date:    Sat Dec 27 10:09:17 UTC 2008
>Last-Modified:  Sat Dec 27 10:10:07 UTC 2008
>Originator:     G. Paul Ziemba
>Release:        6.2-STABLE
>Organization:
>Environment:
FreeBSD hairball.ziemba.us 6.2-STABLE FreeBSD 6.2-STABLE #0: Sun Jun  3 19:55:09 PDT 2007     root@hairball:/usr/obj/usr/src/sys/GPZ-070603  i386
>Description:
% pkg_info|grep opera
opera-9.60.20081004_1 Blazingly fast, full-featured, standards-compliant browser,
opera-linuxplugins-9.60.20081004 Linux plugin support for the native Opera browser

/usr/local/share/opera/bin/operapluginwrapper is called with arguments:
detect -fd 81 -v /usr/local/lib/npapi/linux-flashplugin/libflashplayer.so

It does not handle the case where the plugin filename is in $5, so calls brandelf only as "brandelf -v", which is bogus. Plugin detection fails, since
this plugin is SVR4 but is treated as a FreeBSD-branded file.
>How-To-Repeat:

>Fix:
patch ports/www/opera/files/operapluginwrapper:
--- operapluginwrapper.old      Thu Oct 16 18:07:50 2008
+++ operapluginwrapper  Mon Oct 27 10:28:47 2008
@@ -1,6 +1,8 @@
 #!/bin/sh
 
-if [ -n "$4" ]; then
+if [ -n "$5" ]; then
+ELFTYPE=`brandelf $5`
+elif [ -n "$4" ]; then
 ELFTYPE=`brandelf $4`
 elif [ -n "$3" ]; then
 ELFTYPE=`brandelf $3`


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->itetcu 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Oct 27 17:50:12 UTC 2008 
Responsible-Changed-Why:  
itetcu@ wants this port PRs (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128420 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Oct 27 17:50:16 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128420 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: freebsd-maintainer@opera.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/128420: port www/opera operapluginwrapper misparses command line
Date: Mon, 27 Oct 2008 17:50:14 UT

 Maintainer of www/opera,
 
 Please note that PR ports/128420 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/128420
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: "Arjan van Leeuwen" <freebsd-maintainer@opera.com>
To: bug-followup@freebsd.org, p-fbsd-bugs@ziemba.us
Cc:  
Subject: Re: ports/128420: port www/opera operapluginwrapper misparses command
 line
Date: Wed, 10 Dec 2008 14:01:42 +0100

 This seems to be what happens when debug settings for plugins are enabled.  
 The patch is valid.
 
 Arjan
 
 -- 
 Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
State-Changed-From-To: feedback->open 
State-Changed-By: itetcu 
State-Changed-When: Mon Dec 15 08:39:49 UTC 2008 
State-Changed-Why:  
maintianer apporved 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128420 
State-Changed-From-To: open->closed 
State-Changed-By: itetcu 
State-Changed-When: Sat Dec 27 10:09:16 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128420 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/128420: commit references a PR
Date: Sat, 27 Dec 2008 10:09:15 +0000 (UTC)

 itetcu      2008-12-27 10:09:01 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/opera/files      operapluginwrapper 
   Log:
   Try to fix plugin brandelf'ing when pugin debugis enabled.
   
   PR:             ports/128420
   Submitted by:   G. Paul Ziemba
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.4       +2 -0      ports/www/opera/files/operapluginwrapper
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
