From ntarmos@ceid.upatras.gr  Fri Oct 17 15:04:15 2008
Return-Path: <ntarmos@ceid.upatras.gr>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 326A9106568E
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Oct 2008 15:04:15 +0000 (UTC)
	(envelope-from ntarmos@ceid.upatras.gr)
Received: from poseidon.ceid.upatras.gr (poseidon.ceid.upatras.gr [150.140.141.169])
	by mx1.freebsd.org (Postfix) with ESMTP id A04CB8FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Oct 2008 15:04:14 +0000 (UTC)
	(envelope-from ntarmos@ceid.upatras.gr)
Received: from mail.ceid.upatras.gr (unknown [10.1.0.143])
	by poseidon.ceid.upatras.gr (Postfix) with ESMTP id B3D21EB5CC4
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Oct 2008 17:32:38 +0300 (EEST)
Received: from localhost (europa.ceid.upatras.gr [127.0.0.1])
	by mail.ceid.upatras.gr (Postfix) with ESMTP id AAE6844FE2
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Oct 2008 17:32:38 +0300 (EEST)
Received: from mail.ceid.upatras.gr ([127.0.0.1])
	by localhost (europa.ceid.upatras.gr [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id clDl-T8+ffeA for <FreeBSD-gnats-submit@freebsd.org>;
	Fri, 17 Oct 2008 17:32:38 +0300 (EEST)
Received: from ace.netcins.ceid.upatras.gr (ppp089210141242.dsl.hol.gr [89.210.141.242])
	by mail.ceid.upatras.gr (Postfix) with ESMTP id 782C344002
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Oct 2008 17:32:38 +0300 (EEST)
Received: by ace.netcins.ceid.upatras.gr (Postfix, from userid 1001)
	id CF15C3F42B; Fri, 17 Oct 2008 17:20:58 +0300 (EEST)
Message-Id: <20081017142058.CF15C3F42B@ace.netcins.ceid.upatras.gr>
Date: Fri, 17 Oct 2008 17:20:58 +0300 (EEST)
From: Nikos Ntarmos <ntarmos@ceid.upatras.gr>
Reply-To: Nikos Ntarmos <ntarmos@ceid.upatras.gr>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] Add an XCB option to graphics/cairo
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         128179
>Category:       ports
>Synopsis:       [patch] Add an XCB option to graphics/cairo
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 17 15:10:03 UTC 2008
>Closed-Date:    Fri Oct 17 17:02:36 UTC 2008
>Last-Modified:  Fri Oct 17 17:02:36 UTC 2008
>Originator:     Nikos Ntarmos
>Release:        FreeBSD 7.1-PRERELEASE i386
>Organization:
NetCInS Lab., C.E.I.D., U. of Patras, Greece
>Environment:
System: FreeBSD ace.netcins.ceid.upatras.gr 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #0: Fri Oct 17 01:32:29 EEST 2008 ntarmos@ace.netcins.ceid.upatras.gr:/opt/src/sys/i386/compile/ACE i386


	
>Description:
graphics/cairo can take advantage of xcb bits, should they be present in
the system (i.e. in the form of x11/libxcb and x11/xcb-util). I'm
preparing an update of the x11-wm/awesome port to the 3.x branch and
need this xcb support in cairo.
	
>How-To-Repeat:
	
>Fix:
The following patch adds an option in the cairo Makefile to turn xcb support on.

--- cairo.diff begins here ---
--- Makefile.orig	2008-10-17 17:06:05.000000000 +0300
+++ Makefile	2008-10-17 17:14:09.000000000 +0300
@@ -42,10 +42,17 @@
 PLIST_SUB+=	X11=""
 .endif
 
-OPTIONS+=	GLITZ "Enable Glitz OpenGL Support" Off
+OPTIONS+=	GLITZ "Enable Glitz OpenGL Support" Off \
+		XCB "Enable XCB Support" Off
 
 .include <bsd.port.pre.mk>
 
+.if defined(WITH_XCB)
+CONFIGURE_ARGS+=	--enable-xcb=auto
+LIB_DEPENDS+=		xcb.1:${PORTSDIR}/x11/libxcb \
+			xcb-event.1:${PORTSDIR}/x11/xcb-util
+.endif
+
 .if defined(WITH_GLITZ)
 LIB_DEPENDS+=	glitz-glx.1:${PORTSDIR}/graphics/glitz
 CONFIGURE_ARGS+=	--enable-glitz
--- cairo.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Oct 17 15:10:41 UTC 2008 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128179 
State-Changed-From-To: open->closed 
State-Changed-By: mezz 
State-Changed-When: Fri Oct 17 17:02:06 UTC 2008 
State-Changed-Why:  
Duplicate: ports/126993 

Your patch has missed to fix the plist, which the ports/126993 has the correct 
patch. 

Anyway, it is already available in MC ports but I can merge it (only xcb part) 
into FreeBSD ports if you need it soon for update of x11-wm/awesome port. Why 
did you keep xcb disable by default? It should be enable by default if 
x11-wm/awesome port needs it, so I will enable it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128179 
>Unformatted:
