From nobody@FreeBSD.org  Tue Oct 14 22:44:59 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E2738106568E
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Oct 2008 22:44:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id D08F28FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Oct 2008 22:44:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id m9EMixgY062393
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Oct 2008 22:44:59 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id m9EMixjT062392;
	Tue, 14 Oct 2008 22:44:59 GMT
	(envelope-from nobody)
Message-Id: <200810142244.m9EMixjT062392@www.freebsd.org>
Date: Tue, 14 Oct 2008 22:44:59 GMT
From: Andrew Daugherity <adaugherity@tamu.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: isc-dhcp30-server LDAP support broken [regression]
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: Joerg.Pulz@frm2.tum.de

>Number:         128104
>Category:       ports
>Synopsis:       net/isc-dhcp30-server LDAP support broken [regression]
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    stefan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 14 22:50:00 UTC 2008
>Closed-Date:    Sat Oct 18 17:25:39 UTC 2008
>Last-Modified:  Sat Oct 18 17:30:02 UTC 2008
>Originator:     Andrew Daugherity
>Release:        7.0
>Organization:
Texas A&M University
>Environment:
FreeBSD inferno.tamu.edu 7.0-RELEASE-p4 FreeBSD 7.0-RELEASE-p4 #0: Tue Sep  2 19:32:35 UTC 2008     root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
After upgrading dhcpd to reflect the new version and the port name change ( from isc-dhcp3-server-3.0.5_2 to isc-dhcp30-server-3.0.7_2), dhcpd failed to restart, complaining about syntax errors:
====
/usr/local/etc/dhcpd.conf line 19: semicolon expected.
ldap-ssl start_tls;
         ^
Configuration file errors encountered -- exiting
====

After commenting out that line, it still failed, generating many errors like this:
====
LDAP line 34: expecting a declaration
}
^
LDAP line 41: string constant larger than internal buffer
option pxelinux.reboottime code 211 = unsigned integer 32;
                             ^
LDAP line 49: expecting a declaration
(binary garbage printed here)
 ^
LDAP line 59: expecting a declaration
(binary garbage printed here)
    ^
LDAP line 59: expecting a declaration
(binary garbage printed here)
^
LDAP line 65: expecting a declaration
(binary garbage printed here)
^
====

Of course, this makes dhcpd completely broken for LDAP use.

>How-To-Repeat:
Install isc-dhcp30-server-3.0.7_2 from ports, and enable LDAP support in the options screen.
>Fix:
I discovered that the port Makefile has two sites defined for the LDAP patch:
1. http://www.newwave.net/~masneyb/
2. ftp://ftp.frm2.tum.de/pub/jpulz/FreeBSD/

It attempts to fetch dhcp-$VERSION-ldap-patch. Site 1 only has version 3.0.5, while site 2 has many versions.  However, version 3.0.5 of the patch ('dhcp-3.0.5-ldap-patch') is not identical between the sites even (the version on site 2 is missing large sections of the patch).

The real bug is that the patches from site 2 are broken, and this behavior is a side-effect of the upgrade: due to there not being a dhcp-3.0.7-ldap-patch on site 1, it fetches it from site 2.  When the portversion was 3.0.5 it fetched from site 1 and all was well.


Workaround: use the patch from site 1, which still works with 3.0.7.
# ftp http://www.newwave.net/~masneyb/dhcp-3.0.5-ldap-patch
# cp dhcp-3.0.5-ldap-patch /usr/ports/distfiles/dhcp-3.0.7-ldap-patch
# cd /usr/ports/net/isc-dhcp30-server; make makesum
# make install   (or make deinstall reinstall)

After doing this dhcpd works properly once more.

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Oct 14 22:52:56 UTC 2008 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128104 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: Joerg.Pulz@frm2.tum.de
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/128104: net/isc-dhcp30-server LDAP support broken [regression]
Date: Tue, 14 Oct 2008 22:52:54 UT

 Maintainer of net/isc-dhcp30-server,
 
 Please note that PR ports/128104 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/128104
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Joerg Pulz <Joerg.Pulz@frm2.tum.de>
To: bug-followup@FreeBSD.ORG
Cc:  
Subject: Re: ports/128104: net/isc-dhcp30-server LDAP support broken
 [regression]
Date: Wed, 15 Oct 2008 13:53:13 +0200 (CEST)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
 
 --1038996377-61049652-1224071596=:28608
 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
 
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 
 Hi,
 
 sorry, i've uploaded the wrong patchfile to the FTP server.
 Attached is a patch for the port to tell distinfo the new size and 
 checksums for the LDAP patchfile.
 PORTREVISION gets bumped for the -server port.
 
 Kind regards
 Joerg
 
 - -- 
 The beginning is the most important part of the work.
  				-Plato
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.9 (FreeBSD)
 
 iD8DBQFI9dmsSPOsGF+KA+MRAq4uAKCj4i6Ll7mFyDfviDE5oe/tH4e/7ACgiUbL
 OBqcACsK9EdctErFpSEiBOE=
 =nJCV
 -----END PGP SIGNATURE-----
 --1038996377-61049652-1224071596=:28608
 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=net_isc-dhcp30-server.diff
 Content-Transfer-Encoding: BASE64
 Content-ID: <alpine.BSF.2.00.0810151353130.28608@unqrf.nqzva.sez2>
 Content-Description: 
 Content-Disposition: attachment; filename=net_isc-dhcp30-server.diff
 
 SW5kZXg6IE1ha2VmaWxlDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1Mg
 ZmlsZTogL2hvbWUvbmN2cy9wb3J0cy9uZXQvaXNjLWRoY3AzMC1zZXJ2ZXIv
 TWFrZWZpbGUsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjEyNQ0KZGlmZiAt
 dSAtcjEuMTI1IE1ha2VmaWxlDQotLS0gTWFrZWZpbGUJMTMgT2N0IDIwMDgg
 MTI6MDQ6MjkgLTAwMDAJMS4xMjUNCisrKyBNYWtlZmlsZQkxNSBPY3QgMjAw
 OCAxMTo0MjoyMyAtMDAwMA0KQEAgLTIwLDcgKzIwLDcgQEANCiBNQUlOVEFJ
 TkVSPQlKb2VyZy5QdWx6QGZybTIudHVtLmRlDQogQ09NTUVOVD89CVRoZSBJ
 U0MgRHluYW1pYyBIb3N0IENvbmZpZ3VyYXRpb24gUHJvdG9jb2wgc2VydmVy
 DQogDQotUE9SVFJFVklTSU9OX1NFUlZFUj0JMg0KK1BPUlRSRVZJU0lPTl9T
 RVJWRVI9CTMNCiBQT1JUUkVWSVNJT05fQ0xJRU5UPQkwDQogUE9SVFJFVklT
 SU9OX1JFTEFZPQkwDQogUE9SVFJFVklTSU9OX0RFVkVMPQkwDQpJbmRleDog
 ZGlzdGluZm8NCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAv
 aG9tZS9uY3ZzL3BvcnRzL25ldC9pc2MtZGhjcDMwLXNlcnZlci9kaXN0aW5m
 byx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNjENCmRpZmYgLXUgLXIxLjYx
 IGRpc3RpbmZvDQotLS0gZGlzdGluZm8JMTMgT2N0IDIwMDggMTE6MTA6MTEg
 LTAwMDAJMS42MQ0KKysrIGRpc3RpbmZvCTE1IE9jdCAyMDA4IDExOjQyOjIz
 IC0wMDAwDQpAQCAtMSw5ICsxLDkgQEANCiBNRDUgKGRoY3AtMy4wLjcudGFy
 Lmd6KSA9IDQyNmJmYTE3MTJhYmFiYWZmNGJlNmRhZGVlOWMxOTgyDQogU0hB
 MjU2IChkaGNwLTMuMC43LnRhci5neikgPSA5ZWM2ZmJkMzdiNDcwNWZkOGVl
 ZDc4MmI2NDc5MGEyNDZjNTZiNWZkMWQ1ZTdkZTMxMDliNmMyM2Y0MWI5YzUw
 DQogU0laRSAoZGhjcC0zLjAuNy50YXIuZ3opID0gODg4ODI5DQotTUQ1IChk
 aGNwLTMuMC43LWxkYXAtcGF0Y2gpID0gOWE1OGI3ZmViYjY5NzgzYzE1YWI5
 ZGQ2MzViYWVlNzQNCi1TSEEyNTYgKGRoY3AtMy4wLjctbGRhcC1wYXRjaCkg
 PSA5ZmQxY2FmODAwNTI4OGE2OGVkZTU4NDc2YmVlYzdhNWExYzBiNTAyYTJh
 ZGI0MjE0MzAxM2IzYzkwMWQyMjVjDQotU0laRSAoZGhjcC0zLjAuNy1sZGFw
 LXBhdGNoKSA9IDE3NzY0OA0KK01ENSAoZGhjcC0zLjAuNy1sZGFwLXBhdGNo
 KSA9IDQxY2RlOWU5YTc2OGJmMTIzOTAyODg0NjVlZjMwYmJkDQorU0hBMjU2
 IChkaGNwLTMuMC43LWxkYXAtcGF0Y2gpID0gZTcwMDQ3MmFjYjg5MGI1MDRh
 ZTUxOTk1MDBhMGU4N2NhMWRhNjA3OTQ2YjJmM2E4YTg5NThmODJkMGEyNzdj
 MA0KK1NJWkUgKGRoY3AtMy4wLjctbGRhcC1wYXRjaCkgPSAxOTIzMDgNCiBN
 RDUgKGRoY3AtMy4wLjctZGxxLXBhdGNoKSA9IDBlMDcxOTQ1Y2M5ODZkN2Vj
 ZGZkOWI0MWZjNGExMDJiDQogU0hBMjU2IChkaGNwLTMuMC43LWRscS1wYXRj
 aCkgPSBjM2ZkMzIwMGVhZjAwZmE4MGNiMzdmMTliZDNiOWVkYjg5NDk3YzIz
 NWI1ZmE1OTRhMGY2ZjYwMDUwZjY0MTA4DQogU0laRSAoZGhjcC0zLjAuNy1k
 bHEtcGF0Y2gpID0gNzY1NQ0K
 
 --1038996377-61049652-1224071596=:28608--
Responsible-Changed-From-To: freebsd-ports-bugs->stefan 
Responsible-Changed-By: stefan 
Responsible-Changed-When: Sat Oct 18 17:23:14 UTC 2008 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128104 
State-Changed-From-To: feedback->closed 
State-Changed-By: stefan 
State-Changed-When: Sat Oct 18 17:25:22 UTC 2008 
State-Changed-Why:  
Patch committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128104 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/128104: commit references a PR
Date: Sat, 18 Oct 2008 17:25:26 +0000 (UTC)

 stefan      2008-10-18 17:25:17 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/isc-dhcp30-server Makefile distinfo 
   Log:
   Fix distinfo for LDAP patch.
   
   PR:             128104
   Submitted by:   Andrew Daugherity <adaugherity@tamu.edu>
   Patch by:       maintainer
   
   Revision  Changes    Path
   1.126     +1 -1      ports/net/isc-dhcp30-server/Makefile
   1.62      +3 -3      ports/net/isc-dhcp30-server/distinfo
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
