From nobody@FreeBSD.org  Sun Sep 14 02:48:41 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 544951065675
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 14 Sep 2008 02:48:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 3F2268FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 14 Sep 2008 02:48:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m8E2me5K065485
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 14 Sep 2008 02:48:40 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m8E2mecO065484;
	Sun, 14 Sep 2008 02:48:40 GMT
	(envelope-from nobody)
Message-Id: <200809140248.m8E2mecO065484@www.freebsd.org>
Date: Sun, 14 Sep 2008 02:48:40 GMT
From: "Carlos A. M. dos Santos" <unixmania@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: audio/last.fm: add a .desktop file for Xfce/GNOME/KDE
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         127368
>Category:       ports
>Synopsis:       audio/last.fm: add a .desktop file for Xfce/GNOME/KDE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    amdmi3
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 14 02:50:01 UTC 2008
>Closed-Date:    Tue Mar 24 00:35:28 UTC 2009
>Last-Modified:  Tue Mar 24 00:40:06 UTC 2009
>Originator:     Carlos A. M. dos Santos
>Release:        7-STABLE
>Organization:
N.A.
>Environment:
FreeBSD casantos.casantos.org 7.0-STABLE FreeBSD 7.0-STABLE #4: Thu Jul 17 21:07:23 BRT 2008     root@casantos.casantos.org:/local/FreeBSD/src-stable/sys/amd64/compile/HP_NX6320_70_AMD64  amd64

>Description:
The last.fm port does not install a menu entry for Xfce, GNNOME and KDE.
>How-To-Repeat:
Install the package. :-)
>Fix:
Apply the attached patch.

Patch attached with submission follows:

diff -durP last.fm.orig/Makefile last.fm/Makefile
--- last.fm.orig/Makefile	2008-09-13 10:33:46.000000000 -0300
+++ last.fm/Makefile	2008-09-13 22:34:56.000000000 -0300
@@ -7,6 +7,7 @@
 
 PORTNAME=	last.fm
 PORTVERSION=	1.3.2.14
+PORTREVISION=	1
 CATEGORIES=	audio net
 MASTER_SITES=	http://cdn.last.fm/client/src/
 DISTNAME=	${PORTNAME}-${PORTVERSION}.src
@@ -47,7 +48,8 @@
 
 do-install:
 	${INSTALL_SCRIPT} ${WRKSRC}/bin/last.fm ${PREFIX}/bin/last.fm
-	${MKDIR} ${PREFIX}/share/services
+	${MKDIR} ${PREFIX}/share/applications ${PREFIX}/share/services
+	${INSTALL_DATA} ${FILESDIR}/last.fm.desktop ${PREFIX}/share/applications
 	${INSTALL_DATA} ${FILESDIR}/lastfm.protocol ${PREFIX}/share/services
 	${MKDIR} ${DATADIR}
 	${CP} -Rp ${WRKSRC}/bin/* ${DATADIR}/
diff -durP last.fm.orig/files/last.fm.desktop last.fm/files/last.fm.desktop
--- last.fm.orig/files/last.fm.desktop	1969-12-31 21:00:00.000000000 -0300
+++ last.fm/files/last.fm.desktop	2008-09-13 18:25:51.000000000 -0300
@@ -0,0 +1,20 @@
+[Desktop Entry]
+Name=Client for the Last.fm network
+Name[de]=Client fr das Last.fm-netzwerk
+Name[es]=Cliente para la red Last.fm
+Name[it]=Cliente per la rete di Last.fm
+Name[pt_BR]=Cliente para a rede Last.fm
+Name[pt_PT]=Cliente para a rede Last.fm
+Comment=Client for the Last.fm Network
+Comment[de]=Client fr das Last.fm-Netzwerk
+Comment[es]=Cliente para la red Last.fm
+Comment[it]=Cliente per la rete di Last.fm
+Comment[pt_BR]=Cliente para a Rede Last.fm
+Comment[pt_PT]=Cliente para a Rede Last.fm
+Exec=last.fm
+Terminal=false
+Type=Application
+Encoding=UTF-8
+Icon=/usr/local/share/last.fm/data/icons/as.png
+Categories=AudioVideo;Player;Qt;
+StartupNotify=true
diff -durP last.fm.orig/pkg-plist last.fm/pkg-plist
--- last.fm.orig/pkg-plist	2007-09-14 16:02:22.000000000 -0300
+++ last.fm/pkg-plist	2008-09-13 22:38:43.000000000 -0300
@@ -108,6 +108,7 @@
 %%DATADIR%%/services/libsrv_itunesdevice.so
 %%DATADIR%%/services/libsrv_mp3transcode.so
 %%DATADIR%%/services/libsrv_rtaudioplayback.so
+share/applications/last.fm.desktop
 share/services/lastfm.protocol
 @dirrmtry share/services
 @dirrm %%DATADIR%%/services


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->amdmi3 
Responsible-Changed-By: amdmi3 
Responsible-Changed-When: Sun Sep 14 13:38:28 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127368 

From: "Carlos A. M. dos Santos" <unixmania@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/127368: audio/last.fm: add a .desktop file for 
	Xfce/GNOME/KDE
Date: Sun, 15 Feb 2009 18:08:16 +0000

 Please use the patch below instead of the previous one. It fixes the
 last.fm script and embeds a runtime library search path in
 last.fm.app. Without this Xfce's task bar is unable to launch
 last.fm.app because it depends on libLastFmTools.so.1, which installed
 at a non-standard place.
 
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D PATCH STARTS HERE =3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D
 diff -durP last.fm.orig/Makefile last.fm/Makefile
 --- last.fm.orig/Makefile	2008-09-12 05:48:58.000000000 -0300
 +++ last.fm/Makefile	2009-02-15 14:24:24.000000000 -0300
 @@ -7,6 +7,7 @@
 
  PORTNAME=3D	last.fm
  PORTVERSION=3D	1.3.2.14
 +PORTREVISION=3D	1
  CATEGORIES=3D	audio net
  MASTER_SITES=3D	http://cdn.last.fm/client/src/
  DISTNAME=3D	${PORTNAME}-${PORTVERSION}.src
 @@ -36,18 +37,18 @@
  			-E -e 's|(.*"CONFIG-=3Ddebug")|\1 ${QMAKEFLAGS}|g' \
  			-e 's|function header|header()|g' \
  			-e 's|function middle|middle()|g' \
 +			-e 's|-pthread|-pthread -R/usr/local/share/last.fm|g' \
  		${WRKSRC}/configure
  	${REINPLACE_CMD} -e 's|linux\*|unix|g' ${WRKSRC}/src/src.pro
 
  post-build:
  	cd ${WRKSRC}/src/output/RtAudio && \
  	${SETENV} ${CONFIGURE_ENV} ${QMAKE} ${QMAKEFLAGS} && make
 -	${REINPLACE_CMD} -e 's|`dirname $$0`|${DATADIR}|g' \
 -		${WRKSRC}/bin/last.fm
 
  do-install:
 -	${INSTALL_SCRIPT} ${WRKSRC}/bin/last.fm ${PREFIX}/bin/last.fm
 -	${MKDIR} ${PREFIX}/share/services
 +	${INSTALL_SCRIPT} ${FILESDIR}/last.fm ${PREFIX}/bin/last.fm
 +	${MKDIR} ${PREFIX}/share/applications ${PREFIX}/share/services
 +	${INSTALL_DATA} ${FILESDIR}/last.fm.desktop ${PREFIX}/share/applications
  	${INSTALL_DATA} ${FILESDIR}/lastfm.protocol ${PREFIX}/share/services
  	${MKDIR} ${DATADIR}
  	${CP} -Rp ${WRKSRC}/bin/* ${DATADIR}/
 diff -durP last.fm.orig/files/last.fm last.fm/files/last.fm
 --- last.fm.orig/files/last.fm	1969-12-31 21:00:00.000000000 -0300
 +++ last.fm/files/last.fm	2009-02-15 12:35:46.000000000 -0300
 @@ -0,0 +1,13 @@
 +#!/bin/sh
 +# executes all *nix variants of Last.fm executable --mxcl
 +
 +RUNDIR=3D/usr/local/share/last.fm
 +LD_LIBRARY_PATH=3D$RUNDIR; export LD_LIBRARY_PATH
 +
 +if [ -f $RUNDIR/last.fm.app ]; then
 +    exec $RUNDIR/last.fm.app $*
 +elif [ -f $RUNDIR/last.fm.app_debug ]; then
 +    exec $RUNDIR/last.fm.app_debug $*
 +elif [ -d $RUNDIR/Last.fm.app ]; then
 +    exec $RUNDIR/Last.fm_debug $*
 +fi
 diff -durP last.fm.orig/files/last.fm.desktop last.fm/files/last.fm.desktop
 --- last.fm.orig/files/last.fm.desktop	1969-12-31 21:00:00.000000000 -0300
 +++ last.fm/files/last.fm.desktop	2009-02-15 09:09:06.000000000 -0300
 @@ -0,0 +1,20 @@
 +[Desktop Entry]
 +Name=3DClient for the Last.fm network
 +Name[de]=3DClient f=FCr das Last.fm-netzwerk
 +Name[es]=3DCliente para la red Last.fm
 +Name[it]=3DCliente per la rete di Last.fm
 +Name[pt_BR]=3DCliente para a rede Last.fm
 +Name[pt_PT]=3DCliente para a rede Last.fm
 +Comment=3DClient for the Last.fm Network
 +Comment[de]=3DClient f=FCr das Last.fm-Netzwerk
 +Comment[es]=3DCliente para la red Last.fm
 +Comment[it]=3DCliente per la rete di Last.fm
 +Comment[pt_BR]=3DCliente para a Rede Last.fm
 +Comment[pt_PT]=3DCliente para a Rede Last.fm
 +Exec=3Dlast.fm
 +Terminal=3Dfalse
 +Type=3DApplication
 +Encoding=3DUTF-8
 +Icon=3D/usr/local/share/last.fm/data/icons/as.png
 +Categories=3DAudioVideo;Player;Qt;
 +StartupNotify=3Dtrue
 diff -durP last.fm.orig/pkg-plist last.fm/pkg-plist
 --- last.fm.orig/pkg-plist	2007-09-14 16:02:22.000000000 -0300
 +++ last.fm/pkg-plist	2009-02-15 09:09:06.000000000 -0300
 @@ -108,6 +108,7 @@
  %%DATADIR%%/services/libsrv_itunesdevice.so
  %%DATADIR%%/services/libsrv_mp3transcode.so
  %%DATADIR%%/services/libsrv_rtaudioplayback.so
 +share/applications/last.fm.desktop
  share/services/lastfm.protocol
  @dirrmtry share/services
  @dirrm %%DATADIR%%/services
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D PATCH ENDS HERE =3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D
 
 
 --=20
 My preferred quotation of Robert Louis Stevenson is "You cannot
 make an omelette without breaking eggs". Not because I like the
 omelettes, but because I like the sound of eggs being broken.
State-Changed-From-To: open->closed 
State-Changed-By: amdmi3 
State-Changed-When: Mon Feb 16 21:50:16 UTC 2009 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127368 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/127368: commit references a PR
Date: Mon, 16 Feb 2009 21:50:25 +0000 (UTC)

 amdmi3      2009-02-16 21:50:09 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/last.fm        Makefile pkg-plist 
   Added files:
     audio/last.fm/files  last.fm.desktop 
   Log:
   - Add desktop entry
   
   PR:             127368
   Submitted by:   "Carlos A. M. dos Santos" <unixmania at gmail dot com>
   
   Revision  Changes    Path
   1.20      +3 -1      ports/audio/last.fm/Makefile
   1.1       +20 -0     ports/audio/last.fm/files/last.fm.desktop (new)
   1.4       +2 -0      ports/audio/last.fm/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: closed->open 
State-Changed-By: amdmi3 
State-Changed-When: Tue Feb 17 12:37:56 UTC 2009 
State-Changed-Why:  
Reopen, missed additional changes submitted in the followup. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127368 

From: "Carlos A. M. dos Santos" <unixmania@gmail.com>
To: bug-followup@freebsd.org
Cc: amdmi3@freebsd.org
Subject: Re: ports/127368: audio/last.fm: add a .desktop file for 
	Xfce/GNOME/KDE
Date: Mon, 23 Mar 2009 00:33:31 -0300

 On Tue, Feb 17, 2009 at 9:38 AM,  <amdmi3@freebsd.org> wrote:
 > Synopsis: audio/last.fm: add a .desktop file for Xfce/GNOME/KDE
 >
 > State-Changed-From-To: closed->open
 > State-Changed-By: amdmi3
 > State-Changed-When: Tue Feb 17 12:37:56 UTC 2009
 > State-Changed-Why:
 > Reopen, missed additional changes submitted in the followup.
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=127368
 >
 
 Ok, the patch below fixes the dynamic loading problem, adds a new
 version of the last.fm script and bumps the port revision.
 
 ========== PATCH STARTS HERE ==========
 diff -durP last.fm.orig/Makefile last.fm/Makefile
 --- last.fm.orig/Makefile	2009-02-21 17:27:49.000000000 -0300
 +++ last.fm/Makefile	2009-03-23 00:09:06.000000000 -0300
 @@ -7,7 +7,7 @@
 
  PORTNAME=	last.fm
  PORTVERSION=	1.3.2.14
 -PORTREVISION=	1
 +PORTREVISION=	2
  CATEGORIES=	audio net
  MASTER_SITES=	http://cdn.last.fm/client/src/
  DISTNAME=	${PORTNAME}-${PORTVERSION}.src
 @@ -37,17 +37,16 @@
  			-E -e 's|(.*"CONFIG-=debug")|\1 ${QMAKEFLAGS}|g' \
  			-e 's|function header|header()|g' \
  			-e 's|function middle|middle()|g' \
 +			-e 's|-pthread|-pthread -R/usr/local/share/last.fm|g' \
  		${WRKSRC}/configure
  	${REINPLACE_CMD} -e 's|linux\*|unix|g' ${WRKSRC}/src/src.pro
 
  post-build:
  	cd ${WRKSRC}/src/output/RtAudio && \
  	${SETENV} ${CONFIGURE_ENV} ${QMAKE} ${QMAKEFLAGS} && make
 -	${REINPLACE_CMD} -e 's|`dirname $$0`|${DATADIR}|g' \
 -		${WRKSRC}/bin/last.fm
 
  do-install:
 -	${INSTALL_SCRIPT} ${WRKSRC}/bin/last.fm ${PREFIX}/bin/last.fm
 +	${INSTALL_SCRIPT} ${FILESDIR}/last.fm ${PREFIX}/bin/last.fm
  	${MKDIR} ${PREFIX}/share/applications ${PREFIX}/share/services
  	${INSTALL_DATA} ${FILESDIR}/last.fm.desktop ${PREFIX}/share/applications
  	${INSTALL_DATA} ${FILESDIR}/lastfm.protocol ${PREFIX}/share/services
 diff -durP last.fm.orig/files/last.fm last.fm/files/last.fm
 --- last.fm.orig/files/last.fm	1969-12-31 21:00:00.000000000 -0300
 +++ last.fm/files/last.fm	2009-02-15 12:35:46.000000000 -0300
 @@ -0,0 +1,13 @@
 +#!/bin/sh
 +# executes all *nix variants of Last.fm executable --mxcl
 +
 +RUNDIR=/usr/local/share/last.fm
 +LD_LIBRARY_PATH=$RUNDIR; export LD_LIBRARY_PATH
 +
 +if [ -f $RUNDIR/last.fm.app ]; then
 +    exec $RUNDIR/last.fm.app $*
 +elif [ -f $RUNDIR/last.fm.app_debug ]; then
 +    exec $RUNDIR/last.fm.app_debug $*
 +elif [ -d $RUNDIR/Last.fm.app ]; then
 +    exec $RUNDIR/Last.fm_debug $*
 +fi
 ========== PATCH ENDS HERE ==========
 
 -- 
 My preferred quotation of Robert Louis Stevenson is "You cannot
 make an omelette without breaking eggs". Not because I like the
 omelettes, but because I like the sound of eggs being broken.
State-Changed-From-To: open->closed 
State-Changed-By: amdmi3 
State-Changed-When: Tue Mar 24 00:35:27 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127368 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/127368: commit references a PR
Date: Tue, 24 Mar 2009 00:35:34 +0000 (UTC)

 amdmi3      2009-03-24 00:35:23 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/last.fm        Makefile pkg-plist 
   Added files:
     audio/last.fm/files  last.fm 
   Log:
   - Fix dynamic loading problem
   - Add new version of last.fm script
   
   PR:             127368
   Submitted by:   "Carlos A. M. dos Santos" <unixmania at gmail dot com>
   
   Revision  Changes    Path
   1.21      +3 -4      ports/audio/last.fm/Makefile
   1.1       +13 -0     ports/audio/last.fm/files/last.fm (new)
   1.5       +0 -1      ports/audio/last.fm/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
