From nobody@FreeBSD.org  Sat Sep 13 07:32:58 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DF522106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Sep 2008 07:32:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id D08528FC1E
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Sep 2008 07:32:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m8D7WwaI085412
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Sep 2008 07:32:58 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m8D7Wwhp085411;
	Sat, 13 Sep 2008 07:32:58 GMT
	(envelope-from nobody)
Message-Id: <200809130732.m8D7Wwhp085411@www.freebsd.org>
Date: Sat, 13 Sep 2008 07:32:58 GMT
From: Matthias Fechner <idefix@fechner.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Upgrade of port net/asterisk-app-ldap for openldap 2.4
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         127344
>Category:       ports
>Synopsis:       Upgrade of port net/asterisk-app-ldap for openldap 2.4
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    amdmi3
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 13 07:40:03 UTC 2008
>Closed-Date:    Tue Sep 30 09:25:03 UTC 2008
>Last-Modified:  Tue Sep 30 09:30:05 UTC 2008
>Originator:     Matthias Fechner
>Release:        7.0-STABLE
>Organization:
>Environment:
System: FreeBSD server.idefix.lan 7.0-STABLE FreeBSD 7.0-STABLE #4: Sat Jul 19 11:54:07 CEST 2008 root@server.idefix.lan:/usr/obj/usr/src/sys/SERVER2_I4B i386

>Description:
Fixes problem with Openldap version 2.4
>How-To-Repeat:

>Fix:
Apply to following patch:

Patch attached with submission follows:

--- net/asterisk-app-ldap/Makefile.old	2008-09-12 14:56:01.000000000 +0200
+++ net/asterisk-app-ldap/Makefile	2008-09-12 15:10:21.000000000 +0200
@@ -11,12 +11,13 @@
 MASTER_SITES=	http://www.mezzo.net/asterisk/
 DISTNAME=	app_ldap-${DISTVERSION}
 EXTRACT_SUFX=	.tgz
+USE_OPENLDAP?= 24
 
 MAINTAINER=	idefix@fechner.net
 COMMENT=	LDAPget application module for the Asterisk PBX 1.4
 
 BUILD_DEPENDS=	asterisk:${PORTSDIR}/net/asterisk \
-		${LOCALBASE}/lib/libldap.so:${PORTSDIR}/net/openldap23-client \
+		${LOCALBASE}/lib/libldap.so:${PORTSDIR}/net/openldap${USE_OPENLDAP}-client \
 		${LOCALBASE}/lib/libiconv.so:${PORTSDIR}/converters/libiconv
 
 USE_GMAKE=	yes


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->amdmi3 
Responsible-Changed-By: amdmi3 
Responsible-Changed-When: Sat Sep 13 12:57:44 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127344 

From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/127344: Upgrade of port net/asterisk-app-ldap for
	openldap 2.4
Date: Wed, 24 Sep 2008 17:51:45 +0400

 > Synopsis: Upgrade of port net/asterisk-app-ldap for openldap 2.4
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=127344
 What do you think of improving it a bit:
 
 * USE_OPENLDAP assumes dependency on openldapXX-client, no BUILD_DEPEND
   is needed
 * USE_ICONV is a shorter way to depend on libiconv
 * Fix identation
 * [Depend on USE_OPENLDAP in more correct way]
 Actually I'm not sure what you intended to archieve with
 USE_OPENLDAP=24 - bsd.ldap.mk only checks if it's defiened, it never
 uses the value.
 
 According to bsd.ldap.mk, as in my patch, the port will use openldap 2.4
 by default, with ability for user to override it by adding corresponding
 WITH_OPENLDAP_VER in make.conf.
 
 However, if it's known that this port only works with specific opneldap
 version or doesn't work with specific openldap versions, corresponding
 WANT_OPENLDAP_VER or IGNORE_WITH_OPENLDAP should be set.
 
 --- asterisk-app-ldap.patch begins here ---
 Index: Makefile
 ===================================================================
 RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/net/asterisk-app-ldap/Makefile,v
 retrieving revision 1.3
 diff -u -r1.3 Makefile
 --- Makefile	25 May 2007 11:56:59 -0000	1.3
 +++ Makefile	24 Sep 2008 13:34:05 -0000
 @@ -7,6 +7,7 @@
  
  PORTNAME=	asterisk-app-ldap
  DISTVERSION=	2.0rc1
 +PORTREVISION=	1
  CATEGORIES=	net
  MASTER_SITES=	http://www.mezzo.net/asterisk/
  DISTNAME=	app_ldap-${DISTVERSION}
 @@ -15,13 +16,13 @@
  MAINTAINER=	idefix@fechner.net
  COMMENT=	LDAPget application module for the Asterisk PBX 1.4
  
 -BUILD_DEPENDS=	asterisk:${PORTSDIR}/net/asterisk \
 -		${LOCALBASE}/lib/libldap.so:${PORTSDIR}/net/openldap23-client \
 -		${LOCALBASE}/lib/libiconv.so:${PORTSDIR}/converters/libiconv
 +BUILD_DEPENDS=	asterisk:${PORTSDIR}/net/asterisk
  
  USE_GMAKE=	yes
 +USE_ICONV=	yes
 +USE_OPENLDAP=	yes
  
  PLIST_FILES=	lib/asterisk/modules/app_ldap.so \
 -				etc/asterisk/ldap.conf.sample
 +		etc/asterisk/ldap.conf.sample
  
  .include <bsd.port.mk>
 --- asterisk-app-ldap.patch ends here ---
 
 -- 
 Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
 amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
State-Changed-From-To: open->feedback 
State-Changed-By: amdmi3 
State-Changed-When: Thu Sep 25 21:56:47 UTC 2008 
State-Changed-Why:  
Awaiting maintainer's feedback regarding improved patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127344 

From: linimon@lonesome.com (Mark Linimon)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/127344: Upgrade of port net/asterisk-app-ldap for openldap 2.4
Date: Sun, 28 Sep 2008 04:16:17 -0500

 ----- Forwarded message from Matthias Fechner <idefix@fechner.net> -----
 
 From: Matthias Fechner <idefix@fechner.net>
 To: amdmi3@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
 Cc: 
 Subject: Re: ports/127344: Upgrade of port net/asterisk-app-ldap for openldap
  2.4
 
 amdmi3@FreeBSD.org schrieb:
 > Awaiting maintainer's feedback regarding improved patch.
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=127344
 
 I rechecked the port and a switch to another version of LDAP is not
 possible because other depending packages are enforcing openldap 2.4.
 
 I tested the patch and it works fine on a fresh installed FreeBSD.
 
 Thanks a lot for your improvement tips, please commit the new version.
 
 Bye
 Matthias
 
 -- 
 
 "Programming today is a race between software engineers striving to
 build bigger and better idiot-proof programs, and the universe trying to
 produce bigger and better idiots. So far, the universe is winning." --
 Rich Cook
 _______________________________________________
 freebsd-ports-bugs@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
 To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"
 
 
 ----- End forwarded message -----
State-Changed-From-To: feedback->closed 
State-Changed-By: amdmi3 
State-Changed-When: Tue Sep 30 09:25:02 UTC 2008 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127344 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/127344: commit references a PR
Date: Tue, 30 Sep 2008 09:25:02 +0000 (UTC)

 amdmi3      2008-09-30 09:24:49 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/asterisk-app-ldap Makefile 
   Log:
   - Add support for openldap 2.4
   - Clean port up a bit
   
   PR:             127344
   Submitted by:   Matthias Fechner <idefix at fechner dot net> (maintainer)
   Improved by:    me (approved by maintainer)
   
   Revision  Changes    Path
   1.4       +5 -4      ports/net/asterisk-app-ldap/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
