From adamw@FreeBSD.org  Sun Sep  7 01:54:47 2008
Return-Path: <adamw@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 765E21065675
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  7 Sep 2008 01:54:47 +0000 (UTC)
	(envelope-from adamw@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 6BA458FC17
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  7 Sep 2008 01:54:47 +0000 (UTC)
	(envelope-from adamw@FreeBSD.org)
Received: from freefall.freebsd.org (adamw@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m871sl7u015895
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 7 Sep 2008 01:54:47 GMT
	(envelope-from adamw@freefall.freebsd.org)
Received: (from adamw@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m871sla7015894;
	Sun, 7 Sep 2008 01:54:47 GMT
	(envelope-from adamw)
Message-Id: <200809070154.m871sla7015894@freefall.freebsd.org>
Date: Sun, 7 Sep 2008 01:54:47 GMT
From: Adam Weinberger <adamw@freebsd.org>
Reply-To: Adam Weinberger <adamw@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Allow ${TAR} to be overridden in ghostscript8
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         127165
>Category:       ports
>Synopsis:       Allow ${TAR} to be overridden in print/ghostscript8
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    doceng
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 07 02:00:07 UTC 2008
>Closed-Date:    Sun Oct 05 03:17:04 UTC 2008
>Last-Modified:  Sun Oct  5 03:20:02 UTC 2008
>Originator:     Adam Weinberger
>Release:        FreeBSD 7.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 7.0-STABLE FreeBSD 7.0-STABLE #34: Sat Apr 12 11:52:18 UTC 2008 simon@freefall.freebsd.org:/usr/src/sys/i386/compile/FREEFALL i386


	
>Description:
If you've overridden ${TAR} (say, to add other options), the invocation
in the port Makefile has to be ${TAR} -options. If the Makefile uses
${TAR} options (i.e., no hyphen), tar freaks out.

Attached patch simply adds hyphens before the options, and allows ${TAR}
to be overridden in, for example, /etc/make.conf.
>How-To-Repeat:
	
>Fix:

It's been a very long time since I've sent a PR. If I'm putting the patch
in wrong, I apologize in advance.


Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/print/ghostscript8/Makefile,v
retrieving revision 1.174
diff -u -r1.174 Makefile
--- Makefile	25 Jul 2008 12:24:08 -0000	1.174
+++ Makefile	7 Sep 2008 01:50:08 -0000
@@ -250,8 +250,8 @@
 	${INSTALL_DATA} ${WRKSRC}/contrib/japanese/doc/* ${WRKSRC}/contrib/japanese
 	${MKDIR} ${DOCSDIR}
 	cd ${WRKSRC}/contrib && \
-		${TAR} cf - ${PORTDOC_FILES} | \
-		( cd ${DOCSDIR} && ${TAR} xof - )
+		${TAR} -cf - ${PORTDOC_FILES} | \
+		( cd ${DOCSDIR} && ${TAR} -xof - )
 
 .if defined(WITH_FT_BRIDGE)
 post-install-fapi:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->doceng 
Responsible-Changed-By: adamw 
Responsible-Changed-When: Sun Sep 7 02:00:57 UTC 2008 
Responsible-Changed-Why:  
Over to doceng. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127165 
State-Changed-From-To: open->closed 
State-Changed-By: hrs 
State-Changed-When: Sun Oct 5 03:16:41 UTC 2008 
State-Changed-Why:  
Committed, thanks for your report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=127165 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/127165: commit references a PR
Date: Sun,  5 Oct 2008 03:14:18 +0000 (UTC)

 hrs         2008-10-05 03:14:05 UTC
 
   FreeBSD ports repository
 
   Modified files:
     print/ghostscript8   Makefile 
   Log:
   Add a hyphen to ${TAR}'s option.  It is useful when ${TAR} is
   overridden by the user.
   
   Submitted by:   adamw
   PR:             ports/127165
   
   Revision  Changes    Path
   1.176     +2 -2      ports/print/ghostscript8/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
